[
https://issues.apache.org/jira/browse/OFBIZ-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964463#action_12964463 ]
Scott Gray commented on OFBIZ-4035:
-----------------------------------
Hi Sacha, I like the idea but there are a few issues with your patch:
1. You should never change a public method's signature, instead deprecate the existing method and create a new one (this is in regards to getIdName())
2. Passing a null context in ContainerField constructor would not have worked properly, in r1039769 I've removed the id code from the constructor and you can now get the id during rendering in the same manner as the display field.
3. Consistency is very important, we cannot change form.field[id-name] to a FlexibleStringExpander and leave all the others as plain Strings, if one is to change then they all need to change. I haven't looked everywhere but here are a few others:
- form[id]
- menu[id]
- menu.menu-item.link[id]
Regards
Scott
> change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExapander
> ----------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4035
> URL:
https://issues.apache.org/jira/browse/OFBIZ-4035> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4035_ModelFormField.java.patch
>
>
> hi there,
> here a little useful improvement. i changed the ID Field of an input field in in the macro form renderer from a normal String to a flexible String expander.
> The advantage is that i can use ${} variables in the id description, that helps me for example creating automatically unique id's.
> Cheers
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Locked
