[jira] Created: (OFBIZ-4051) i18n for elrte editor

[Nicolas Malin (Jira)]

i18n for elrte editor
---------------------

                 Key: OFBIZ-4051
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL COMPONENTS
    Affects Versions: jQuery
            Reporter: Erwan de FERRIERES
            Priority: Minor
             Fix For: jQuery


elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969696#action_12969696 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Hi Erwan,

Could you be more explicit? Thanks

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4051:
-----------------------------------

    Issue Type: Sub-task  (was: Improvement)
        Parent: OFBIZ-3814

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969697#action_12969697 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Ha, I see. You mean that we should add our own. And it's done internally, right (at the top of elrte.full.js it's easy to see)?  If it the case, I think we should ask elRte team if it could not be externalized, like it's done with jQuery UI for instance. We could then supply our own and other teams as well...

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969706#action_12969706 ]

Erwan de FERRIERES commented on OFBIZ-4051:
-------------------------------------------

Hi Jacques,

elrte is already providing the translation files, in js/i18n. We just have to make it work !

This issue is more a reminder, as it will be a problem when end-users will be using it. I don't think this would take a lot of time to implement!

Cheers,

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969720#action_12969720 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Thanks Erwan,

I have added those files at r1043949. Please let me know if it's enough or if we need more work

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969729#action_12969729 ]

Erwan de FERRIERES commented on OFBIZ-4051:
-------------------------------------------

Thanks Jacques, but it seems there is more work than this to be done...

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-4051:
-----------------------------------

    Attachment: elrte_i18n.patch
                elrte_i18n.zip

Hi guys,
ok i added a language flag in the editor macro. It reads the language from the userLogin and if the last locale field isn't empty the language file will be loaded.

to add this feature:
1.) extract the zip and copy the files to : framework/images/webapp/images/jquery/plugins/elrteEditor/i18n
2.) apply the patch file

Have a good day
Cheers
Sascha

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969733#action_12969733 ]

Sascha Rodekamp commented on OFBIZ-4051:
----------------------------------------

Oh i missed that you just added the files ... when they in the right directory you simply have to apply the patch Jacques ;)

thanks a lot

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969748#action_12969748 ]

Erwan de FERRIERES commented on OFBIZ-4051:
-------------------------------------------

I'll look at it tonight ! Thanks Sascha

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES updated OFBIZ-4051:
--------------------------------------

    Assignee: Erwan de FERRIERES

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969750#action_12969750 ]

Sascha Rodekamp commented on OFBIZ-4051:
----------------------------------------

Cool Erwan, Thanks

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969762#action_12969762 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Sascha, Erwan,

I had a quick look. As, like jQuery UI, elrte editor uses also the language.country couple, please check that we don't nee to use something like the snippet I have introduced for the calendar

<set field="initialLocaleComplete" type="String" value="${groovy:parameters?.userLogin?.lastLocale}" default-value="${groovy:locale.toString()}"/>
<set field="initialLocale" type="String" value="${groovy:parameters?.userLogin?.lastLocale?.substring(0,2)}" default-value="${groovy:locale.toString()?.substring(0,2)?:'en'}"/>
<set field="localeFileNameComplete" type="String" value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocaleComplete}.js"/>
<set field="localeFileNameComplete" type="String" value="${groovy: localeFileNameComplete.replace('_', '-')}"/> <!-- those files are build this way OOTB (ie a - not a _ between language and country -->
<set field="fileNameComplete" type="String" value="${groovy: org.ofbiz.base.location.FlexibleLocation.resolveLocation('component://images/webapp' + localeFileNameComplete)}"/>
<set field="localeFileName" type="String" value="/images/jquery/ui/development-bundle/ui/i18n/jquery.ui.datepicker-${initialLocale}.js"/>
<set field="localeJsFile" type="String" value="${groovy: fileNameComplete ? localeFileNameComplete : localeFileName}"/>
<set field="layoutSettings.javaScripts[+0]" value="${localeJsFile}" global="true"/>

From elrte.zh_TW. I suppose that the *replace('_', '-')* trick should not be needed

Thanks

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-4051.
-------------------------------------

    Resolution: Fixed

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969951#action_12969951 ]

Erwan de FERRIERES commented on OFBIZ-4051:
-------------------------------------------

Done at 1044132. Thanks Jacques and Sascha.

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970117#action_12970117 ]

Sascha Rodekamp commented on OFBIZ-4051:
----------------------------------------

Thanks Erwan for you're effort :-)

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970303#action_12970303 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

As I suspected this needs a bit more work to handle the language.country.couple case. I will handle it. I have found also a small bug. Anyway I'm merging the branchin the trunk so it will be fixed in the trunk...

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970306#action_12970306 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Oops sorry, it's ok, actually it was only the language file which was missing. So only this little bug to fix when you come from a form, cool :)

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

dukian updated OFBIZ-4051:
--------------------------

    Attachment: elret-zh_TW-modified-result.jpg
                OFBIZ-4051_zh_TW.patch

Thanks for Jacques highlights Chinese issue.

After checks two cases: datepicker is fine, but el-rte not.

There are many different i18n file naming approaches for Traditional Chinese ... OFBiz uses java way: zh_TW, datepicker uses zh-TW, and el-rte needs patch as attachment(OFBIZ-4051_zh_TW.patch).

According to elrte.(min|full).js, the full version is Line 1108:
 
{quote}
    this.lang      = (''+this.options.lang).toLowerCase();
    this._i18n     = new eli18n({textdomain : 'rte', messages : { rte : this.i18Messages[this.lang] || {}} });
{quote}

el-rte needs lower case "TWO_LETTER_LANG_CODE" in translation file.

I'll file this issue to el-rte project too.

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elret-zh_TW-modified-result.jpg, elrte_i18n.patch, elrte_i18n.zip, OFBIZ-4051_zh_TW.patch
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970437#action_12970437 ]

Jacques Le Roux commented on OFBIZ-4051:
----------------------------------------

Thanks Dukian,

Right they look rather for a zh_tw file. It's weird that someone (Tad <[hidden email]>) recently provided the elrte.zh_TW.js file though. I wonder if s/he did not test it at all. You could maybe also contact her/him?

Your patch is in trunk at r1044615, we don't use the jQuery branch anymore

> i18n for elrte editor
> ---------------------
>
>                 Key: OFBIZ-4051
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL COMPONENTS
>    Affects Versions: jQuery
>            Reporter: Erwan de FERRIERES
>            Assignee: Erwan de FERRIERES
>            Priority: Minor
>             Fix For: jQuery
>
>         Attachments: elret-zh_TW-modified-result.jpg, elrte_i18n.patch, elrte_i18n.zip, OFBIZ-4051_zh_TW.patch
>
>
> elrte editor has its i18n files included in the archive

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.