[jira] Created: (OFBIZ-4090) Add Support For Compound Screen Widget XML Files

[Nicolas Malin (Jira)]

Add Support For Compound Screen Widget XML Files
------------------------------------------------

                 Key: OFBIZ-4090
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Adrian Crum
            Priority: Minor


Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4090:
-------------------------------

    Attachment: CompoundWidgetFiles.patch

The attached patch demonstrates the concept.

There is an issue preventing it from being committed: The XML validator reports errors because the schemas don't contain a target namespace. If I add a target namespace to the schemas, the validator reports errors because it was expecting the target namespcae to be empty. I don't know how to solve that problem and I'm hoping an XML expert can figure it out.

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4090:
-------------------------------

    Attachment: CompoundWidgetFiles.patch

Updated patch file. XML parsing errors have been fixed with new schemas. Modifying the existing schemas didn't work because that caused parsing errors on existing screens (~1MB log entries per request).

This patch also adds the ability to include a controller <site-conf> element in the compound widget file - an idea suggested by David.

It all works and it is ready to commit if the community agrees it is a worthwhile improvement.

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4090:
-------------------------------

    Attachment: CompoundWidgetFiles.patch

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4090:
-------------------------------

    Attachment:     (was: CompoundWidgetFiles.patch)

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978115#action_12978115 ]

Paul Foxworthy commented on OFBIZ-4090:
---------------------------------------

I would prefer a more descriptive name than "root" for the root element. What about "widgets" or "ofbiz-widgets"?

Shouldn't there be a schema for the root element, whatever name it has, specifying the valid name for the root element and valid subelements within it? It would be a very simple schema compared to the ones for screen widgets etc, but should be there for completeness, I think. Any reason why not?

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978137#action_12978137 ]

Adrian Crum commented on OFBIZ-4090:
------------------------------------

The root element could be called anything. "widgets" sounds good to me.

I created a schema for the root element, but I couldn't get it to work. The file would parse fine, but in Eclipse all of the elements were shifted down one level - meaning auto-complete would insert values from child elements, not the selected element. Maybe it's just a problem with Eclipse - I don't know.

If anyone can improve upon the patch, they are welcome to do so.

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978579#action_12978579 ]

Paul Foxworthy commented on OFBIZ-4090:
---------------------------------------

Is it easy for you to post a screenshot showing the problem? I don't use Eclipse, so I can't see what you're seeing.

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978686#action_12978686 ]

Adrian Crum commented on OFBIZ-4090:
------------------------------------

Here is the root schema I tried:

{code}
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema"
           elementFormDefault="qualified">
    <xs:element name="root">
        <xs:complexType>
            <xs:all minOccurs="0" maxOccurs="1">
                <xs:element name="site-conf"/>
                <xs:element name="simple-methods"/>
                <xs:element name="forms"/>
                <xs:element name="menus"/>
                <xs:element name="trees"/>
                <xs:element name="screens"/>
            </xs:all>
        </xs:complexType>
    </xs:element>
</xs:schema>
{code}

In Eclipse, you can right-click on an XML element and a popup menu appears with valid selections for that element - based on the schema. I can't provide a screen shot because now the popup menu doesn't show any suggestions from the schema. I'm almost certain it's a bug in Eclipse's XML editor.

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976459#comment-12976459 ]

Adrian Crum edited comment on OFBIZ-4090 at 4/4/12 11:54 PM:
-------------------------------------------------------------

The attached patch demonstrates the concept.

There is an issue preventing it from being committed: The XML validator reports errors because the schemas don't contain a target namespace. If I add a target namespace to the schemas, the validator reports errors because it was expecting the target namespace to be empty. I don't know how to solve that problem and I'm hoping an XML expert can figure it out.

               
      was (Author: [hidden email]):
    The attached patch demonstrates the concept.

There is an issue preventing it from being committed: The XML validator reports errors because the schemas don't contain a target namespace. If I add a target namespace to the schemas, the validator reports errors because it was expecting the target namespcae to be empty. I don't know how to solve that problem and I'm hoping an XML expert can figure it out.

                 

> Add Support For Compound Screen Widget XML Files
> ------------------------------------------------
>
>                 Key: OFBIZ-4090
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4090
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: CompoundWidgetFiles.patch, CompoundWidgetFiles.patch
>
>
> Add the ability to include screen widgets, form widgets, menu widgets, and simple methods in a single XML file. This approach could be used in situations where the widgets share a logical grouping - so they can be kept in one place.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira