[jira] Created: (OFBIZ-4092) Update The Flat Grey Visual Theme
Locked
1234
1234
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
 
|
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979639#action_12979639 ] Ryan Foster commented on OFBIZ-4092: ------------------------------------ I also noticed you changed the design objectives to include a statement that javascript should not be required. If that is the case, then I will really have to step back and think about my approach for graceful degradation on the main navigation since the key design principle for this section is based on the fact that the list falls into columns. I am curious as to why you feel this should be a key objective. Since the framework web apps themselves are heavily dependent on javascript in certain areas, shouldn't it be assumed that the user will always have javascript available? If they don't, they are going have a lot more issues with functionality than just having a visual display that is a little off. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979640#action_12979640 ] Adrian Crum commented on OFBIZ-4092: ------------------------------------ Ryan, No worries. I also worked on making the masthead and main-navigation resizable - so they grow and shrink with font size changes. I would prefer to defer to you - you're the master, I'm the grasshopper. I will wait for your update before proceeding further. The main thing is to use Firefox, turn off JavaScript, change the default font to 24 or higher, resize the screen and see what happens. The layout in the patch you provided breaks badly under those conditions. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979641#action_12979641 ] Adrian Crum commented on OFBIZ-4092: ------------------------------------ I added the 4th item because it was a part of the original Flat Grey theme, but I forgot to include it when I created this issue. As far as I know, the screen widget renderers check to see if JavaScript is enabled and output the appropriate markup. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979652#action_12979652 ] Ryan Foster commented on OFBIZ-4092: ------------------------------------ hmm... Is there a way we can do something similar using FreeMarker in appbar.ftl instead of using Javascript? Could we create a macro that reads the numbers of apps then outputs a series of lists in the appropriate amount of columns. If that is possible that would actually be a better solution since then we wouldn't have to wait until the page fully loads and the DOM is ready before applying the column styling. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979657#action_12979657 ] Adrian Crum commented on OFBIZ-4092: ------------------------------------ It's in my patch. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979870#action_12979870 ] Ryan Foster commented on OFBIZ-4092: ------------------------------------ duh, I guess I should have actually read your patch first before I started thinking out loud. Your solution looks great. I made couple of small tweaks to it to remove some markup that I thought wasn't really necessary. For instance, we don't really need to enclose each app title in in a <p> tag since the <a> is already set to display block. I also put a set height to the <li> tag and removed the empty <p> tags with spaces from the last <li>. Please don't take this personally, but one of my biggest pet peeves is using spaces and breaks in markup to control layout. Let's try to avoid that as much as possible. I have incorporated the changes from your last patch and made a few more design changes as well in my latest patch. 1. added additional styling to the main navigation to highlight the select app a bit more. 2. expanded on your change to the selected app navigation link to give it even more distinction 3. enhanced the styling of the tab-bar area. 4. added some misc. CSS3 styling enhancements to main nav and app nav areas for browsers that support text-shadow. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Foster updated OFBIZ-4092: ------------------------------- Attachment: flatgrey.patch > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-4092: ------------------------------- Attachment: ac_images.zip ac_flatgrey.patch Ryan, I have attached files that represent what I had developed just prior to today's conversation. Take a look at the changes and see if you can use any more ideas from them. The masthead, main-application, and app-navigation areas grow with font size changes - try it out. That required some background changes in CSS and PNG files. I tried out your new patch. I think you went a little too far to the other extreme. ;-) Maybe we could stick with the styles in my last patch. I really like the idea of visual elements floating on sand. In this updated patch I made it the background for the HTML element - that way we can move things around if we want. The page-title style might benefit from a drop shadow. I'm not sure about the drop shadow on the app-navigation - it looks odd to me. Btw, I tested my changes with Firefox, Safari, and IE8. I think we're almost there! > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979955#action_12979955 ] Adrian Crum commented on OFBIZ-4092: ------------------------------------ Also note that I changed the bevels in the main-navigation so their shadow matches the other elements. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980201#action_12980201 ] Adrian Crum commented on OFBIZ-4092: ------------------------------------ Ryan, A few more suggestions: 1. app-navigation h1-h3 class, try color: #959595; 2. h1 and page-title classes, try color: #557996; I like how your initial version toned down the contrasting colors, and these suggestions follow that concept. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Issue Comment Edited: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980201#action_12980201 ] Adrian Crum edited comment on OFBIZ-4092 at 1/11/11 12:38 PM: -------------------------------------------------------------- Ryan, A few more suggestions: 1. app-navigation h1-h3 class, try color: #959595; 2. column-container h1 and page-title classes, try color: #557996; I like how your initial version toned down the contrasting colors, and these suggestions follow that concept. was (Author: [hidden email]): Ryan, A few more suggestions: 1. app-navigation h1-h3 class, try color: #959595; 2. h1 and page-title classes, try color: #557996; I like how your initial version toned down the contrasting colors, and these suggestions follow that concept. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980217#action_12980217 ] Ryan Foster commented on OFBIZ-4092: ------------------------------------ I agree with you. I'm starting to stray from my original design concept which was meant to be subtle, sophisticated and conservative. Things are starting to pop out a bit too much in places. Time to rein it in ;). I'll take a look at this today. We are definitely very close. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-4092: ------------------------------- Attachment: brushed-aluminum.gif Ryan, I uploaded a brushed aluminum gif file. I tried it out as an alternate app-navigation background with these borders: border-bottom: 0.1em solid #bbb; border-top: 0.1em solid #ddd; It looks pretty cool with the h1-h3 color I suggested. With the drop shadow it looks like the application's title is chiseled into the aluminum. It degrades nicely in browsers that don't support drop shadow. This is totally optional - please don't feel obligated to use it (or any other suggestion). If we could tone down the contrast on the pager (list) navigation and footer (maybe using one of the blues from the main navigation or a shade of grey) then I think we will have a real winner. Not only is the result easy on the eyes, it's actually kind of soothing to look at. I would like to get this committed on Friday. I'm anxious to start another initiative and I want to get this one behind me. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980331#action_12980331 ] Ryan Foster commented on OFBIZ-4092: ------------------------------------ I'll do my best to take a look at what you have and finalize my changes today. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980770#action_12980770 ] Adrian Crum commented on OFBIZ-4092: ------------------------------------ Some thoughts on the text transformations... The upper case transformation looks good on main navigation and the application title. The lower case transformation on the application navigation looks bad. Most of the screen contains u&l case text, and having one set of links that are all lower case makes that section of the screen look like it doesn't belong there. The same is true for the upper case buttons - they don't quite fit in with the rest of the screen. My recommendation would be to keep the upper case transformations on main navigation and application title, and drop the rest. > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980862#action_12980862 ] Ryan Foster commented on OFBIZ-4092: ------------------------------------ I agree with you on the casing for the navigation and title. The casing on the buttons, and in fact the buttons themselves, are a different issue entirely. The reason why I changed the casing with CSS is because there is no consistency in casing in the markup and labels. Some button labels and values are all caps, some are lowercase, some are normal case; it's all over the map. Button styling in OFBiz has been something that has bugged me for years and I think it would be very beneficial to look at this as a separate issue in the near future. There are currently 13, yes 13!, different button styles currently defined right now. Just look at lines 2556 through 2573 in maincss.css. We have: .buttontext, .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit, .loginButton, .button-style-1, .button-style-2, .button, button, input[type="reset"], input[type="submit"], input[type="button"] it's kind of ridiculous. Why can't we simply have 1 button class and call it some obvious like .button or .btn? We have been having a great discussion on UI labeling consistency, "Edit" vs. "Update" vs. "Save", etc. which is awesome, but I think all of that is meaningless if the buttons themselves don't look the same. Okay, I'll end my rant there. Can you tell this is something of a hot button issue with me, pun completely intended ;) > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980872#action_12980872 ] Adrian Crum commented on OFBIZ-4092: ------------------------------------ I understand your frustration. When the new styles were created the old styles were deprecated and we started to remove them - but that effort eventually fizzled out. In addition, we just introduced more styles with JQuery. I agree it's a mess and we should create a new issue for that. Or we could just delete the deprecated styles from the style sheet and let the elements that use them break - that might motivate others to stop using them. I started a Wiki page to document current styles and their intended use, but it hasn't been kept up-to-date: https://cwiki.apache.org/OFBIZ/ofbiz-maincsscss-html-element-collection-styles.html > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883 ] Ryan Foster commented on OFBIZ-4092: ------------------------------------ I tried deleting deprecated styles and letting things break when I created the BizznessTime theme... mostly just pissed people off. :) > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980884#action_12980884 ] Jacques Le Roux commented on OFBIZ-4092: ---------------------------------------- Yes, I agree we should really do an effort regarding this aspect an other closely related. As Adrian outlined, consistence is a key point! > Update The Flat Grey Visual Theme > --------------------------------- > > Key: OFBIZ-4092 > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: SVN trunk > Reporter: Adrian Crum > Assignee: Adrian Crum > Priority: Minor > Attachments: ac_flatgrey.patch, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png > > > Update the Flat Grey visual theme. Design objectives: > 1. Floating, flexible layout - screen can be resized. > 2. Sight impaired accessible - users can change font size in their browser. > 3. Supports RTL layout. > 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme
|
|
In reply to this post by Nicolas Malin (Jira)
In addition, when deprecating or selecting styles to be used we should
better use style names that describe what the button IS in the screen and not HOW it should appear. So style names like .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit, .button-style-1, .button-style-2, should not be used. Style names like: .buttontext, .loginButton, .button, input[type="reset"], input[type="submit"], input[type="button"] are OK. In this way the theme can make a button larger or smaller than another button according to its function. My two cents. -Bruno 2011/1/12 Ryan Foster (JIRA) <[hidden email]> > > [ > https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883] > > Ryan Foster commented on OFBIZ-4092: > ------------------------------------ > > I tried deleting deprecated styles and letting things break when I created > the BizznessTime theme... mostly just pissed people off. :) > > > Update The Flat Grey Visual Theme > > --------------------------------- > > > > Key: OFBIZ-4092 > > URL: https://issues.apache.org/jira/browse/OFBIZ-4092 > > Project: OFBiz > > Issue Type: Improvement > > Components: framework > > Affects Versions: SVN trunk > > Reporter: Adrian Crum > > Assignee: Adrian Crum > > Priority: Minor > > Attachments: ac_flatgrey.patch, ac_images.zip, > accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, > catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, > flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, > ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, > timeSheet.png > > > > > > Update the Flat Grey visual theme. Design objectives: > > 1. Floating, flexible layout - screen can be resized. > > 2. Sight impaired accessible - users can change font size in their > browser. > > 3. Supports RTL layout. > > 4. Does not require JavaScript. JavaScript can be used to add > embellishments, but the theme can't depend on it. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |