[jira] Created: (OFBIZ-4092) Update The Flat Grey Visual Theme

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
61 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

Discussion: CSS styles (was: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme)

Adrian Crum
We need the smallSubmit style so we can style links to look like submit
buttons. Maybe we could change the CSS class to "a.smallSubmit" to make
sure it is used only for <a> elements.

The button-style-1 and button-style-2 style names are pretty generic -
they don't indicate how the button should appear (aside from the obvious
- that they should look like buttons). Originally, the rows of buttons
below the page title had two styles that indicated two types of buttons:
those that linked to other pages within the application (intra-app) and
others that linked to pages outside the application (inter-app). That
distinction has been lost in recent changes.

A similar thing was done with the table header styles - there are two
styles to choose from, depending on how you use them. The style names
don't indicate what they look like.

I don't think there is anything wrong with having more than one style to
choose from. If we were to cut back too much on the selection, then the
UI would start to look bland or monotonous.

I created a Wiki page that listed some of the deprecated styles and
another page that describes the new styles and how they should be used.
Those pages are effective only when people take the time to read them.

-Adrian

On 1/12/2011 12:01 PM, Bruno Busco wrote:

> In addition, when deprecating or selecting styles to be used we should
> better use style names that describe what the button IS in the screen and
> not HOW it should appear.
>
> So style names like
> .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
> .button-style-1, .button-style-2,
>
> should not be used.
>
> Style names like:
> .buttontext,
> .loginButton,
> .button,
> input[type="reset"],
> input[type="submit"],
> input[type="button"]
>
> are OK.
> In this way the theme can make a button larger or smaller than another
> button according to its function.
>
> My two cents.
> -Bruno
>
> 2011/1/12 Ryan Foster (JIRA)<[hidden email]>
>
>>
>>     [
>> https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883]
>>
>> Ryan Foster commented on OFBIZ-4092:
>> ------------------------------------
>>
>> I tried deleting deprecated styles and letting things break when I created
>> the BizznessTime theme... mostly just pissed people off.  :)
>>
>>> Update The Flat Grey Visual Theme
>>> ---------------------------------
>>>
>>>                  Key: OFBIZ-4092
>>>                  URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>>>              Project: OFBiz
>>>           Issue Type: Improvement
>>>           Components: framework
>>>     Affects Versions: SVN trunk
>>>             Reporter: Adrian Crum
>>>             Assignee: Adrian Crum
>>>             Priority: Minor
>>>          Attachments: ac_flatgrey.patch, ac_images.zip,
>> accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
>> catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
>> flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
>> ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
>> timeSheet.png
>>>
>>>
>>> Update the Flat Grey visual theme. Design objectives:
>>> 1. Floating, flexible layout - screen can be resized.
>>> 2. Sight impaired accessible - users can change font size in their
>> browser.
>>> 3. Supports RTL layout.
>>> 4. Does not require JavaScript. JavaScript can be used to add
>> embellishments, but the theme can't depend on it.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

Ryan Foster-3
In reply to this post by Bruno Busco
Bruno,

I'll see your 2 cents, and raise you a dollar.  I agree, the naming of an element should never dictate how it looks or behaves; that is what properties are for.  You are opening up a can of worms with me when you start down that path, so careful what you wish for.  Buttons aren't the only offenders when it comes to that, the problem starts with the main decorator.  The layout of the backend and the front end center around the fact that we have column layouts with classNames of .left, .right, and .center.  What if I don't want .left on the left anymore?...

Ryan L. Foster
801.671.0769
[hidden email]
ryanlfoster.com

On Jan 12, 2011, at 1:01 PM, Bruno Busco wrote:

> In addition, when deprecating or selecting styles to be used we should
> better use style names that describe what the button IS in the screen and
> not HOW it should appear.
>
> So style names like
> .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
> .button-style-1, .button-style-2,
>
> should not be used.
>
> Style names like:
> .buttontext,
> .loginButton,
> .button,
> input[type="reset"],
> input[type="submit"],
> input[type="button"]
>
> are OK.
> In this way the theme can make a button larger or smaller than another
> button according to its function.
>
> My two cents.
> -Bruno
>
> 2011/1/12 Ryan Foster (JIRA) <[hidden email]>
>
>>
>>   [
>> https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883]
>>
>> Ryan Foster commented on OFBIZ-4092:
>> ------------------------------------
>>
>> I tried deleting deprecated styles and letting things break when I created
>> the BizznessTime theme... mostly just pissed people off.  :)
>>
>>> Update The Flat Grey Visual Theme
>>> ---------------------------------
>>>
>>>                Key: OFBIZ-4092
>>>                URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>>>            Project: OFBiz
>>>         Issue Type: Improvement
>>>         Components: framework
>>>   Affects Versions: SVN trunk
>>>           Reporter: Adrian Crum
>>>           Assignee: Adrian Crum
>>>           Priority: Minor
>>>        Attachments: ac_flatgrey.patch, ac_images.zip,
>> accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
>> catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
>> flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
>> ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
>> timeSheet.png
>>>
>>>
>>> Update the Flat Grey visual theme. Design objectives:
>>> 1. Floating, flexible layout - screen can be resized.
>>> 2. Sight impaired accessible - users can change font size in their
>> browser.
>>> 3. Supports RTL layout.
>>> 4. Does not require JavaScript. JavaScript can be used to add
>> embellishments, but the theme can't depend on it.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: Discussion: CSS styles (was: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme)

Ryan Foster-3
In reply to this post by Adrian Crum
Consistency is not synonymous with monotonous.  Hey, that sounds like a good catch phrase... Consistency is not synonymous with monotonous™

But seriously, if different elements perform the same way then they should look the same and be called the same thing.  There is no reason why we can't have <button class="btn">, <input type="submit" class="btn">, and <a class="btn"> if they all do the same thing.  That doesn't make the UI bland, it makes it consistent and familiar.  I'm all for having options, but they should be done with a purpose.  For instance, we could a primary button style, a secondary button style and a tertiary button style, but these should be combinations, not individual style.  For example:

<a href="#" class="btn primary">
<a href="#" class="btn secondary">
<a href="#" class="btn tertiary">

That way, we could apply a consistent button style and then make adjustments if we need to based on what action the button performs, Save vs. Cancel, etc.  But simply having a button-style-1, and a button-style-2 because maybe we want to have a blue button and a green button is not a good reason, no is it a good idea.  Having 2 buttons that perform the same, but look different just confuses the user and makes an already complex application even more difficult to use.

Ryan L. Foster
801.671.0769
[hidden email]
ryanlfoster.com

On Jan 12, 2011, at 1:30 PM, Adrian Crum wrote:

> We need the smallSubmit style so we can style links to look like submit buttons. Maybe we could change the CSS class to "a.smallSubmit" to make sure it is used only for <a> elements.
>
> The button-style-1 and button-style-2 style names are pretty generic - they don't indicate how the button should appear (aside from the obvious - that they should look like buttons). Originally, the rows of buttons below the page title had two styles that indicated two types of buttons: those that linked to other pages within the application (intra-app) and others that linked to pages outside the application (inter-app). That distinction has been lost in recent changes.
>
> A similar thing was done with the table header styles - there are two styles to choose from, depending on how you use them. The style names don't indicate what they look like.
>
> I don't think there is anything wrong with having more than one style to choose from. If we were to cut back too much on the selection, then the UI would start to look bland or monotonous.
>
> I created a Wiki page that listed some of the deprecated styles and another page that describes the new styles and how they should be used. Those pages are effective only when people take the time to read them.
>
> -Adrian
>
> On 1/12/2011 12:01 PM, Bruno Busco wrote:
>> In addition, when deprecating or selecting styles to be used we should
>> better use style names that describe what the button IS in the screen and
>> not HOW it should appear.
>>
>> So style names like
>> .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
>> .button-style-1, .button-style-2,
>>
>> should not be used.
>>
>> Style names like:
>> .buttontext,
>> .loginButton,
>> .button,
>> input[type="reset"],
>> input[type="submit"],
>> input[type="button"]
>>
>> are OK.
>> In this way the theme can make a button larger or smaller than another
>> button according to its function.
>>
>> My two cents.
>> -Bruno
>>
>> 2011/1/12 Ryan Foster (JIRA)<[hidden email]>
>>
>>>
>>>    [
>>> https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883]
>>>
>>> Ryan Foster commented on OFBIZ-4092:
>>> ------------------------------------
>>>
>>> I tried deleting deprecated styles and letting things break when I created
>>> the BizznessTime theme... mostly just pissed people off.  :)
>>>
>>>> Update The Flat Grey Visual Theme
>>>> ---------------------------------
>>>>
>>>>                 Key: OFBIZ-4092
>>>>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>>>>             Project: OFBiz
>>>>          Issue Type: Improvement
>>>>          Components: framework
>>>>    Affects Versions: SVN trunk
>>>>            Reporter: Adrian Crum
>>>>            Assignee: Adrian Crum
>>>>            Priority: Minor
>>>>         Attachments: ac_flatgrey.patch, ac_images.zip,
>>> accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
>>> catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
>>> flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
>>> ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
>>> timeSheet.png
>>>>
>>>>
>>>> Update the Flat Grey visual theme. Design objectives:
>>>> 1. Floating, flexible layout - screen can be resized.
>>>> 2. Sight impaired accessible - users can change font size in their
>>> browser.
>>>> 3. Supports RTL layout.
>>>> 4. Does not require JavaScript. JavaScript can be used to add
>>> embellishments, but the theme can't depend on it.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.
>>>
>>>
>>

Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

Jacques Le Roux
Administrator
In reply to this post by Ryan Foster-3
That's great guys, but it would be better if you could keep your comments in the OFBIZ-4092
Really easier later when looking back to have things centralized somewhere (I saw Adrian tried to create a new thread...)

Thanks

Jacques

Ryan Foster wrote:

> Bruno,
>
> I'll see your 2 cents, and raise you a dollar.  I agree, the naming of an element should never dictate how it looks or behaves;
> that is what properties are for.  You are opening up a can of worms with me when you start down that path, so careful what you
> wish for.  Buttons aren't the only offenders when it comes to that, the problem starts with the main decorator.  The layout of
> the backend and the front end center around the fact that we have column layouts with classNames of .left, .right, and .center.
> What if I don't want .left on the left anymore?...
>
> Ryan L. Foster
> 801.671.0769
> [hidden email]
> ryanlfoster.com
>
> On Jan 12, 2011, at 1:01 PM, Bruno Busco wrote:
>
>> In addition, when deprecating or selecting styles to be used we should
>> better use style names that describe what the button IS in the screen and
>> not HOW it should appear.
>>
>> So style names like
>> .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
>> .button-style-1, .button-style-2,
>>
>> should not be used.
>>
>> Style names like:
>> .buttontext,
>> .loginButton,
>> .button,
>> input[type="reset"],
>> input[type="submit"],
>> input[type="button"]
>>
>> are OK.
>> In this way the theme can make a button larger or smaller than another
>> button according to its function.
>>
>> My two cents.
>> -Bruno
>>
>> 2011/1/12 Ryan Foster (JIRA) <[hidden email]>
>>
>>>
>>>   [
>>> https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883]
>>>
>>> Ryan Foster commented on OFBIZ-4092:
>>> ------------------------------------
>>>
>>> I tried deleting deprecated styles and letting things break when I created
>>> the BizznessTime theme... mostly just pissed people off.  :)
>>>
>>>> Update The Flat Grey Visual Theme
>>>> ---------------------------------
>>>>
>>>>                Key: OFBIZ-4092
>>>>                URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>>>>            Project: OFBiz
>>>>         Issue Type: Improvement
>>>>         Components: framework
>>>>   Affects Versions: SVN trunk
>>>>           Reporter: Adrian Crum
>>>>           Assignee: Adrian Crum
>>>>           Priority: Minor
>>>>        Attachments: ac_flatgrey.patch, ac_images.zip,
>>> accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
>>> catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
>>> flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
>>> ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
>>> timeSheet.png
>>>>
>>>>
>>>> Update the Flat Grey visual theme. Design objectives:
>>>> 1. Floating, flexible layout - screen can be resized.
>>>> 2. Sight impaired accessible - users can change font size in their
>>> browser.
>>>> 3. Supports RTL layout.
>>>> 4. Does not require JavaScript. JavaScript can be used to add
>>> embellishments, but the theme can't depend on it.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> You can reply to this email to add a comment to the issue online.


Reply | Threaded
Open this post in threaded view
|

Re: Discussion: CSS styles

Adrian Crum
In reply to this post by Ryan Foster-3
Keep in mind that the button-style-* classes are button-bar decorators.
Having two buttons that perform the same but look different was not an
issue here - the two styles indicated two different purposes, PLUS they
were in different button bars. So, you had a row of buttons in one style
that were intra-app, and another row of buttons in a different style
that were inter-app. There was no confusion - the styles and the
separation into two rows were a clear visual indicator of where the link
was going to take you.

The purpose of the button-bar style was to provide a container for
graphic artists to design around. The buttons could be arranged in a row
(the current orientation) or they could be a vertical stack.

-Adrian

On 1/12/2011 1:05 PM, Ryan Foster wrote:

> Consistency is not synonymous with monotonous.  Hey, that sounds like a good catch phrase... Consistency is not synonymous with monotonous™
>
> But seriously, if different elements perform the same way then they should look the same and be called the same thing.  There is no reason why we can't have<button class="btn">,<input type="submit" class="btn">, and<a class="btn">  if they all do the same thing.  That doesn't make the UI bland, it makes it consistent and familiar.  I'm all for having options, but they should be done with a purpose.  For instance, we could a primary button style, a secondary button style and a tertiary button style, but these should be combinations, not individual style.  For example:
>
> <a href="#" class="btn primary">
> <a href="#" class="btn secondary">
> <a href="#" class="btn tertiary">
>
> That way, we could apply a consistent button style and then make adjustments if we need to based on what action the button performs, Save vs. Cancel, etc.  But simply having a button-style-1, and a button-style-2 because maybe we want to have a blue button and a green button is not a good reason, no is it a good idea.  Having 2 buttons that perform the same, but look different just confuses the user and makes an already complex application even more difficult to use.
>
> Ryan L. Foster
> 801.671.0769
> [hidden email]
> ryanlfoster.com
>
> On Jan 12, 2011, at 1:30 PM, Adrian Crum wrote:
>
>> We need the smallSubmit style so we can style links to look like submit buttons. Maybe we could change the CSS class to "a.smallSubmit" to make sure it is used only for<a>  elements.
>>
>> The button-style-1 and button-style-2 style names are pretty generic - they don't indicate how the button should appear (aside from the obvious - that they should look like buttons). Originally, the rows of buttons below the page title had two styles that indicated two types of buttons: those that linked to other pages within the application (intra-app) and others that linked to pages outside the application (inter-app). That distinction has been lost in recent changes.
>>
>> A similar thing was done with the table header styles - there are two styles to choose from, depending on how you use them. The style names don't indicate what they look like.
>>
>> I don't think there is anything wrong with having more than one style to choose from. If we were to cut back too much on the selection, then the UI would start to look bland or monotonous.
>>
>> I created a Wiki page that listed some of the deprecated styles and another page that describes the new styles and how they should be used. Those pages are effective only when people take the time to read them.
>>
>> -Adrian
>>
>> On 1/12/2011 12:01 PM, Bruno Busco wrote:
>>> In addition, when deprecating or selecting styles to be used we should
>>> better use style names that describe what the button IS in the screen and
>>> not HOW it should appear.
>>>
>>> So style names like
>>> .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
>>> .button-style-1, .button-style-2,
>>>
>>> should not be used.
>>>
>>> Style names like:
>>> .buttontext,
>>> .loginButton,
>>> .button,
>>> input[type="reset"],
>>> input[type="submit"],
>>> input[type="button"]
>>>
>>> are OK.
>>> In this way the theme can make a button larger or smaller than another
>>> button according to its function.
>>>
>>> My two cents.
>>> -Bruno
>>>
>>> 2011/1/12 Ryan Foster (JIRA)<[hidden email]>
>>>
>>>>
>>>>     [
>>>> https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883]
>>>>
>>>> Ryan Foster commented on OFBIZ-4092:
>>>> ------------------------------------
>>>>
>>>> I tried deleting deprecated styles and letting things break when I created
>>>> the BizznessTime theme... mostly just pissed people off.  :)
>>>>
>>>>> Update The Flat Grey Visual Theme
>>>>> ---------------------------------
>>>>>
>>>>>                  Key: OFBIZ-4092
>>>>>                  URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>>>>>              Project: OFBiz
>>>>>           Issue Type: Improvement
>>>>>           Components: framework
>>>>>     Affects Versions: SVN trunk
>>>>>             Reporter: Adrian Crum
>>>>>             Assignee: Adrian Crum
>>>>>             Priority: Minor
>>>>>          Attachments: ac_flatgrey.patch, ac_images.zip,
>>>> accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
>>>> catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch,
>>>> flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip,
>>>> ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
>>>> timeSheet.png
>>>>>
>>>>>
>>>>> Update the Flat Grey visual theme. Design objectives:
>>>>> 1. Floating, flexible layout - screen can be resized.
>>>>> 2. Sight impaired accessible - users can change font size in their
>>>> browser.
>>>>> 3. Supports RTL layout.
>>>>> 4. Does not require JavaScript. JavaScript can be used to add
>>>> embellishments, but the theme can't depend on it.
>>>>
>>>> --
>>>> This message is automatically generated by JIRA.
>>>> -
>>>> You can reply to this email to add a comment to the issue online.
>>>>
>>>>
>>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Discussion: CSS styles

Adrian Crum
Some background and additional thoughts for the community in general,
not Ryan specifically...

In 2007 the UI was refactored - partially because of the same reason
mentioned here: too many styles in the style sheet and no consistency in
their use.

At around the same time we were also adding a lot of new contributors
and committers to the community. I started to notice that the UI layout
was losing consistency - and I assumed it was because the new commits
weren't being checked thoroughly.

In 2008 there was another UI refactor that drastically changed the
layout - where nearly every screen was wrapped in a screenlet. That
layout change was never discussed with the community, and I have no idea
why it was made.

So, I created a Wiki page of UI Layout Best Practices for others to
refer to:

https://cwiki.apache.org/confluence/display/OFBADMIN/User+Interface+Layout+Best+Practices

That document is intended to describe basic layout - from a typesetter's
perspective. Specific CSS styles shouldn't be mentioned in it, but they
are - and I plan to fix that when I have time. The document is based on
the de-facto UI layout prior to things going bad.

I use those Best Practices myself - even recently when I moved the
security UI artifacts from the Party component to the Common component.
Once I understand the basic layout, I go to the HTML markup page:

https://cwiki.apache.org/OFBIZ/ofbiz-maincsscss-html-element-collection-styles.html

to see what styles are available to lay out the page.

It was my hope that those documents would help keep the UI consistent,
but like I said earlier - they are only effective if people read them.

I said all that to say this: It's common for style sheets to bloat, and
it's common for UI layout to creep. It takes conversations like this one
to bring the bloat and creep to the community's attention, but it won't
change until someone takes action.

-Adrian


On 1/12/2011 1:29 PM, Adrian Crum wrote:

> Keep in mind that the button-style-* classes are button-bar decorators.
> Having two buttons that perform the same but look different was not an
> issue here - the two styles indicated two different purposes, PLUS they
> were in different button bars. So, you had a row of buttons in one style
> that were intra-app, and another row of buttons in a different style
> that were inter-app. There was no confusion - the styles and the
> separation into two rows were a clear visual indicator of where the link
> was going to take you.
>
> The purpose of the button-bar style was to provide a container for
> graphic artists to design around. The buttons could be arranged in a row
> (the current orientation) or they could be a vertical stack.
>
> -Adrian
>
> On 1/12/2011 1:05 PM, Ryan Foster wrote:
>> Consistency is not synonymous with monotonous. Hey, that sounds like a
>> good catch phrase... Consistency is not synonymous with monotonous™
>>
>> But seriously, if different elements perform the same way then they
>> should look the same and be called the same thing. There is no reason
>> why we can't have<button class="btn">,<input type="submit"
>> class="btn">, and<a class="btn"> if they all do the same thing. That
>> doesn't make the UI bland, it makes it consistent and familiar. I'm
>> all for having options, but they should be done with a purpose. For
>> instance, we could a primary button style, a secondary button style
>> and a tertiary button style, but these should be combinations, not
>> individual style. For example:
>>
>> <a href="#" class="btn primary">
>> <a href="#" class="btn secondary">
>> <a href="#" class="btn tertiary">
>>
>> That way, we could apply a consistent button style and then make
>> adjustments if we need to based on what action the button performs,
>> Save vs. Cancel, etc. But simply having a button-style-1, and a
>> button-style-2 because maybe we want to have a blue button and a green
>> button is not a good reason, no is it a good idea. Having 2 buttons
>> that perform the same, but look different just confuses the user and
>> makes an already complex application even more difficult to use.
>>
>> Ryan L. Foster
>> 801.671.0769
>> [hidden email]
>> ryanlfoster.com
>>
>> On Jan 12, 2011, at 1:30 PM, Adrian Crum wrote:
>>
>>> We need the smallSubmit style so we can style links to look like
>>> submit buttons. Maybe we could change the CSS class to
>>> "a.smallSubmit" to make sure it is used only for<a> elements.
>>>
>>> The button-style-1 and button-style-2 style names are pretty generic
>>> - they don't indicate how the button should appear (aside from the
>>> obvious - that they should look like buttons). Originally, the rows
>>> of buttons below the page title had two styles that indicated two
>>> types of buttons: those that linked to other pages within the
>>> application (intra-app) and others that linked to pages outside the
>>> application (inter-app). That distinction has been lost in recent
>>> changes.
>>>
>>> A similar thing was done with the table header styles - there are two
>>> styles to choose from, depending on how you use them. The style names
>>> don't indicate what they look like.
>>>
>>> I don't think there is anything wrong with having more than one style
>>> to choose from. If we were to cut back too much on the selection,
>>> then the UI would start to look bland or monotonous.
>>>
>>> I created a Wiki page that listed some of the deprecated styles and
>>> another page that describes the new styles and how they should be
>>> used. Those pages are effective only when people take the time to
>>> read them.
>>>
>>> -Adrian
>>>
>>> On 1/12/2011 12:01 PM, Bruno Busco wrote:
>>>> In addition, when deprecating or selecting styles to be used we should
>>>> better use style names that describe what the button IS in the
>>>> screen and
>>>> not HOW it should appear.
>>>>
>>>> So style names like
>>>> .buttontextbig, .smallSubmit, .mediumSubmit, .largeSubmit,
>>>> .button-style-1, .button-style-2,
>>>>
>>>> should not be used.
>>>>
>>>> Style names like:
>>>> .buttontext,
>>>> .loginButton,
>>>> .button,
>>>> input[type="reset"],
>>>> input[type="submit"],
>>>> input[type="button"]
>>>>
>>>> are OK.
>>>> In this way the theme can make a button larger or smaller than another
>>>> button according to its function.
>>>>
>>>> My two cents.
>>>> -Bruno
>>>>
>>>> 2011/1/12 Ryan Foster (JIRA)<[hidden email]>
>>>>
>>>>>
>>>>> [
>>>>> https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980883#action_12980883]
>>>>>
>>>>>
>>>>> Ryan Foster commented on OFBIZ-4092:
>>>>> ------------------------------------
>>>>>
>>>>> I tried deleting deprecated styles and letting things break when I
>>>>> created
>>>>> the BizznessTime theme... mostly just pissed people off. :)
>>>>>
>>>>>> Update The Flat Grey Visual Theme
>>>>>> ---------------------------------
>>>>>>
>>>>>> Key: OFBIZ-4092
>>>>>> URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>>>>>> Project: OFBiz
>>>>>> Issue Type: Improvement
>>>>>> Components: framework
>>>>>> Affects Versions: SVN trunk
>>>>>> Reporter: Adrian Crum
>>>>>> Assignee: Adrian Crum
>>>>>> Priority: Minor
>>>>>> Attachments: ac_flatgrey.patch, ac_images.zip,
>>>>> accounting800x600.png, brushed-aluminum.gif, catalog800x600.png,
>>>>> catalogManager.png, content800x600.png, contentManager.png,
>>>>> flatgrey.patch,
>>>>> flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch,
>>>>> images.zip,
>>>>> ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif,
>>>>> timeSheet.png
>>>>>>
>>>>>>
>>>>>> Update the Flat Grey visual theme. Design objectives:
>>>>>> 1. Floating, flexible layout - screen can be resized.
>>>>>> 2. Sight impaired accessible - users can change font size in their
>>>>> browser.
>>>>>> 3. Supports RTL layout.
>>>>>> 4. Does not require JavaScript. JavaScript can be used to add
>>>>> embellishments, but the theme can't depend on it.
>>>>>
>>>>> --
>>>>> This message is automatically generated by JIRA.
>>>>> -
>>>>> You can reply to this email to add a comment to the issue online.
>>>>>
>>>>>
>>>>
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4092:
-------------------------------

    Attachment: ac_flatgrey.patch
                ac_images.zip

Updated files. Contains Ryan's appbar.ftl plus bug fixes. I converted the masthead and main nav png images to gif - so the transitions are smoother. Masthead and main nav can be increased to any size without breaking. Improved seed data - OFBiz icon doesn't need to be in framework/images any more. Tightened up spacing a little on app navigation.

These changes are suggestions - comments are welcome.


> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4092:
-------------------------------

    Attachment:     (was: ac_flatgrey.patch)

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_images.zip, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4092:
-------------------------------

    Attachment: ac_images.zip

Updated images zip file - the last one was missing a file.

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_images.zip, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4092:
-------------------------------

    Attachment:     (was: ac_images.zip)

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum updated OFBIZ-4092:
-------------------------------

    Attachment: ac_flatgrey.patch

Replaced file that was accidentally deleted.

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981788#action_12981788 ]

Adrian Crum commented on OFBIZ-4092:
------------------------------------

Ryan,

Is there any chance you could upload what you have so far?


> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Foster updated OFBIZ-4092:
-------------------------------

    Attachment: rf_flatgrey.patch

Incorporated Adrian's styling and bug fixes from latest patch, dialed back styling from my latest patch.

Adrian,
I see where you were going with the whole resizing header idea, but IMHO, I just don't think it looks good.  Having a scrollbar in the masthead just feels really weird to me.  My latest patch leaves that piece out.

Also updated app-navigation background image with a new darker, textured image.  Not as bold as your brushed aluminum, but not quite as light as the image I had there before.  Take a look and let me know what you think.  This is my last patch for this effort.  Feel free to make any other mods that you think might be necessary, but I am pretty comfortable rolling with this as-is.

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Foster updated OFBIZ-4092:
-------------------------------

    Attachment: rf_flatgrey_images.zip

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982030#action_12982030 ]

Adrian Crum commented on OFBIZ-4092:
------------------------------------

Thanks Ryan!

I will work on finalizing the theme this weekend and get it committed.

I understand an artist would have a problem with seeing scrollbars when font sizes are increased to a large size, but in the end the users of OFBiz have a job to do and work to get done. They won't mind the scrollbars if it means they can read the screen. Btw, on my HD widescreen monitor I can crank up the font size to 26 without any scrollbars. So, I'll probably put that back.

The only other mods I will make will be bug fixes. I like what you've done, and I believe the updated theme will benefit the community.


> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982035#action_12982035 ]

Adrian Crum commented on OFBIZ-4092:
------------------------------------

Ryan,

Just curious - the subdued colors and app navigation selected style I suggested didn't look good to you?


> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-4092.
------------------------------

    Resolution: Fixed

Fixed, rev 1059564.

Ryan,

I had a few issues with the design. The page-container background image produced an undesirable horizontal band on the login screen, so I commented it out. To see it, you have to set the default visual theme to FLAT_GREY. Also, I wasn't able to commit the __MACOSX folder - Subversion gave me an error message like "Invalid URL" or something. I don't know if that folder is needed in the project. If it is, maybe another committer can figure out what the problem is.

I commented out some of the drop shadows you added in later versions. They made some things harder to read, and doing too much of it seemed kind of gimmicky.

I had hoped we could have toned down some of the dark bands that remain.

Thank you for all your work! The new design is much better than the old one.


> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982332#action_12982332 ]

Jacques Le Roux commented on OFBIZ-4092:
----------------------------------------

I like it, very fast acces to features, thanks guys!

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982517#action_12982517 ]

Sascha Rodekamp commented on OFBIZ-4092:
----------------------------------------

Oh yes that's really amazing, i like the new Flat Gray.

Many Thanks *Ryan* and *Adrian* for your effort!!!

Cheers

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982762#action_12982762 ]

Ryan Foster commented on OFBIZ-4092:
------------------------------------

The _MACOSX folder is a hidden system folder for Apple.  Not necessary.  Feel free to blow that away.  My original intent was actually to create a generic login screen style, similar to the way the BizznessTime theme, but that task got lost in the shuffle.  I'll see if I can get you a new patch that addresses that within the next couple of days.

All in all, I think everything looks great.  I look forward to community feedback.

> Update The Flat Grey Visual Theme
> ---------------------------------
>
>                 Key: OFBIZ-4092
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Adrian Crum
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, ac_images.zip, accounting800x600.png, brushed-aluminum.gif, catalog800x600.png, catalogManager.png, content800x600.png, contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, timeSheet.png
>
>
> Update the Flat Grey visual theme. Design objectives:
> 1. Floating, flexible layout - screen can be resized.
> 2. Sight impaired accessible - users can change font size in their browser.
> 3. Supports RTL layout.
> 4. Does not require JavaScript. JavaScript can be used to add embellishments, but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

1234