Brazilian Portuguese translation to labels in framework/common/config - Second part
----------------------------------------------------------------------------------- Key: OFBIZ-4094 URL: https://issues.apache.org/jira/browse/OFBIZ-4094 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Environment: 1055255 Reporter: Luís Alfredo Harriss Maranesi Priority: Trivial Fix For: SVN trunk Brazilian Portuguese translation to labels in framework/common/config - Second part -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[ https://issues.apache.org/jira/browse/OFBIZ-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luís Alfredo Harriss Maranesi updated OFBIZ-4094: ------------------------------------------------- Attachment: OFBIZ-4094_BR_Portuguese__Common_Part_2.patch Brazilian Portuguese translation to labels in framework/common/config - Second part > Brazilian Portuguese translation to labels in framework/common/config - Second part > ----------------------------------------------------------------------------------- > > Key: OFBIZ-4094 > URL: https://issues.apache.org/jira/browse/OFBIZ-4094 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Environment: 1055255 > Reporter: Luís Alfredo Harriss Maranesi > Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4094_BR_Portuguese__Common_Part_2.patch > > > Brazilian Portuguese translation to labels in framework/common/config - Second part -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977573#action_12977573 ] Adrian Crum commented on OFBIZ-4094: ------------------------------------ Luis, If it isn't too much work, could you test something for me? Some of the files you are providing translations for already have a Portuguese translation. In OFBiz, if you select Portuguese (Brazil) you should see the Portuguese (pt) UI labels displayed. If not, I need to know - because that's a bug in the program. The idea is, if a pt label exists, and the Brazil translation is the same, then you shouldn't have to add a pt_BR label. For example, in CommonUiLabels.xml, line 95 there is a Catalog label with an existing pt translation. You have added a pt_BR translation that is identical. You shouldn't have to do that. If a pt_BR label doesn't exist, OFBiz should fall back to the pt label. If the pt label doesn't exist, then it should fall back to en. Could you try it out and let me know please? > Brazilian Portuguese translation to labels in framework/common/config - Second part > ----------------------------------------------------------------------------------- > > Key: OFBIZ-4094 > URL: https://issues.apache.org/jira/browse/OFBIZ-4094 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Environment: 1055255 > Reporter: Luís Alfredo Harriss Maranesi > Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4094_BR_Portuguese__Common_Part_2.patch > > > Brazilian Portuguese translation to labels in framework/common/config - Second part -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977601#action_12977601 ] Luís Alfredo Harriss Maranesi commented on OFBIZ-4094: ------------------------------------------------------ Hi Adrian, First of all, sorry for my lack of knowlodge. I didn't know about that. I thought that the best idea was to have a label for each locale. I tried to test it for the label you indicated but I couldn't. Even though it's classified at Webtools as a label in use I really couldn't find it in the system. So I tested with the label "CommonActiveInactive". It's working as you expected to. When I remove the pt_BR label the system uses pt instead. Again I'd like to apologise. I'll fix all the problems removing any repetition in all files I have sent. But I have a question: What is the best practice to unused labels? We should let them as they are or delete them? Luís > Brazilian Portuguese translation to labels in framework/common/config - Second part > ----------------------------------------------------------------------------------- > > Key: OFBIZ-4094 > URL: https://issues.apache.org/jira/browse/OFBIZ-4094 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Environment: 1055255 > Reporter: Luís Alfredo Harriss Maranesi > Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4094_BR_Portuguese__Common_Part_2.patch > > > Brazilian Portuguese translation to labels in framework/common/config - Second part -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977603#action_12977603 ] Adrian Crum commented on OFBIZ-4094: ------------------------------------ Don't worry about removing the duplicates - it's not that important. It would be best to delete unused labels in a separate issue. Translations in one issue, remove duplicate labels in another issue. That makes it easier for committers to review your work. > Brazilian Portuguese translation to labels in framework/common/config - Second part > ----------------------------------------------------------------------------------- > > Key: OFBIZ-4094 > URL: https://issues.apache.org/jira/browse/OFBIZ-4094 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Environment: 1055255 > Reporter: Luís Alfredo Harriss Maranesi > Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4094_BR_Portuguese__Common_Part_2.patch > > > Brazilian Portuguese translation to labels in framework/common/config - Second part -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977606#action_12977606 ] Luís Alfredo Harriss Maranesi commented on OFBIZ-4094: ------------------------------------------------------ Ok, I see. But Now what should I do to finish this last translation I've sent? > Brazilian Portuguese translation to labels in framework/common/config - Second part > ----------------------------------------------------------------------------------- > > Key: OFBIZ-4094 > URL: https://issues.apache.org/jira/browse/OFBIZ-4094 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Environment: 1055255 > Reporter: Luís Alfredo Harriss Maranesi > Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4094_BR_Portuguese__Common_Part_2.patch > > > Brazilian Portuguese translation to labels in framework/common/config - Second part -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-4094: ---------------------------------- Assignee: Adrian Crum > Brazilian Portuguese translation to labels in framework/common/config - Second part > ----------------------------------------------------------------------------------- > > Key: OFBIZ-4094 > URL: https://issues.apache.org/jira/browse/OFBIZ-4094 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Environment: 1055255 > Reporter: Luís Alfredo Harriss Maranesi > Assignee: Adrian Crum > Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4094_BR_Portuguese__Common_Part_2.patch > > > Brazilian Portuguese translation to labels in framework/common/config - Second part -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-4094. ------------------------------ Resolution: Fixed Fixed, rev 1055290. Thanks Luis! > Brazilian Portuguese translation to labels in framework/common/config - Second part > ----------------------------------------------------------------------------------- > > Key: OFBIZ-4094 > URL: https://issues.apache.org/jira/browse/OFBIZ-4094 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS > Affects Versions: SVN trunk > Environment: 1055255 > Reporter: Luís Alfredo Harriss Maranesi > Assignee: Adrian Crum > Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4094_BR_Portuguese__Common_Part_2.patch > > > Brazilian Portuguese translation to labels in framework/common/config - Second part -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
Free forum by Nabble | Edit this page |