I did not thought it could be a problem to add them there. I will revert right now...
> I hate seeing stuff like this committed in this way.
>
> Was there any review and discussion of where tax data is currently stored in the cart item? What about more complex tax cases
> (like multiple tax authorities, happens with VAT too...) where these simple numbers are not so useful and my be misleading? What
> about cases where tax values change and the price doesn't (yep, it's in the code...).
>
> This code is already full of stuff that is unused, or that if used will cause problems. Why add more without review?
>
> These methods could very well exist, but the data shouldn't come from there... it should come from the tax adjustments associated
> with the item.
>
> -David
>
>
> On Jan 11, 2011, at 2:45 AM, Jacques Le Roux (JIRA) wrote:
>
>>
>> [
https://issues.apache.org/jira/browse/OFBIZ-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Jacques Le Roux closed OFBIZ-4104.
>> ----------------------------------
>>
>> Resolution: Fixed
>> Assignee: Jacques Le Roux
>>
>> Thanks Jonas,
>>
>> This is a nice improvement. But please in the future provide patches with no absolute pathes. Your patch did not apply until I
>> removed the a/ and b/...
>>
>> Your patch is in trunk at r1057571
>>
>>
>>
>>> add taxPercentage and taxTotal member variables to ShoppingCartItem to ease tax calculation and display
>>> -------------------------------------------------------------------------------------------------------
>>>
>>> Key: OFBIZ-4104
>>> URL:
https://issues.apache.org/jira/browse/OFBIZ-4104>>> Project: OFBiz
>>> Issue Type: Improvement
>>> Components: order
>>> Affects Versions: SVN trunk
>>> Reporter: Jonas Hoef
>>> Assignee: Jacques Le Roux
>>> Fix For: SVN trunk
>>>
>>> Attachments: OFBIZ-4104-tax-enhancement-shoppingcartitem.patch
>>>
>>>
>>> Legal requirements in Germany mandate that tax-information is displayed for each shopping cart item. This is supported by the
>>> proposed improvement.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>
Locked
