[jira] Created: (OFBIZ-4119) Form Widget hyperlink issue.

[Nicolas Malin (Jira)]

Form Widget hyperlink issue.
----------------------------

                 Key: OFBIZ-4119
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: Release Branch 10.04, SVN trunk
            Reporter: Ankit Jain
            Priority: Minor
             Fix For: Release Branch 10.04, SVN trunk


If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.

By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-4119:
------------------------------

    Attachment: OFBIZ-4119.patch

Here is the patch for the above issue.

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4119.
----------------------------------

    Resolution: Invalid
      Assignee: Jacques Le Roux

Hi Ankit,

Actually there is a reason to this hidden field, please read http://markmail.org/message/cxofqfvhfrianu6e

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-4119:
------------------------------------


Ha sorry Ankit,

I was abused by the title and forgot the id case. I will commit this part soon...

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4119.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: Release Branch 10.04)

Thanks Ankit,

Your modified patch is in trunk at r1060229

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983063#action_12983063 ]

Ankit Jain commented on OFBIZ-4119:
-----------------------------------

Hello Jacques,

Thanks for committing the patch but you have missed the changes of the ModelForm.java Please have a look at the attached patch.

Thanks
Ankit Jain

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983077#action_12983077 ]

Jacques Le Roux commented on OFBIZ-4119:
----------------------------------------

Hi Ankit,

Did you read my comment above?

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983086#action_12983086 ]

Ankit Jain commented on OFBIZ-4119:
-----------------------------------

Hi Jacques,

I have just seen the commit, and not read your comment properly(the word modified), May i know the reason why you didn't commit the changes of that file?
     
FYI, the changes of the ModelForm.java file should be committed because to avoid the creation of a hidden input field with the same id as the <a> tag's.

Regards
Ankit Jain

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983089#action_12983089 ]

Jacques Le Roux commented on OFBIZ-4119:
----------------------------------------

The reason is explained in the link in my comment above. But then if there are duplicates Ids I wonder if we should not revert it all..

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-4119:
------------------------------------


To be clarified...
* Ids duplicated
* missing other other templates/*FormMacroLibrary.ftl files

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983111#action_12983111 ]

Jacopo Cappellato commented on OFBIZ-4119:
------------------------------------------

Jacques is raising up an interesting point; a solution to the duplicated ids issue can be the one of assigning a different id to the hidden element
for example, if we have
<field name="somefield" id="abc" also-hidden="true"><hyperlink .../></field>
we could generate the following two html elements
<a id="abc" .../>
and
<hidden id="h_abc" />
where the h_ prefix (or similar) is only used if the hidden field is generated from an also-hidden attribute.

What do you think?

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983126#action_12983126 ]

Jacques Le Roux commented on OFBIZ-4119:
----------------------------------------

Sounds good to me

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983228#action_12983228 ]

Jacques Le Roux commented on OFBIZ-4119:
----------------------------------------

Reverted at r1060417 (thanks to Adrian for reminder)
 
I let Ankit handles the hidden Id case...

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-4119:
------------------------------

    Attachment: OFBIZ-4119.patch

Hello Jacques,

This is the updated and working patch I have done the changes as Jacopo suggested, please have a look.

In this patch I have completed the points of
# Duplicate Ids.
# Missing other templates/*FormMacroLibrary.ftl files

Now if  <field id-name="abc">  and for
< hyperlink, display,... also-hidden="true"> then an hidden input created with id="h_abc".
<input id="h_abc"  value="" ..../>

and for <hidden /> the same id will be set as given by developer.

Thanks Jacopo , Jacques.

Regards
Ankit Jain

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch, OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983815#action_12983815 ]

Jacques Le Roux commented on OFBIZ-4119:
----------------------------------------

Hi Ankit,

I'm maybe missing something but I don't think it works. In ListSecurityGroups form (Party) I have tried to change the hyperlink of the field groupId from also-hidden="false" to true. I don't get a hidden field with an id="h_... , even not a hidden field and moreover it never passes by id = "h_" + id;  in MacroFormRenderer.java. Could you please have a look. Maybe you used another use case for your tests?

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch, OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984067#action_12984067 ]

Ankit Jain commented on OFBIZ-4119:
-----------------------------------

Hello Jacques,

I have checked the point raised by you and yes you are right I didn't found any hidden field with h_..., then I reverted my changes and checked once again and found the same behaviour means didn't found any hidden field, then I come to know that if the form is of type list then no hidden input generated for it if you change also-hidden="true", So it may be another issue

You can check here,

form type list https://localhost:28443/partymgr/control/FindSecurityGroup

And its working fine for others form types.

Thanks
Ankit Jain

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch, OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984141#action_12984141 ]

Jacques Le Roux commented on OFBIZ-4119:
----------------------------------------

Sorry Ankit,

There is still an issue, at least with multi-forms. I tried with https://localhost:28443/ordermgr/control/ManageQuotePrices?quoteId=CQ10000 (I quickly created a new quote) and I get this in Firefox source

Result: 2 erreurs / 0 avertissements

line 244 column 69 - Erreur: ID "ManageQuotePrices_quoteItemSeqId_o_0" already defined
line 222 column 7 - Info: ID "ManageQuotePrices_quoteItemSeqId_o_0" first defined here

Actually it create 2 hidden fields but whithout the "h_ " before their ids, so there is a problem in this line

if (UtilValidate.isNotEmpty(modelFormField.getId()) && fieldInfo.getFieldType() != ModelFormField.FieldInfo.HIDDEN) {

I gave up at this stage, and let you handle it... I did not test with a simple form yet  since, from Jacopo comment in thread, it's mostly interesting for multi. BTW I ever you read this thread Jacopo, is there a such  need for the single form and why the hidden field is not generated for simple list, is this a normal behaviour?

> Form Widget hyperlink issue.
> ----------------------------
>
>                 Key: OFBIZ-4119
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4119
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Ankit Jain
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4119.patch, OFBIZ-4119.patch
>
>
> If we take hyperlink field in form widget then an hidden input field created by the name same as the field name, which should not be done,  and the id attribute is not set in the <a> tag.
> By adding id attribute in the <a> tag then its helpful for developers to perform action on it using js or css.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.