[jira] Created: (OFBIZ-4127) Styles for the button-bar buttons are not created
Locked
[jira] Created: (OFBIZ-4127) Styles for the button-bar buttons are not created
 
|
Styles for the button-bar buttons are not created
------------------------------------------------- Key: OFBIZ-4127 URL: https://issues.apache.org/jira/browse/OFBIZ-4127 Project: OFBiz Issue Type: Bug Components: themes Affects Versions: SVN trunk Reporter: Erwan de FERRIERES Fix For: SVN trunk Attachments: fg_button-bar.png The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES updated OFBIZ-4127: -------------------------------------- Attachment: fg_button-bar.png > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-4127: ------------------------------- Priority: Minor (was: Major) Thanks Erwan. I'm sure this issue will be resolved soon - the updated theme has generated some interest from the graphic artists in the community. > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983792#action_12983792 ] Adrian Crum commented on OFBIZ-4127: ------------------------------------ And by the way, the Layout Demo page needs a French translation. ;-) > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983816#action_12983816 ] Ryan Foster commented on OFBIZ-4127: ------------------------------------ Erwan, not sure what you are talking about here. The buttons in the button-bar look exactly the way that they are supposed to look, which is illustrated by your screenshot. They are styled to look like buttons, because that is what they are. Their style definition is located on line 1394 in maincss.css Close this task, there is no issue here. > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983828#action_12983828 ] Adrian Crum commented on OFBIZ-4127: ------------------------------------ Ryan, Erwan is referring to the style regression from the previous version of Flat Grey. The two rows of buttons should look different because they use different CSS classes. I mentioned this before when we discussed the many button styles and I pointed out the improper use of the button-bar decorators. The Layout Demo page was the result of that discussion. > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983832#action_12983832 ] Ryan Foster commented on OFBIZ-4127: ------------------------------------ Yes, and my point was that they shouldn't use different CSS classes. If we call it a button, and it acts like a button, then it should look like all of the other buttons. It's not a style regression, it's a style consolidation. Also, where is the Layout Demo page by the way? > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983848#action_12983848 ] Adrian Crum commented on OFBIZ-4127: ------------------------------------ Okay, then it's a UI regression. Rows of buttons that previously had distinct visual cues now look the same. When an application developer lays out a screen, they are going to choose different styles to indicate different things. Basically, the developer is saying the button-style-1 row of buttons have X in common and the button-style-2 row of buttons have Y in common. If all buttons look the same, then the distinction is lost and the UI suffers. You can see the difference by viewing the Layout Demo using one of the older themes, or by using the Flat Grey theme on the 9.04 demo. https://localhost:8443/webtools/control/WebtoolsLayoutDemo > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983881#action_12983881 ] Ryan Foster commented on OFBIZ-4127: ------------------------------------ Then style the 2 different button-bar elements that contain them, not the buttons themselves, to show the relationship. Buttons in row 1 have X in common and buttons in row 2 have Y in common, but one thing that they all share Z in common is that they are all BUTTONS. The UI suffers much, much more when you have a group of common elements that all act the same way, but look different. A user has a much more consistent and intuitive experience when they know that a button is a button, regardless of its relationship with other buttons. > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983889#action_12983889 ] Adrian Crum commented on OFBIZ-4127: ------------------------------------ Thanks - that makes sense. We can leave this issue open until someone comes up with container styles. > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983966#action_12983966 ] Ryan Foster commented on OFBIZ-4127: ------------------------------------ Sounds good. I'll see if I can something together over the next couple of days. I did notice that the "disabled" button styling was not getting picked in the Layout Test. The attached patch fixes that issue. > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Updated: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Foster updated OFBIZ-4127: ------------------------------- Attachment: disabledBtn.patch adds disabled styling to <a> type button elements > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: disabledBtn.patch, fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Assigned: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-4127: ---------------------------------- Assignee: Adrian Crum > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: disabledBtn.patch, fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984026#action_12984026 ] Adrian Crum commented on OFBIZ-4127: ------------------------------------ Disabled button patch applied to trunk, rev 1061124. Thanks Ryan! > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: disabledBtn.patch, fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984111#action_12984111 ] Erwan de FERRIERES commented on OFBIZ-4127: ------------------------------------------- Thanks guys, the disabled button is really nice ! > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: disabledBtn.patch, fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988464#action_12988464 ] Bruno Busco commented on OFBIZ-4127: ------------------------------------ Hi, I have posted something in the DEV ML and later I have seen this JIRA. Well, could we definitively remove these two button-styles? There is no reason IMO to let the user know that a button links to intra-app or inter-app. The only reason the user should know about it is if it is not allowed to access a different applicationbut, in this case, a disabled button should be used (or no button at all). In any case if we would keep these styles they should better be named "intra-app-button" and "inter-app-button". This means use functional names for styles. > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: disabledBtn.patch, fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988469#action_12988469 ] Jacques Le Roux commented on OFBIZ-4127: ---------------------------------------- This makes sense Bruno > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: disabledBtn.patch, fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. |
[jira] [Commented] (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139651#comment-13139651 ] Erwan de FERRIERES commented on OFBIZ-4127: ------------------------------------------- style has been corrected on the disabled buttons. No need to keep this open. > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: disabledBtn.patch, fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Closed] (OFBIZ-4127) Styles for the button-bar buttons are not created
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-4127. ------------------------------------- Resolution: Fixed > Styles for the button-bar buttons are not created > ------------------------------------------------- > > Key: OFBIZ-4127 > URL: https://issues.apache.org/jira/browse/OFBIZ-4127 > Project: OFBiz > Issue Type: Bug > Components: themes > Affects Versions: SVN trunk > Reporter: Erwan de FERRIERES > Assignee: Adrian Crum > Priority: Minor > Fix For: SVN trunk > > Attachments: disabledBtn.patch, fg_button-bar.png > > > The buttons in button-bar have no style definition. You can see it through the screenshot, or going to the layout demo page (nice idea, BTW!). > Cheers, -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |