[jira] Created: (OFBIZ-4132) Not all pdf rendering links render to a new (_blank) target_window

[Nicolas Malin (Jira)]

Not all pdf rendering links render to a new (_blank) target_window
------------------------------------------------------------------

                 Key: OFBIZ-4132
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4132
             Project: OFBiz
          Issue Type: Improvement
          Components: ALL APPLICATIONS
    Affects Versions: SVN trunk
            Reporter: Pierre Smits
            Priority: Minor
             Fix For: SVN trunk


In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985193#action_12985193 ]

Scott Gray commented on OFBIZ-4132:
-----------------------------------

This issue isn't of much use unless you point us to the actual links...

> Not all pdf rendering links render to a new (_blank) target_window
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4132
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985196#action_12985196 ]

Pierre Smits commented on OFBIZ-4132:
-------------------------------------

What were your expectations, Scot?

> Not all pdf rendering links render to a new (_blank) target_window
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4132
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985201#action_12985201 ]

BJ Freeman commented on OFBIZ-4132:
-----------------------------------

steps reproduce

> Not all pdf rendering links render to a new (_blank) target_window
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4132
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985273#action_12985273 ]

Jacques Le Roux commented on OFBIZ-4132:
----------------------------------------

I guess we have to look for where PDF files are generated and from there check that they are generated in a new window. There are 83 content-type="application/pdf" in controllers (birt and fop). I'd suggest to look for 5 each day, if Pierre, Scott BJ and I do it it will be no more than 5 days...We have just to choose where each work...

> Not all pdf rendering links render to a new (_blank) target_window
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4132
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985284#action_12985284 ]

Jacques Le Roux commented on OFBIZ-4132:
----------------------------------------

BTW, we could use the same technic to replace javascript calls by submit where it's possible. By and large if we could agree to use a such strategy on large and repetitive tasks we could be more successful. All we need is a bit of good wills and exchanges in dev ML (maybe even a page on wiki for larger enrolment). Is that really impossible?

> Not all pdf rendering links render to a new (_blank) target_window
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4132
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985353#action_12985353 ]

Pierre Smits commented on OFBIZ-4132:
-------------------------------------

I will do some analysis on the pdf issue. And will create per application a sub task. From there on we could split up the effort.

> Not all pdf rendering links render to a new (_blank) target_window
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4132
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4132.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Done!

> Not all pdf rendering links render to a new (_blank) target_window
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-4132
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4132
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL APPLICATIONS
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> In various application pdf files can be rendered. However, not all statements include a target-window="_BLANK" instruction. Without this instruction te pdf's are rendered in the browser window where the user accessing the ofbiz environment. This is an undesirable situation as it lessens the user experience

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira