[jira] Created: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item

Nicolas Malin (Jira)
Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item
------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-4134
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4134
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Leon
            Priority: Minor
             Fix For: SVN trunk


In "add order item" page, you select a product and leave other field empty, submit. Then you select same product but input some comment, after submit, you can only get one item in shopping cart item list with its order quantity increased but the comment written in second time is discard.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4134:
------------------------

    Attachment: ShoppingCartItem.patch

trivial update to "equals" method. not only for the bug mentiond ealier, but also another similar one while comparing "additionalProductFeatureAndAppls" to exist items.

> Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4134
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4134
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShoppingCartItem.patch
>
>
> In "add order item" page, you select a product and leave other field empty, submit. Then you select same product but input some comment, after submit, you can only get one item in shopping cart item list with its order quantity increased but the comment written in second time is discard.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985614#action_12985614 ]

Jacques Le Roux commented on OFBIZ-4134:
----------------------------------------

Leon,

I tried your fix, it did not work. The 3rd time I added the same item no comment shown. Maybe I missed something, were is the comment supposed to be shown?

Note to be clear: before or after applying your patch the products are shown as new lines. I guess is due to the moment the item is created, since we show it.

> Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4134
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4134
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShoppingCartItem.patch
>
>
> In "add order item" page, you select a product and leave other field empty, submit. Then you select same product but input some comment, after submit, you can only get one item in shopping cart item list with its order quantity increased but the comment written in second time is discard.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986175#action_12986175 ]

Leon commented on OFBIZ-4134:
-----------------------------

following is the steps to re-produce this issue:
1. (in order entry--additem page) choose a product, e.g. "GZ-1000", input quantity as "1", then click "submit" directly. An cart item will be shown in "Order Items" list
2. choose same product again, e.g. "GZ-1000", input quantity as "2", select a "Desired Delivery Date" and input some comments, then click "submit". This time, according to my understanding, there should be second (a new ) item in "Order items" list, but in fact there's only one.

The reason for this issue is because ShoppingCartItem.equals method return true if the attribute of either cart item or new item is empty.

> Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4134
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4134
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: ShoppingCartItem.patch
>
>
> In "add order item" page, you select a product and leave other field empty, submit. Then you select same product but input some comment, after submit, you can only get one item in shopping cart item list with its order quantity increased but the comment written in second time is discard.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-4134) Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4134.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 10.04
                   Release Branch 09.04
         Assignee: Jacques Le Roux

Thanks Leon,

I don't know what I did 1st time (I think I looked at the comment when the order was created :/), it works fine actually (and makes sense). Your patch is in trunk at r1063273, R10.04 at r1063275, R9.04 at r1063281  


> Shopping Cart Item, treat items contains same product but with or without comment as same shopping cart item
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4134
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4134
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk
>
>         Attachments: ShoppingCartItem.patch
>
>
> In "add order item" page, you select a product and leave other field empty, submit. Then you select same product but input some comment, after submit, you can only get one item in shopping cart item list with its order quantity increased but the comment written in second time is discard.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.