[jira] Created: (OFBIZ-4136) In layer mode, the attribute "target-parameter" of a lookup field is not used

[Nicolas Malin (Jira)]

In layer mode, the attribute "target-parameter" of a lookup field is not used
-----------------------------------------------------------------------------

                 Key: OFBIZ-4136
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Leon
            Priority: Minor
             Fix For: SVN trunk
         Attachments: lookup_target-parameter.patch

As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4136:
------------------------

    Attachment: lookup_target-parameter.patch

A patch to resolve this issue.

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4136:
------------------------

    Attachment:     (was: lookup_target-parameter.patch)

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4136:
------------------------

    Attachment: lookup_target-parameter.patch

previous patch has a trivial problem when handle more than one target-parameters. Update and re-attached.

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985592#action_12985592 ]

Sascha Rodekamp commented on OFBIZ-4136:
----------------------------------------

Hey Leon,

thanks for the patch i will test and review asap.

Thanks
have a good day
Sascha

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985596#action_12985596 ]

Jacques Le Roux commented on OFBIZ-4136:
----------------------------------------

It's done Sascha... ;)

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4136:
--------------------------------------

    Assignee: Jacques Le Roux

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985599#action_12985599 ]

Sascha Rodekamp commented on OFBIZ-4136:
----------------------------------------

;) you're to fast for me ... mr. lightning :)

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4136.
----------------------------------

    Resolution: Fixed

Thanks Leon,

Nice catch! Actually IIRW it's because this has been introduced in trunk after we migrated this part in the jQuery branch and it passed "hidden" when I merged the trunk in branch.

Anyway, your patch is in trunk at r1062709

Thanks Sascha for the proposed help, appreciated!

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12985602#action_12985602 ]

Jacques Le Roux commented on OFBIZ-4136:
----------------------------------------

Sascha,

Bah, it was my mistake in 1st place. I should have noticed this change in trunk and when merging check in branch, lesson learned...

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon reopened OFBIZ-4136:
-------------------------


hi, Sascha and Jacques,

It seems that you applied my previous patch (not the one current attached). The only update is line 526 of "framework/widget/templates/htmlFormMacroLibrary.ftl", in previous patch, I put "<#assign isFirst = false>" in wrong place.

Please move "<#assign isFirst = false>" from line 528 to line 526 from "htmlFormMacroLibrary.ftl". Many thanks.

Leon

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986895#action_12986895 ]

Jacques Le Roux commented on OFBIZ-4136:
----------------------------------------

Thanks Leon,

I think I know what happened, I certainly read your last patch message in my email client and forgot to update the Jira issue. Thus I downloaded the old patch (same name). Though I'm surprised Jira did not updated it. Maybe also I used the wrong file locally (did not update)

Anyway it's fixed at r1063630. I let you close the issue...

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon closed OFBIZ-4136.
-----------------------

    Resolution: Fixed

Double check the code, it's correct this time.

Thanks for your quick response. ^^

> In layer mode, the attribute "target-parameter" of a lookup field is not used
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4136
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4136
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: lookup_target-parameter.patch
>
>
> As xsd describes, "target-parameter" of a lookup field can be used to transfer extra parameters to lookup something. But if we choose "layer" mode (the default mode of lookup), this attribute does nothing. It works before jQuery introduced. I guess this feature is forgot by mistake during migration.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.