[jira] Created: (OFBIZ-4162) Checkout Shipping Options

[Nicolas Malin (Jira)]

Checkout Shipping Options
-------------------------

                 Key: OFBIZ-4162
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4162
             Project: OFBiz
          Issue Type: Bug
          Components: order, specialpurpose/ecommerce
    Affects Versions: Release Branch 10.04, SVN trunk
         Environment: Win XP
            Reporter: Stephen Rufle
            Priority: Minor


When the user selects a shipping option and moves to the next step and then comes back to the "Shipping Options" step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Rufle updated OFBIZ-4162:
---------------------------------

    Attachment: OFBIZ-4162.patch

Adds StringUtil.wrapString to the chosenShippingMethod comparison.

> Checkout Shipping Options
> -------------------------
>
>                 Key: OFBIZ-4162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4162
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: Win XP
>            Reporter: Stephen Rufle
>            Priority: Minor
>         Attachments: OFBIZ-4162.patch
>
>
> When the user selects a shipping option and moves to the next step and then comes back to the "Shipping Options" step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991200#comment-12991200 ]

Jacques Le Roux commented on OFBIZ-4162:
----------------------------------------

Hi Stephen,

This can't hurt and is, I suppose, the right solution. But I was not able to quickly reproduce your problem. Coud you give please give me the steps you used?

Thanks

> Checkout Shipping Options
> -------------------------
>
>                 Key: OFBIZ-4162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4162
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: Win XP
>            Reporter: Stephen Rufle
>            Priority: Minor
>         Attachments: OFBIZ-4162.patch
>
>
> When the user selects a shipping option and moves to the next step and then comes back to the "Shipping Options" step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991354#comment-12991354 ]

Stephen Rufle commented on OFBIZ-4162:
--------------------------------------

# Add a product to the cart
# login as any user I used "admin"
# Checkout Step "Shipping Address" (Step 1: Where shall we ship it?)
#* Click Next
# Checkout Step "Shipping Options" (Step 2: How shall we ship it?)
#* Choose "UPS Air"
#* Click Next
# Checkout Step "Payment Options" (Step 3: How shall you pay?)
#* Click "Browser" back button, in my code had a request that directed back a step, but this shows the issue
# ISSUE: Now "UPS Air" is no longer selected, after my patch it will be.

> Checkout Shipping Options
> -------------------------
>
>                 Key: OFBIZ-4162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4162
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: Win XP
>            Reporter: Stephen Rufle
>            Priority: Minor
>         Attachments: OFBIZ-4162.patch
>
>
> When the user selects a shipping option and moves to the next step and then comes back to the "Shipping Options" step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991415#comment-12991415 ]

Jacques Le Roux commented on OFBIZ-4162:
----------------------------------------

Ha this explains that, you have a modified code... Because I did not see any issues at step 5.

If nobody see a problem with this patch I will commit it.

> Checkout Shipping Options
> -------------------------
>
>                 Key: OFBIZ-4162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4162
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: Win XP
>            Reporter: Stephen Rufle
>            Priority: Minor
>         Attachments: OFBIZ-4162.patch
>
>
> When the user selects a shipping option and moves to the next step and then comes back to the "Shipping Options" step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4162.
----------------------------------

> Checkout Shipping Options
> -------------------------
>
>                 Key: OFBIZ-4162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4162
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: Win XP
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4162.patch
>
>
> When the user selects a shipping option and moves to the next step and then comes back to the "Shipping Options" step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux resolved OFBIZ-4162.
------------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Stephen,

I fixed only in trunk at r1068286, since it was not breaking OOTB

Thanks

> Checkout Shipping Options
> -------------------------
>
>                 Key: OFBIZ-4162
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4162
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, specialpurpose/ecommerce
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: Win XP
>            Reporter: Stephen Rufle
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4162.patch
>
>
> When the user selects a shipping option and moves to the next step and then comes back to the "Shipping Options" step the previously selected value is not selected on the screen. This is because in the ftl a comparison is made between shippingMethod and chosenShippingMethod. chosenShippingMethod is being escaped so the values will never match. The solution is to use wrapString on chosenShippingMethod.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira