[jira] Created: (OFBIZ-4165) Omission in the OrderService

[Nicolas Malin (Jira)]

Omission in the OrderService
----------------------------

                 Key: OFBIZ-4165
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
            Reporter: Sergei


I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.

After my code investigation, I found a bug (omission) in code, please look at the patch.


--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Attachment: screenshot.PNG.jpg

You can see the result of the "Update items" action, but without any changes, new shipping fee and sales tas appeared.

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990351#comment-12990351 ]

Sergei commented on OFBIZ-4165:
-------------------------------

        List orderAdjustments = new ArrayList();
        for (long itr = 1; itr <= groupIndex; itr++) {
            shipGroupSeqId = UtilFormatOut.formatPaddedNumber(itr, 5);
            List<GenericValue> removeList = new ArrayList<GenericValue>();
            for (GenericValue stored: (List<GenericValue>)toStore) {
                if ("OrderAdjustment".equals(stored.getEntityName())) {
                    if (("SHIPPING_CHARGES".equals(stored.get("orderAdjustmentTypeId")) ||
                            "SALES_TAX".equals(stored.get("orderAdjustmentTypeId"))) &&
                            stored.get("orderId").equals(orderId) &&
                            stored.get("shipGroupSeqId").equals(shipGroupSeqId)) {
                        // Removing objects from toStore list for old Shipping and Handling Charges Adjustment and Sales Tax Adjustment.
                        removeList.add(stored);
                    }
                    if (stored.get("comments") != null && ((String)stored.get("comments")).startsWith("Added manually by")) {
                        // Removing objects from toStore list for Manually added Adjustment.
                        removeList.add(stored);
                    }
                }
            }
            toStore.removeAll(removeList);
        }

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Comment: was deleted

(was:         List orderAdjustments = new ArrayList();
        for (long itr = 1; itr <= groupIndex; itr++) {
            shipGroupSeqId = UtilFormatOut.formatPaddedNumber(itr, 5);
            List<GenericValue> removeList = new ArrayList<GenericValue>();
            for (GenericValue stored: (List<GenericValue>)toStore) {
                if ("OrderAdjustment".equals(stored.getEntityName())) {
                    if (("SHIPPING_CHARGES".equals(stored.get("orderAdjustmentTypeId")) ||
                            "SALES_TAX".equals(stored.get("orderAdjustmentTypeId"))) &&
                            stored.get("orderId").equals(orderId) &&
                            stored.get("shipGroupSeqId").equals(shipGroupSeqId)) {
                        // Removing objects from toStore list for old Shipping and Handling Charges Adjustment and Sales Tax Adjustment.
                        removeList.add(stored);
                    }
                    if (stored.get("comments") != null && ((String)stored.get("comments")).startsWith("Added manually by")) {
                        // Removing objects from toStore list for Manually added Adjustment.
                        removeList.add(stored);
                    }
                }
            }
            toStore.removeAll(removeList);
        })

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Attachment:     (was: OFBIZ-4165_shipping_group_omission.patch)

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Attachment: OFBIZ-4165_shipping_group_omission.patch

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Attachment: OFBIZ-4165_shipping_group_omission.patch

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: OFBIZ-4165_shipping_group_omission.patch, screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Attachment:     (was: OFBIZ-4165_shipping_group_omission.patch)

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Attachment:     (was: OFBIZ-4165_shipping_group_omission.patch)

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Attachment: OFBIZ-4165_shipping_group_omission.patch

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sergei updated OFBIZ-4165:
--------------------------

    Attachment: OFBIZ-4165_shipping_group_omission.patch

Just wrong iterator.

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>         Attachments: OFBIZ-4165_shipping_group_omission.patch, screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4165.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Sergei,

I have fixed it at r1067097 in trunk, R10.04 at r1067099, R9.04 at r1067100

Note that you should follow https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices when creating patches. Yours had absolute pathes. By chance it was really easy to apply by hand

> Omission in the OrderService
> ----------------------------
>
>                 Key: OFBIZ-4165
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4165
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Sergei
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4165_shipping_group_omission.patch, screenshot.PNG.jpg
>
>
> I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.
> After my code investigation, I found a bug (omission) in code, please look at the patch.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira