[jira] Created: (OFBIZ-4176) savePaymentGatewayResponse throws exceptions due to foreign key constraints

[Nicolas Malin (Jira)]

savePaymentGatewayResponse throws exceptions due to foreign key constraints
---------------------------------------------------------------------------

                 Key: OFBIZ-4176
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4176
             Project: OFBiz
          Issue Type: Bug
          Components: accounting
    Affects Versions: SVN trunk
            Reporter: Martin Kreidenweis


If you use a CC payment service provider that actually wants to save not only PaymentGatewayResponses, but also PaymentGatewayResponseMessages, saving these to the database actually might fail because they are created in the wrong order. The response and the messages are scheduled as separate async rollback services in processCreditResult. So it's not guaranteed the Response is there before OFBiz tries to add the ResponseMessages.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Kreidenweis updated OFBIZ-4176:
--------------------------------------

    Attachment: OFBIZ-4176.patch

Fix for the issue: we created a new savePaymentGatewayResponseAndMessages service, that takes both the Response and the ResponseMessages and writes them to the database in the right order.

> savePaymentGatewayResponse throws exceptions due to foreign key constraints
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-4176
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4176
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>         Attachments: OFBIZ-4176.patch
>
>
> If you use a CC payment service provider that actually wants to save not only PaymentGatewayResponses, but also PaymentGatewayResponseMessages, saving these to the database actually might fail because they are created in the wrong order. The response and the messages are scheduled as separate async rollback services in processCreditResult. So it's not guaranteed the Response is there before OFBiz tries to add the ResponseMessages.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4176.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 10.04
         Assignee: Jacques Le Roux

Thanks Martin,

Your patch is in trunk at r1070193, R10.04 at r1070196

> savePaymentGatewayResponse throws exceptions due to foreign key constraints
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-4176
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4176
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4176.patch
>
>
> If you use a CC payment service provider that actually wants to save not only PaymentGatewayResponses, but also PaymentGatewayResponseMessages, saving these to the database actually might fail because they are created in the wrong order. The response and the messages are scheduled as separate async rollback services in processCreditResult. So it's not guaranteed the Response is there before OFBiz tries to add the ResponseMessages.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994091#comment-12994091 ]

Jacques Le Roux commented on OFBIZ-4176:
----------------------------------------

Forgot a file, committed at r1070229 intrunk and r1070231 in R10.04

> savePaymentGatewayResponse throws exceptions due to foreign key constraints
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-4176
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4176
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Martin Kreidenweis
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4176.patch
>
>
> If you use a CC payment service provider that actually wants to save not only PaymentGatewayResponses, but also PaymentGatewayResponseMessages, saving these to the database actually might fail because they are created in the wrong order. The response and the messages are scheduled as separate async rollback services in processCreditResult. So it's not guaranteed the Response is there before OFBiz tries to add the ResponseMessages.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira