[jira] Created: (OFBIZ-4188) Incompatible change of macro renderDateTimeField in r1070570

[Nicolas Malin (Jira)]

Incompatible change of macro renderDateTimeField in r1070570
------------------------------------------------------------

                 Key: OFBIZ-4188
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4188
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Manuela Gruendlinger


In r1070570 two new parameters "step" and "timeValues" have been introduced without default values. This breaks all invocations. Using step="1" and timeValues="" as default values works in local tests.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES reassigned OFBIZ-4188:
-----------------------------------------

    Assignee: Erwan de FERRIERES

> Incompatible change of macro renderDateTimeField in r1070570
> ------------------------------------------------------------
>
>                 Key: OFBIZ-4188
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4188
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Manuela Gruendlinger
>            Assignee: Erwan de FERRIERES
>
> In r1070570 two new parameters "step" and "timeValues" have been introduced without default values. This breaks all invocations. Using step="1" and timeValues="" as default values works in local tests.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996324#comment-12996324 ]

Sascha Rodekamp commented on OFBIZ-4188:
----------------------------------------

Hi Manuela,
i had a qucik look in the MacroFormRenderer. Line 486 set the step default to 1.
I also can't reproduce your error. Can you give me a little bit more information please. :-)

Thanks
Sascha

> Incompatible change of macro renderDateTimeField in r1070570
> ------------------------------------------------------------
>
>                 Key: OFBIZ-4188
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4188
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Manuela Gruendlinger
>            Assignee: Erwan de FERRIERES
>
> In r1070570 two new parameters "step" and "timeValues" have been introduced without default values. This breaks all invocations. Using step="1" and timeValues="" as default values works in local tests.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996346#comment-12996346 ]

Raj Saini commented on OFBIZ-4188:
----------------------------------

From seems to be in the "renderDateTimeField" Macro. Macro parameters timeValues  have no default values and they are not passed form many ftls. The solution is either we pass the value from the calling FTL or default assign value to this. Passing a default value to the macro definition solves the problem.

> Incompatible change of macro renderDateTimeField in r1070570
> ------------------------------------------------------------
>
>                 Key: OFBIZ-4188
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4188
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Manuela Gruendlinger
>            Assignee: Erwan de FERRIERES
>
> In r1070570 two new parameters "step" and "timeValues" have been introduced without default values. This breaks all invocations. Using step="1" and timeValues="" as default values works in local tests.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996350#comment-12996350 ]

Sascha Rodekamp commented on OFBIZ-4188:
----------------------------------------

From my point of view, it's better to modify the FTL Scripts where the renderDateTimeField is called. Because we never set default values in the FTL Macro (i've never seen before).
Default values will always be set in the Macro Renderer java classes.

To let the user now which fields are mandatory, i would suggest to create a short (in code) documentation for the macros?!

> Incompatible change of macro renderDateTimeField in r1070570
> ------------------------------------------------------------
>
>                 Key: OFBIZ-4188
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4188
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Manuela Gruendlinger
>            Assignee: Erwan de FERRIERES
>
> In r1070570 two new parameters "step" and "timeValues" have been introduced without default values. This breaks all invocations. Using step="1" and timeValues="" as default values works in local tests.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996355#comment-12996355 ]

Raj Saini commented on OFBIZ-4188:
----------------------------------

Well not true. There are two already set for renderDateTimeField and they are event="" and  action="". These are the last two parameters. However, I agree with you that FTLs should be modified to pass the default values.

> Incompatible change of macro renderDateTimeField in r1070570
> ------------------------------------------------------------
>
>                 Key: OFBIZ-4188
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4188
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Manuela Gruendlinger
>            Assignee: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>
> In r1070570 two new parameters "step" and "timeValues" have been introduced without default values. This breaks all invocations. Using step="1" and timeValues="" as default values works in local tests.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erwan de FERRIERES closed OFBIZ-4188.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Done at r1071967

> Incompatible change of macro renderDateTimeField in r1070570
> ------------------------------------------------------------
>
>                 Key: OFBIZ-4188
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4188
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Manuela Gruendlinger
>            Assignee: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>
> In r1070570 two new parameters "step" and "timeValues" have been introduced without default values. This breaks all invocations. Using step="1" and timeValues="" as default values works in local tests.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996357#comment-12996357 ]

Sascha Rodekamp commented on OFBIZ-4188:
----------------------------------------

Ah yes i see, not scrolled to the right :-D

> Incompatible change of macro renderDateTimeField in r1070570
> ------------------------------------------------------------
>
>                 Key: OFBIZ-4188
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4188
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Manuela Gruendlinger
>            Assignee: Erwan de FERRIERES
>             Fix For: SVN trunk
>
>
> In r1070570 two new parameters "step" and "timeValues" have been introduced without default values. This breaks all invocations. Using step="1" and timeValues="" as default values works in local tests.

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira