OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-4201) DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 4 messages Options
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Created: (OFBIZ-4201) DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance

Nicolas Malin (Jira)
DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance
------------------------------------------------------------------------------------------

                 Key: OFBIZ-4201
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4201
             Project: OFBiz
          Issue Type: Improvement
          Components: framework
    Affects Versions: Release Branch 10.04
            Reporter: Xiaoming Shi


In the files:

./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilDateTime.java line:702
./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilFormatOut.java line:314

DateFormat.getDateTimeInstance() is called for every function call of "toGmtTimestampString" or "formatDate". We can cache the value by adding a static class field and improve performance.

This is similar to the Apache Bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778




--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Updated: (OFBIZ-4201) DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Xiaoming Shi updated OFBIZ-4201:
--------------------------------

    Description:
In the files:

./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilDateTime.java line:702
./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilFormatOut.java line:314
./apache-ofbiz-10.04/framework/webapp/src/org/ofbiz/webapp/taglib/FormatTag.java   line: 78

DateFormat.getDateTimeInstance() is called for every function call of "toGmtTimestampString" or "formatDate". We can cache the value by adding a static class field and improve performance.

This is similar to the Apache Bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778




  was:
In the files:

./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilDateTime.java line:702
./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilFormatOut.java line:314

DateFormat.getDateTimeInstance() is called for every function call of "toGmtTimestampString" or "formatDate". We can cache the value by adding a static class field and improve performance.

This is similar to the Apache Bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778





> DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4201
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4201
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Xiaoming Shi
>
> In the files:
> ./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilDateTime.java line:702
> ./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilFormatOut.java line:314
> ./apache-ofbiz-10.04/framework/webapp/src/org/ofbiz/webapp/taglib/FormatTag.java   line: 78
> DateFormat.getDateTimeInstance() is called for every function call of "toGmtTimestampString" or "formatDate". We can cache the value by adding a static class field and improve performance.
> This is similar to the Apache Bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778

--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] [Closed] (OFBIZ-4201) DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4201.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
         Assignee: Jacques Le Roux

Thanks for report Shi,

It's done in trunk at r1165076

> DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4201
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4201
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Xiaoming Shi
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>
> In the files:
> ./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilDateTime.java line:702
> ./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilFormatOut.java line:314
> ./apache-ofbiz-10.04/framework/webapp/src/org/ofbiz/webapp/taglib/FormatTag.java   line: 78
> DateFormat.getDateTimeInstance() is called for every function call of "toGmtTimestampString" or "formatDate". We can cache the value by adding a static class field and improve performance.
> This is similar to the Apache Bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] [Reopened] (OFBIZ-4201) DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-4201:
------------------------------------


We will certainly use http://commons.apache.org/lang/api-2.5/org/apache/commons/lang/time/FastDateFormat.html rather

> DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance
> ------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4201
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4201
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Release Branch 10.04
>            Reporter: Xiaoming Shi
>            Assignee: Jacques Le Roux
>             Fix For: SVN trunk
>
>
> In the files:
> ./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilDateTime.java line:702
> ./apache-ofbiz-10.04/framework/base/src/org/ofbiz/base/util/UtilFormatOut.java line:314
> ./apache-ofbiz-10.04/framework/webapp/src/org/ofbiz/webapp/taglib/FormatTag.java   line: 78
> DateFormat.getDateTimeInstance() is called for every function call of "toGmtTimestampString" or "formatDate". We can cache the value by adding a static class field and improve performance.
> This is similar to the Apache Bug https://issues.apache.org/bugzilla/show_bug.cgi?id=48778

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Free forum by Nabble Edit this page