OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-4210) findProductById is not available

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 6 messages Options
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Created: (OFBIZ-4210) findProductById is not available

Nicolas Malin (Jira)
findProductById is not available
--------------------------------

                 Key: OFBIZ-4210
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4210
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
         Environment: Linux
            Reporter: Mansour Al Akeel
             Fix For: SVN trunk


The function "findProductById" is not available. The issue is in the services.xml for the product component.
Currently it has:

- <service name="findProductsById" engine="java"  auth="true"
-            location="org.ofbiz.product.ProductServices" invoke="findProductByGoodIdentification">
-        <description>Find the productId corresponding to a reference and a reference type</description>
-        <attribute type="String" mode="IN" name="idToFind" optional="false"/>
-        <attribute type="String" mode="IN" name="goodIdentificationTypeId" optional="true"/>
-        <attribute type="String" mode="IN" name="searchProductFirst" optional="true"/>
-        <attribute type="String" mode="IN" name="searchAllId" optional="true"/>
-        <attribute type="org.ofbiz.entity.GenericValue" mode="OUT" name="product" optional="true"/>
-        <attribute type="List" mode="OUT" name="productsFound" optional="true"/>
-    </service>

The service name should be "findProductById", without "s".
The invoke should be "findProductById" instead of "findProductByGoodIdentification"
The Location should be location="org.ofbiz.product.product.ProductServices"
Finally the return type of the service should have "productsList" and not "productsFound".


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Commented: (OFBIZ-4210) findProductById is not available

Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003479#comment-13003479 ]

Jacques Le Roux commented on OFBIZ-4210:
----------------------------------------

Why not a patch?

> findProductById is not available
> --------------------------------
>
>                 Key: OFBIZ-4210
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4210
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux
>            Reporter: Mansour Al Akeel
>             Fix For: SVN trunk
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The function "findProductById" is not available. The issue is in the services.xml for the product component.
> Currently it has:
> - <service name="findProductsById" engine="java"  auth="true"
> -            location="org.ofbiz.product.ProductServices" invoke="findProductByGoodIdentification">
> -        <description>Find the productId corresponding to a reference and a reference type</description>
> -        <attribute type="String" mode="IN" name="idToFind" optional="false"/>
> -        <attribute type="String" mode="IN" name="goodIdentificationTypeId" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchProductFirst" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchAllId" optional="true"/>
> -        <attribute type="org.ofbiz.entity.GenericValue" mode="OUT" name="product" optional="true"/>
> -        <attribute type="List" mode="OUT" name="productsFound" optional="true"/>
> -    </service>
> The service name should be "findProductById", without "s".
> The invoke should be "findProductById" instead of "findProductByGoodIdentification"
> The Location should be location="org.ofbiz.product.product.ProductServices"
> Finally the return type of the service should have "productsList" and not "productsFound".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Updated: (OFBIZ-4210) findProductById is not available

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mansour Al Akeel updated OFBIZ-4210:
------------------------------------

    Attachment: fix_findProductById_service.patch

> findProductById is not available
> --------------------------------
>
>                 Key: OFBIZ-4210
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4210
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux
>            Reporter: Mansour Al Akeel
>             Fix For: SVN trunk
>
>         Attachments: fix_findProductById_service.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The function "findProductById" is not available. The issue is in the services.xml for the product component.
> Currently it has:
> - <service name="findProductsById" engine="java"  auth="true"
> -            location="org.ofbiz.product.ProductServices" invoke="findProductByGoodIdentification">
> -        <description>Find the productId corresponding to a reference and a reference type</description>
> -        <attribute type="String" mode="IN" name="idToFind" optional="false"/>
> -        <attribute type="String" mode="IN" name="goodIdentificationTypeId" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchProductFirst" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchAllId" optional="true"/>
> -        <attribute type="org.ofbiz.entity.GenericValue" mode="OUT" name="product" optional="true"/>
> -        <attribute type="List" mode="OUT" name="productsFound" optional="true"/>
> -    </service>
> The service name should be "findProductById", without "s".
> The invoke should be "findProductById" instead of "findProductByGoodIdentification"
> The Location should be location="org.ofbiz.product.product.ProductServices"
> Finally the return type of the service should have "productsList" and not "productsFound".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Commented: (OFBIZ-4210) findProductById is not available

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004079#comment-13004079 ]

Mansour Al Akeel commented on OFBIZ-4210:
-----------------------------------------

-I use git, and the diff generated normally can not be applied through svn.
-I contributed code, that didn't make it to the truck, may be formatting issue.

In all cases here's a patch, and I hope it's ok.

> findProductById is not available
> --------------------------------
>
>                 Key: OFBIZ-4210
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4210
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux
>            Reporter: Mansour Al Akeel
>             Fix For: SVN trunk
>
>         Attachments: fix_findProductById_service.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The function "findProductById" is not available. The issue is in the services.xml for the product component.
> Currently it has:
> - <service name="findProductsById" engine="java"  auth="true"
> -            location="org.ofbiz.product.ProductServices" invoke="findProductByGoodIdentification">
> -        <description>Find the productId corresponding to a reference and a reference type</description>
> -        <attribute type="String" mode="IN" name="idToFind" optional="false"/>
> -        <attribute type="String" mode="IN" name="goodIdentificationTypeId" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchProductFirst" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchAllId" optional="true"/>
> -        <attribute type="org.ofbiz.entity.GenericValue" mode="OUT" name="product" optional="true"/>
> -        <attribute type="List" mode="OUT" name="productsFound" optional="true"/>
> -    </service>
> The service name should be "findProductById", without "s".
> The invoke should be "findProductById" instead of "findProductByGoodIdentification"
> The Location should be location="org.ofbiz.product.product.ProductServices"
> Finally the return type of the service should have "productsList" and not "productsFound".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Commented: (OFBIZ-4210) findProductById is not available

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004137#comment-13004137 ]

Jacques Le Roux commented on OFBIZ-4210:
----------------------------------------

Thanks for the effort Mansour, I will have a look...

> findProductById is not available
> --------------------------------
>
>                 Key: OFBIZ-4210
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4210
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux
>            Reporter: Mansour Al Akeel
>             Fix For: SVN trunk
>
>         Attachments: fix_findProductById_service.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The function "findProductById" is not available. The issue is in the services.xml for the product component.
> Currently it has:
> - <service name="findProductsById" engine="java"  auth="true"
> -            location="org.ofbiz.product.ProductServices" invoke="findProductByGoodIdentification">
> -        <description>Find the productId corresponding to a reference and a reference type</description>
> -        <attribute type="String" mode="IN" name="idToFind" optional="false"/>
> -        <attribute type="String" mode="IN" name="goodIdentificationTypeId" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchProductFirst" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchAllId" optional="true"/>
> -        <attribute type="org.ofbiz.entity.GenericValue" mode="OUT" name="product" optional="true"/>
> -        <attribute type="List" mode="OUT" name="productsFound" optional="true"/>
> -    </service>
> The service name should be "findProductById", without "s".
> The invoke should be "findProductById" instead of "findProductByGoodIdentification"
> The Location should be location="org.ofbiz.product.product.ProductServices"
> Finally the return type of the service should have "productsList" and not "productsFound".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Nicolas Malin (Jira)
Reply | Threaded
Open this post in threaded view
♦
♦
|

[jira] Closed: (OFBIZ-4210) findProductById is not available

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4210.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 10.04
                   Release Branch 09.04
         Assignee: Jacques Le Roux

Thanks Mansour,

Fixed at r1080959 in trunk, R10.04 at r1080961, R9.04 at r 1080962

> findProductById is not available
> --------------------------------
>
>                 Key: OFBIZ-4210
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4210
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>         Environment: Linux
>            Reporter: Mansour Al Akeel
>            Assignee: Jacques Le Roux
>             Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk
>
>         Attachments: fix_findProductById_service.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The function "findProductById" is not available. The issue is in the services.xml for the product component.
> Currently it has:
> - <service name="findProductsById" engine="java"  auth="true"
> -            location="org.ofbiz.product.ProductServices" invoke="findProductByGoodIdentification">
> -        <description>Find the productId corresponding to a reference and a reference type</description>
> -        <attribute type="String" mode="IN" name="idToFind" optional="false"/>
> -        <attribute type="String" mode="IN" name="goodIdentificationTypeId" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchProductFirst" optional="true"/>
> -        <attribute type="String" mode="IN" name="searchAllId" optional="true"/>
> -        <attribute type="org.ofbiz.entity.GenericValue" mode="OUT" name="product" optional="true"/>
> -        <attribute type="List" mode="OUT" name="productsFound" optional="true"/>
> -    </service>
> The service name should be "findProductById", without "s".
> The invoke should be "findProductById" instead of "findProductByGoodIdentification"
> The Location should be location="org.ofbiz.product.product.ProductServices"
> Finally the return type of the service should have "productsList" and not "productsFound".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Free forum by Nabble Edit this page