OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

10 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

Old image file name format causes an error scaling updated an original image
----------------------------------------------------------------------------

Key: OFBIZ-4212
URL: https://issues.apache.org/jira/browse/OFBIZ-4212
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: SVN trunk
Environment: trunk 1080218
Reporter: Eric de Maulde
Priority: Blocker
Fix For: SVN trunk

To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194

image.filename.format=${location}/${type}/${id}
image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

[ https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4212:
----------------------------------

Attachment: ScaleImage.patch

This patch corrects error with the old configuration for FilenameToUse from catalog.properties, order by type/viewtype and not by productId

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Blocker
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker updated OFBIZ-4212:
-------------------------------

Priority: Minor (was: Blocker)

please provide more info. I hope you undestand that the resizing of imagemanagement and related functions only work on the new structure.....

On the other hand if you have a patch to solve this problem it is much appreciated!

Regards,
Hans

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006036#comment-13006036 ]

Hans Bakker edited comment on OFBIZ-4212 at 3/12/11 11:45 AM:
--------------------------------------------------------------

...

was (Author: hansbak):
please provide more info. I hope you undestand that the resizing of imagemanagement and related functions only work on the new structure.....

On the other hand if you have a patch to solve this problem it is much appreciated!

Regards,
Hans

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Issue Comment Edited: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

In reply to this post by Nicolas Malin (Jira)

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-4212.
------------------------------

Resolution: Won't Fix

perhaps usefull to other users, however not supported in the trunk.

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Reopened: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde reopened OFBIZ-4212:
-----------------------------------

In the OFBiz contributor best practice https://cwiki.apache.org/OFBADMIN/ofbiz-contributors-best-practices.html

It's written : "Rule #1 for a committer is the same as for a doctor: first do no harm. Nothing should be committed that breaks existing functionality without replacing it either before or in the same commit. Whatever you are working with someone developed it and chances are someone is using it, and possibly MANY people."

And I believe my patch is more flexible to build a path to save an image filename.

What is your goal to prohibit the old image filename format order by type/viewtype ?

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006154#comment-13006154 ]

Hans Bakker commented on OFBIZ-4212:
------------------------------------

I still think the new image directory layout will be the default layout because all demo data is based on it.

What we could do however, to accommodate your request, is that the old layout can be supported too in the system if we use the ofbiz/trunk/applications/product/config/catalog.properties everywhere.

If this is so important to you and Rohit, I am sure you can help here?

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric de Maulde updated OFBIZ-4212:
----------------------------------

Attachment: ScaleImage.patch

Here is a new patch to scale main image product content and additional image product content, works with both image filename format (catalog.properties) to upload an image.

Old image file system :

image.filename.format=${location}/${type}/${id}
image.filename.additionalviewsize.format=${location}/${id}/${viewtype}/${sizetype}

New image file system

image.filename.format=${location}/${id}/${type}
image.filename.additionalviewsize.format=${location}/${id}/${viewtype}/${sizetype}

I always have an error when I upgrade an additional image.

Right url is now only into the DataResource entity !!!

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch, ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-4212) Old image file name format causes an error scaling updated an original image

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hans Bakker closed OFBIZ-4212.
------------------------------

Resolution: Fixed

Your latest patch is in revision 1081272.

Thank you for the contribution and sorry for my misunderstanding of this patch.

Regards,
Hans

> Old image file name format causes an error scaling updated an original image
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-4212
> URL: https://issues.apache.org/jira/browse/OFBIZ-4212
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: trunk 1080218
> Reporter: Eric de Maulde
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: ScaleImage.patch, ScaleImage.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> To scale image into Product Content with the old catalog.properties configuration, "FilenameToUse" is wrong with the new issue about Image Management https://issues.apache.org/jira/browse/OFBIZ-4194
> image.filename.format=${location}/${type}/${id}
> image.filename.additionalviewsize.format=${location}/${viewtype}/${sizetype}/${id}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira