Add famfamfam icons has generic and add possibility to surchage
--------------------------------------------------------------- Key: OFBIZ-4259 URL: https://issues.apache.org/jira/browse/OFBIZ-4259 Project: OFBiz Issue Type: Improvement Components: framework, themes Affects Versions: SVN trunk Reporter: Nicolas Malin Priority: Minor Fix For: SVN trunk I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4259: --------------------------------- Attachment: Icons.jpg OFBIZ-4259.patch famfamfam.zip > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, famfamfam.zip > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023122#comment-13023122 ] Jacques Le Roux commented on OFBIZ-4259: ---------------------------------------- Hi Nicolas, OK, we still need to * Put info from [FAMFAMFAM.license.txt|http://www.corda.ac/MOVE0904/img/famfamfam/FAMFAMFAM.license.txt ] in NOTICE file and put a mention about [CREATIVE COMMONS|http://creativecommons.org/licenses/by/2.5/legalcode ] in LICENSE, [see why here|http://www.apache.org/legal/resolved.html#cc-sa] * I suggest to put the famfamfam icons in a famfamfam folder under images Could you please take care of that? Icons.jpg looks great :) Small change big effect TIA > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, famfamfam.zip > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4259: --------------------------------- Attachment: OFBIZ-4259.patch Licence and Notice done :) Jacques if you want put image in images/icons/famfamfam directory, I change defautl icons location on globalDecorator. Nicolas > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13023149#comment-13023149 ] Jacques Le Roux commented on OFBIZ-4259: ---------------------------------------- Nicolas, Yes I think it's better to isolate them. Also did you see Erwan's message in dev ML? > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4259. ---------------------------------- Resolution: Fixed Assignee: Jacques Le Roux Thanks Nicolas, Your (slightly modified) patch is in trunk at r1095984 I have just added a &nbps; before the text in menus. After Erwan's remark I wondered If I should remove the CSS on buttons. But I finally found that it was complementary. Because when no image is used on a specific button you still have the default CSS style applied (typical for Add buttons as Erwan outlined). And when no default CSS style is applied you can have an image like now shown OTTB on print button when editing an Example. So I see these 2 features as complementary for now. Maybe one day, one will replace the other, but at this stage both are welcome IMO. BTW the famfamfam (strange name ;o) icons lib is well done and really full of possibilities... > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
Thanks a lot Jacques for your review :)
I will propose in few days some improvement on application menu. Nicolas Le 22/04/2011 20:55, Jacques Le Roux (JIRA) a écrit : > [ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] > > Jacques Le Roux closed OFBIZ-4259. > ---------------------------------- > > Resolution: Fixed > Assignee: Jacques Le Roux > > Thanks Nicolas, > > Your (slightly modified) patch is in trunk at r1095984 > > > I have just added a&nbps; before the text in menus. > > After Erwan's remark I wondered If I should remove the CSS on buttons. But I finally found that it was complementary. Because when no image is used on a specific button you still have the default CSS style applied (typical for Add buttons as Erwan outlined). And when no default CSS style is applied you can have an image like now shown OTTB on print button when editing an Example. So I see these 2 features as complementary for now. Maybe one day, one will replace the other, but at this stage both are welcome IMO. > > BTW the famfamfam (strange name ;o) icons lib is well done and really full of possibilities... > >> Add famfamfam icons has generic and add possibility to surchage >> --------------------------------------------------------------- >> >> Key: OFBIZ-4259 >> URL: https://issues.apache.org/jira/browse/OFBIZ-4259 >> Project: OFBiz >> Issue Type: Improvement >> Components: framework, themes >> Affects Versions: SVN trunk >> Reporter: Nicolas Malin >> Assignee: Jacques Le Roux >> Priority: Minor >> Labels: icons, images >> Fix For: SVN trunk >> >> Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip >> >> Original Estimate: 0.5h >> Remaining Estimate: 0.5h >> >> I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. >> If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use >> I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. >> To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) > -- > This message is automatically generated by JIRA. > For more information on JIRA, see: http://www.atlassian.com/software/jira -- Nicolas MALIN Consultant Tél : 06.17.66.40.06 Site projet : http://www.neogia.org/ ------- Société LibrenBerry Tél : 02.48.02.56.12 Site : http://www.librenberry.net/ |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-4259: ------------------------------------ Reopened because it should follow https://cwiki.apache.org/OFBADMIN/html-and-css-best-practices.html > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024744#comment-13024744 ] Nicolas Malin commented on OFBIZ-4259: -------------------------------------- Jacques, First quick step, I remove img on menu, I submit asap a patch. Second step, I begin a reflexion to improve my enchancement ;) Nicolas -- MALIN Nicolas Trésorier de l'association Néogia Tél : 06.17.66.40.06 http://www.neogia.org/ > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024744#comment-13024744 ] Nicolas Malin edited comment on OFBIZ-4259 at 4/25/11 8:43 AM: --------------------------------------------------------------- Jacques, First quick step, I remove img on menu, I submit asap a patch. Second step, I begin a reflexion to improve my enchancement ;) Nicolas was (Author: soledad): Jacques, First quick step, I remove img on menu, I submit asap a patch. Second step, I begin a reflexion to improve my enchancement ;) Nicolas -- MALIN Nicolas Trésorier de l'association Néogia Tél : 06.17.66.40.06 http://www.neogia.org/ > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4259: --------------------------------- Attachment: remove-img-OFBIZ-4259.patch > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip, remove-img-OFBIZ-4259.patch > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024774#comment-13024774 ] Jacques Le Roux commented on OFBIZ-4259: ---------------------------------------- Thanks Nicolas, Committed in trunk at r1096457. Here is a quote of your proposition in dev ML: {quote} Icons is at once of the most visual but also a help user. We could associated directly to a themes but the reality is more complex. If I take the GTK project, every user can define if he wants icons, icons and text or only text independently of the themes. On issue OFBIZ-4259 I do an error to use icons through img because although they are images, they are a more complex management. I'm not for their exploitation only through css or style because although they results from it. We limit their display rendering on one technology et style don't allow user preference managment. I propose to continue icons integration, add a new element in screen renderer that indicates what icons use on menu and form field. Thence following the user preference and then the themes we display icons or not. Whether rendering css by then or treatment with an image, it will be template renderer are made their work. Nicolas {quote} > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip, remove-img-OFBIZ-4259.patch > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027444#comment-13027444 ] Jacques Le Roux commented on OFBIZ-4259: ---------------------------------------- Hi Nicolas, It's maybe too early, but don't we need to clean much things if we go the CSS way? > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259.patch, OFBIZ-4259.patch, famfamfam.zip, remove-img-OFBIZ-4259.patch > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4259: --------------------------------- Attachment: OFBIZ-4259-POC.patch PurposePOC.png To continue on the icons subject, I created a little POC on form field with purpose. The idea, if a field have a purpose, the ModelFormField take given attribute if present on definition form or try to found information on site properties (widget-field-purposes.properties). This method give the possibility for a button submit, a link or other field to set many generic information : title, style (for icons or other ;) ) and different attributes that list not actualy fixed. > Add famfamfam icons has generic and add possibility to surchage > --------------------------------------------------------------- > > Key: OFBIZ-4259 > URL: https://issues.apache.org/jira/browse/OFBIZ-4259 > Project: OFBiz > Issue Type: Improvement > Components: framework, themes > Affects Versions: SVN trunk > Reporter: Nicolas Malin > Assignee: Jacques Le Roux > Priority: Minor > Labels: icons, images > Fix For: SVN trunk > > Attachments: Icons.jpg, OFBIZ-4259-POC.patch, OFBIZ-4259.patch, OFBIZ-4259.patch, PurposePOC.png, famfamfam.zip, remove-img-OFBIZ-4259.patch > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I add possibility to use famfamfam icons contains in framework/images/webapp/images/icons. > If you want use specific icon, it's possible to define a attribute VT_ICONS_LOC that contains the way to themes icons directory to use > I improve form renderer to passe a flexible string on image-location attribute and screen and form renderer to display an image with a text. > To try it, deploy famfamfam.zip on framework/images/webapp/images directory, apply the patch and go to exemple component (see screenshot ;) ) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |