OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4266) productStore is empty for Purcahse Order

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

15 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4266) productStore is empty for Purcahse Order

productStore is empty for Purcahse Order
----------------------------------------

Key: OFBIZ-4266
URL: https://issues.apache.org/jira/browse/OFBIZ-4266
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Reporter: Gaudin Pierre

The field orderHeader.productStoreId is empty for purchase order.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4266) productStore is empty for Purcahse Order

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025757#comment-13025757 ]

Gaudin Pierre commented on OFBIZ-4266:
--------------------------------------

Gaudin Pierre added a comment - 27/Apr/11 08:59

There is an issue on Purchase order because when you try do add a quantity more than one because cart.getProductStoreId() return a null value...

Is that normal that cart.getProductStoreId() is null for PO ?

Thanks

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 08:59 There is an issue on Purchase order because when you try do add a quantity more than one because cart.getProductStoreId() return a null value... Is that normal that cart.getProductStoreId() is null for PO ? Thanks Pierre
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 09:49

Hi Pierre,

Did you test the same with R10.04 or even R9.04 demo ? (to see if it's not a regression)
Show
Jacques Le Roux added a comment - 27/Apr/11 09:49 Hi Pierre, Did you test the same with R10.04 or even R9.04 demo ? (to see if it's not a regression)
Hide
Permalink Edit Delete
Gaudin Pierre added a comment - 27/Apr/11 10:02

No I didn't try but i will.

But can we imagine an order without productStore ?? i don't think so.

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 10:02 No I didn't try but i will. But can we imagine an order without productStore ?? i don't think so. Pierre
Hide
Permalink Edit Delete
Gaudin Pierre added a comment - 27/Apr/11 10:18

OK i just try to create PO on demo Trunck and demo 9.04

OrderHeader.productStoreId is empty on Trunck
OrderHeader.productStoreId is NOT empty on 9.04

So i will create a new JIRA on this regression and close this one if you agree with me.

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 10:18 OK i just try to create PO on demo Trunck and demo 9.04 OrderHeader.productStoreId is empty on Trunck OrderHeader.productStoreId is NOT empty on 9.04 So i will create a new JIRA on this regression and close this one if you agree with me. Pierre
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 10:24

This has been recently discussed on user ML. In Opentaps they created a dummy Product Store for that, but I tend to agree with Paul...
Show
Jacques Le Roux added a comment - 27/Apr/11 10:24 This has been recently discussed on user ML. In Opentaps they created a dummy Product Store for that, but I tend to agree with Paul...
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 11:00

Pierre,

Interesting, our comments crossed on wire. So it was working in R9.04, yes we need to investigate at least. I agree a Jira for that is welcome...

> productStore is empty for Purcahse Order
> ----------------------------------------
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Issue Comment Edited] (OFBIZ-4266) productStore is empty for Purcahse Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025757#comment-13025757 ]

Gaudin Pierre edited comment on OFBIZ-4266 at 4/27/11 12:13 PM:
----------------------------------------------------------------

Previous comment :

=> Gaudin Pierre added a comment - 27/Apr/11 08:59

There is an issue on Purchase order because when you try do add a quantity more than one because cart.getProductStoreId() return a null value...

Is that normal that cart.getProductStoreId() is null for PO ?

Thanks

Pierre
Show

=> Jacques Le Roux added a comment - 27/Apr/11 09:49

Hi Pierre,

Did you test the same with R10.04 or even R9.04 demo ? (to see if it's not a regression)
Show

=> Gaudin Pierre added a comment - 27/Apr/11 10:02

No I didn't try but i will.

But can we imagine an order without productStore ?? i don't think so.

Pierre

=> Gaudin Pierre added a comment - 27/Apr/11 10:18

OK i just try to create PO on demo Trunck and demo 9.04

OrderHeader.productStoreId is empty on Trunck
OrderHeader.productStoreId is NOT empty on 9.04

So i will create a new JIRA on this regression and close this one if you agree with me.

Pierre

=> Jacques Le Roux added a comment - 27/Apr/11 10:24

This has been recently discussed on user ML. In Opentaps they created a dummy Product Store for that, but I tend to agree with Paul...
Show

=> Jacques Le Roux added a comment - 27/Apr/11 11:00

Pierre,

Interesting, our comments crossed on wire. So it was working in R9.04, yes we need to investigate at least. I agree a Jira for that is welcome...

was (Author: gpierre):
Gaudin Pierre added a comment - 27/Apr/11 08:59

There is an issue on Purchase order because when you try do add a quantity more than one because cart.getProductStoreId() return a null value...

Is that normal that cart.getProductStoreId() is null for PO ?

Thanks

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 08:59 There is an issue on Purchase order because when you try do add a quantity more than one because cart.getProductStoreId() return a null value... Is that normal that cart.getProductStoreId() is null for PO ? Thanks Pierre
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 09:49

Hi Pierre,

Did you test the same with R10.04 or even R9.04 demo ? (to see if it's not a regression)
Show
Jacques Le Roux added a comment - 27/Apr/11 09:49 Hi Pierre, Did you test the same with R10.04 or even R9.04 demo ? (to see if it's not a regression)
Hide
Permalink Edit Delete
Gaudin Pierre added a comment - 27/Apr/11 10:02

No I didn't try but i will.

But can we imagine an order without productStore ?? i don't think so.

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 10:02 No I didn't try but i will. But can we imagine an order without productStore ?? i don't think so. Pierre
Hide
Permalink Edit Delete
Gaudin Pierre added a comment - 27/Apr/11 10:18

OK i just try to create PO on demo Trunck and demo 9.04

OrderHeader.productStoreId is empty on Trunck
OrderHeader.productStoreId is NOT empty on 9.04

So i will create a new JIRA on this regression and close this one if you agree with me.

Pierre
Show
Gaudin Pierre added a comment - 27/Apr/11 10:18 OK i just try to create PO on demo Trunck and demo 9.04 OrderHeader.productStoreId is empty on Trunck OrderHeader.productStoreId is NOT empty on 9.04 So i will create a new JIRA on this regression and close this one if you agree with me. Pierre
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 10:24

This has been recently discussed on user ML. In Opentaps they created a dummy Product Store for that, but I tend to agree with Paul...
Show
Jacques Le Roux added a comment - 27/Apr/11 10:24 This has been recently discussed on user ML. In Opentaps they created a dummy Product Store for that, but I tend to agree with Paul...
Hide
Permalink
Jacques Le Roux added a comment - 27/Apr/11 11:00

Pierre,

Interesting, our comments crossed on wire. So it was working in R9.04, yes we need to investigate at least. I agree a Jira for that is welcome...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4266) productStore is empty for Purcahse Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025762#comment-13025762 ]

Gaudin Pierre commented on OFBIZ-4266:
--------------------------------------

Thank you for the link Jacques.

A simple way should be to add a drop down with available productStore on the PO creation order form such as SO creation form.

Pierre

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4266) productStore is empty for Purcahse Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025768#comment-13025768 ]

Hans Bakker commented on OFBIZ-4266:
------------------------------------

Product stores are for selling products.

THat the productStoreid is empty for purchase orders is normal, although in the past it was filled.

Regards,'
Hans

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4266) ProductStore is empty for Purchase Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4266:
-----------------------------------

Summary: ProductStore is empty for Purchase Order (was: productStore is empty for Purcahse Order)

> ProductStore is empty for Purchase Order
> ----------------------------------------
>
> Key: OFBIZ-4266
> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Gaudin Pierre
>
> The field orderHeader.productStoreId is empty for purchase order.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025772#comment-13025772 ]

Jacques Le Roux commented on OFBIZ-4266:
----------------------------------------

Ha thanks Hans,

So this has been intentionally changed! In such case, as I said in the related thread http://markmail.org/message/ew4rpf4ulbg3u3oi I continue to agree with Paul hence with Hans here. We could continue the discussion in this thread (renaming it though), Paul suggested a larger change...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025777#comment-13025777 ]

Gaudin Pierre commented on OFBIZ-4266:
--------------------------------------

Thank you Hans for the reply,

Can you explain why "productStoreid is empty for purchase orders is normal" ?

thanks,

Pierre

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

hans_bakker

Re: [jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

As i wrote, product stores are for selling , not buying.....

So, if you going to purchase a product, why would you like to have it
connected to a productStore? What is the advantage?

I did not initiate this change although it sound logical to me....

search the mailing list archives i can remember there was a discussion
about it.

Regards,
Hans

On Wed, 2011-04-27 at 12:56 +0000, Gaudin Pierre (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025777#comment-13025777 ]
>
> Gaudin Pierre commented on OFBIZ-4266:
> --------------------------------------
>
> Thank you Hans for the reply,
>
> Can you explain why "productStoreid is empty for purchase orders is normal" ?
>
> thanks,
>
> Pierre
>
> > ProductStore is empty for Purchase Order
> > ----------------------------------------
> >
> > Key: OFBIZ-4266
> > URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> > Project: OFBiz
> > Issue Type: Bug
> > Components: order
> > Affects Versions: SVN trunk
> > Reporter: Gaudin Pierre
> >
> > The field orderHeader.productStoreId is empty for purchase order.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira

--
Ofbiz on twitter: http://twitter.com/apache_ofbiz
Myself on twitter: http://twitter.com/hansbak
Antwebsystems.com: Quality services for competitive rates.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026003#comment-13026003 ]

Gaudin Pierre commented on OFBIZ-4266:
--------------------------------------

Hi Hans,
On 27/04/2011 15:01, Hans Bakker wrote:
> As i wrote, product stores are for selling , not buying.....
>
> So, if you going to purchase a product, why would you like to have it
> connected to a productStore? What is the advantage?

I understand the logic, but shouldn’t you see the productStore also as the place where to set parameters for the cart and order entities? PO and the SO use the same objects, so it is not illogical that the productStore is used for sales and purchases.

For example, if I want to send e-mail to the suppliers on order status change why not to use the available configuration at the productStore?
I think that there are other possible examples.

Without making productStore mandatory, I think that it would be necessary to be able to at least specify it in parameter of creation of the purchase order.
> I did not initiate this change although it sound logical to me....
>
> search the mailing list archives i can remember there was a discussion
> about it.
I found a main thread but with not enough explanation
http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-1172-Order-Entry-unclear-error-when-no-ProductStore-set-td204660.html

Regards,

Pierre

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

hans_bakker

Re: [jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

Yes it would be nice to send emails to your supplier, but is a fictive
productstore the correct place?

Lateron in the system a different way of sending emails was introduced
which is not connected to a product store and is pretty easy to
implemented by way of a SECA.

Check framework/common/script/org/ofbiz/common/email/EmailServices.xml
which could be used here.

Regards,
Hans

On Wed, 2011-04-27 at 20:58 +0000, Gaudin Pierre (JIRA) wrote:

> [ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026003#comment-13026003 ]
>
> Gaudin Pierre commented on OFBIZ-4266:
> --------------------------------------
>
> Hi Hans,
> On 27/04/2011 15:01, Hans Bakker wrote:
> > As i wrote, product stores are for selling , not buying.....
> >
> > So, if you going to purchase a product, why would you like to have it
> > connected to a productStore? What is the advantage?
>
> I understand the logic, but shouldn’t you see the productStore also as the place where to set parameters for the cart and order entities? PO and the SO use the same objects, so it is not illogical that the productStore is used for sales and purchases.
>
> For example, if I want to send e-mail to the suppliers on order status change why not to use the available configuration at the productStore?
> I think that there are other possible examples.
>
> Without making productStore mandatory, I think that it would be necessary to be able to at least specify it in parameter of creation of the purchase order.
> > I did not initiate this change although it sound logical to me....
> >
> > search the mailing list archives i can remember there was a discussion
> > about it.
> I found a main thread but with not enough explanation
> http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-1172-Order-Entry-unclear-error-when-no-ProductStore-set-td204660.html
>
> Regards,
>
> Pierre
>
> > ProductStore is empty for Purchase Order
> > ----------------------------------------
> >
> > Key: OFBIZ-4266
> > URL: https://issues.apache.org/jira/browse/OFBIZ-4266
> > Project: OFBiz
> > Issue Type: Bug
> > Components: order
> > Affects Versions: SVN trunk
> > Reporter: Gaudin Pierre
> >
> > The field orderHeader.productStoreId is empty for purchase order.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira

--
Ofbiz on twitter: http://twitter.com/apache_ofbiz
Myself on twitter: http://twitter.com/hansbak
Antwebsystems.com: Quality services for competitive rates.

Jacques Le Roux

Re: [jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

Administrator

In reply to this post by Nicolas Malin (Jira)

Pierre,

Not seriously thought, but in French we translated Product Store by "Centre de profit" (Profit Center), maybe we need a "Centre de
coût" (Cost Center)?

Jacques

From: "Gaudin Pierre (JIRA)" <[hidden email]>

> [
> https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026003#comment-13026003 ]
>
> Gaudin Pierre commented on OFBIZ-4266:
> --------------------------------------
>
> Hi Hans,
> On 27/04/2011 15:01, Hans Bakker wrote:
>> As i wrote, product stores are for selling , not buying.....
>>
>> So, if you going to purchase a product, why would you like to have it
>> connected to a productStore? What is the advantage?
>
> I understand the logic, but shouldn’t you see the productStore also as the place where to set parameters for the cart and order
> entities? PO and the SO use the same objects, so it is not illogical that the productStore is used for sales and purchases.
>
> For example, if I want to send e-mail to the suppliers on order status change why not to use the available configuration at the
> productStore?
> I think that there are other possible examples.
>
> Without making productStore mandatory, I think that it would be necessary to be able to at least specify it in parameter of
> creation of the purchase order.
>> I did not initiate this change although it sound logical to me....
>>
>> search the mailing list archives i can remember there was a discussion
>> about it.
> I found a main thread but with not enough explanation
> http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-1172-Order-Entry-unclear-error-when-no-ProductStore-set-td204660.html
>
> Regards,
>
> Pierre
>
>> ProductStore is empty for Purchase Order
>> ----------------------------------------
>>
>> Key: OFBIZ-4266
>> URL: https://issues.apache.org/jira/browse/OFBIZ-4266
>> Project: OFBiz
>> Issue Type: Bug
>> Components: order
>> Affects Versions: SVN trunk
>> Reporter: Gaudin Pierre
>>
>> The field orderHeader.productStoreId is empty for purchase order.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4266) ProductStore is empty for Purchase Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gaudin Pierre closed OFBIZ-4266.
--------------------------------

Resolution: Not A Problem

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026926#comment-13026926 ]

Gaudin Pierre commented on OFBIZ-4266:
--------------------------------------

OK,

Thank you for your points of seen.

I am going to close this JIRA.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4266) ProductStore is empty for Purchase Order

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028079#comment-13028079 ]

Paul Foxworthy commented on OFBIZ-4266:
---------------------------------------

True, I did suggest a larger change in the context of calculating VAT for purchase orders. The more complicated design for that isn't greatly relevant to the discussion here.

In principle, I agree that a ProductStore is not relevant to a purchase order.

If there are some interesting options for orders currently held by the ProductStore, they should be split into their own entity. For sales orders, the ProductStore holds a reference to that entity. For purchase orders, perhaps the SupplierProduct does. Certainly, for a purchase order, the currency must be specified by SupplierProduct. To pay attention to the currency in ProductStore is plain wrong.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira