[jira] [Created] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)
Disabled attribute for lookup field should be readonly.
-------------------------------------------------------

                 Key: OFBIZ-4267
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
             Project: OFBiz
          Issue Type: Bug
          Components: ALL COMPONENTS
    Affects Versions: Release Branch 10.04, SVN trunk
            Reporter: Deepak Dixit
            Priority: Minor
             Fix For: Release Branch 10.04, SVN trunk


Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-4267:
--------------------------------

    Attachment: OFBIZ-4267-trunk.patch
                OFBIZ-4267-branch10.04.patch

Here is the patch for the issue.


> Disabled attribute for lookup field should be readonly.
> -------------------------------------------------------
>
>                 Key: OFBIZ-4267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4267-branch10.04.patch, OFBIZ-4267-trunk.patch
>
>
> Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
> But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
> If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
> Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Assigned] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-4267:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Disabled attribute for lookup field should be readonly.
> -------------------------------------------------------
>
>                 Key: OFBIZ-4267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4267-branch10.04.patch, OFBIZ-4267-trunk.patch
>
>
> Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
> But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
> If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
> Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-4267.
--------------------------------------

    Resolution: Fixed

Thanks Deepak, Committed at trunk r1098082 & rb10.04 r1098087.

--
Ashish Vijaywargiya

> Disabled attribute for lookup field should be readonly.
> -------------------------------------------------------
>
>                 Key: OFBIZ-4267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4267-branch10.04.patch, OFBIZ-4267-trunk.patch
>
>
> Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
> But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
> If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
> Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027304#comment-13027304 ]

Deepak Dixit commented on OFBIZ-4267:
-------------------------------------

Thanks Ashish for committing the patch.
Thanks Rishi for the discussion.

> Disabled attribute for lookup field should be readonly.
> -------------------------------------------------------
>
>                 Key: OFBIZ-4267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4267-branch10.04.patch, OFBIZ-4267-trunk.patch
>
>
> Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
> But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
> If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
> Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Reopened] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit reopened OFBIZ-4267:
---------------------------------


> Disabled attribute for lookup field should be readonly.
> -------------------------------------------------------
>
>                 Key: OFBIZ-4267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4267-branch-fix.patch, OFBIZ-4267-branch10.04.patch, OFBIZ-4267-trunk-fix.patch, OFBIZ-4267-trunk.patch
>
>
> Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
> But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
> If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
> Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Deepak Dixit updated OFBIZ-4267:
--------------------------------

    Attachment: OFBIZ-4267-trunk-fix.patch
                OFBIZ-4267-branch-fix.patch

I forgot to made changes in htmlTemplte.ftl, here is the patch for htmlTemplte.ftl.

> Disabled attribute for lookup field should be readonly.
> -------------------------------------------------------
>
>                 Key: OFBIZ-4267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4267-branch-fix.patch, OFBIZ-4267-branch10.04.patch, OFBIZ-4267-trunk-fix.patch, OFBIZ-4267-trunk.patch
>
>
> Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
> But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
> If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
> Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Commented] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

    [ https://issues.apache.org/jira/browse/OFBIZ-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027320#comment-13027320 ]

Ashish Vijaywargiya commented on OFBIZ-4267:
--------------------------------------------

Thanks Deepak, Committed at r1098100(trunk) & r1098101(rb10.04).

--
Ashish  

> Disabled attribute for lookup field should be readonly.
> -------------------------------------------------------
>
>                 Key: OFBIZ-4267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4267-branch-fix.patch, OFBIZ-4267-branch10.04.patch, OFBIZ-4267-trunk-fix.patch, OFBIZ-4267-trunk.patch
>
>
> Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
> But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
> If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
> Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Reply | Threaded
Open this post in threaded view
|

[jira] [Closed] (OFBIZ-4267) Disabled attribute for lookup field should be readonly.

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya closed OFBIZ-4267.
--------------------------------------

    Resolution: Fixed

> Disabled attribute for lookup field should be readonly.
> -------------------------------------------------------
>
>                 Key: OFBIZ-4267
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4267
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 10.04, SVN trunk
>            Reporter: Deepak Dixit
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>             Fix For: Release Branch 10.04, SVN trunk
>
>         Attachments: OFBIZ-4267-branch-fix.patch, OFBIZ-4267-branch10.04.patch, OFBIZ-4267-trunk-fix.patch, OFBIZ-4267-trunk.patch
>
>
> Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
> But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
> If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
> Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira