[jira] [Created] (OFBIZ-4270) State dropdown only finds states and does not include country information

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-4270:
-----------------------------------

    Attachment: OFBIZ-4270-DependentDropdown.patch

Hi Jacques,
i have an implementation for this issue. Maybe you can cross check it :)

Have a good day
sascha

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046677#comment-13046677 ]

Jacques Le Roux commented on OFBIZ-4270:
----------------------------------------

Sascha,

Apart that I would have preferred GeoWithRegions and GeoAssocAndGeoToWithRegions (because of the geoAssocType), it sounds good to me (only reviewed, not tested)

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049035#comment-13049035 ]

Sascha Rodekamp commented on OFBIZ-4270:
----------------------------------------

Hi Jacques,

cool thanks, now only the countries are missing which should display their states. Do you have any source?

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053118#comment-13053118 ]

Jacques Le Roux commented on OFBIZ-4270:
----------------------------------------

Hi Sascha,

I'd say that, now that we have the mechanism, when people will have a need they will ask or contribute. So it's OK with me to commit as is

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp closed OFBIZ-4270.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Committed  @rev.1140103

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056302#comment-13056302 ]

Sam Hamilton commented on OFBIZ-4270:
-------------------------------------

Hi Sascha - thanks for the commit but I seem to be getting no states now for the USA but the UK works just fine on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer ?

I ran ./ant clean-all && ./ant run-install on my test system here. Can you also reproduce this error?

Thanks
Sam

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056373#comment-13056373 ]

Sascha Rodekamp commented on OFBIZ-4270:
----------------------------------------

Hi Sam,
yes indeed, i didn't add USA to the "GeoWithRegions" table. I'll catch up on it this evening.
Do you have any other countries where the states should be shown?

Cheers
Sascha


 

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056407#comment-13056407 ]

Sam Hamilton commented on OFBIZ-4270:
-------------------------------------

Hi Sascha,

Just looking in the existing data in OFBiz:

Australia
Bulgaria
Brazil
China
Columbia
Germany
Spain
France
India
Ireland
Italy
Mexico
Netherlands
Poland
UK
USA

Thanks
Sam

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056422#comment-13056422 ]

Sam Hamilton commented on OFBIZ-4270:
-------------------------------------

Hi Sascha - digging a bit deeper there is ISO 3166-2 to help with this - http://en.wikipedia.org/wiki/ISO_3166-2 

Thanks
Sam

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056438#comment-13056438 ]

Sascha Rodekamp commented on OFBIZ-4270:
----------------------------------------

Hi Sam,
yes but i.e. France is a country where no states should be displayed. That's the main reason why i created a separate entity to control for which country the states should be shown and for which not.

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056480#comment-13056480 ]

Jacques Le Roux commented on OFBIZ-4270:
----------------------------------------

Yes Sascha (as mentionned in a comment above) that's right for France, and be carefull to add others without being sure it's needed. BTW I wonder why USA is missing. I thought the idea was to add to already existing Countries with states/province (like USA, AUS, CAN, etc.) the federations like UK (others needed?)

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056611#comment-13056611 ]

Sascha Rodekamp commented on OFBIZ-4270:
----------------------------------------

OK i added the missing countries, hope i got all.

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056746#comment-13056746 ]

Scott Gray commented on OFBIZ-4270:
-----------------------------------

Question, why are we tracking Geo's and GeoAssoc's for France's provinces if postal addresses don't need it?  Aren't we creating unnecessary complications (and entities) just to track information we aren't using?

Also, why create the new entity when we could have just added an additional field to Geo?  And since when do we use 1s instead of Y on indicator fields?

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056917#comment-13056917 ]

Paul Foxworthy commented on OFBIZ-4270:
---------------------------------------

Hi Scott,

Geo is a very general thing, not just for postal addresses. Some Ofbiz users might use provinces for a regional breakdown of marketing data and regional sales campaigns. Who knows? Provided the Ofbiz community is willing to maintain the Geo seed data, and we take reasonable care compiling it, there is no harm in having detail in the Geo data that's not needed for postal addresses.

Geo is also a very simple entity, and I don't think it's right to add an attribute that is only relevant to Geos of type COUNTRY.

I think GeoWithRegions is a starting point for an entity to describe the rules for a valid postal address. As well as whether a given country uses regions in their postal addresses, there are other issues such as:

    * Where should the postcode/zip code be placed in the address?
    * What format should a valid postcode have?

For data entry, we could define a view that brings together each Geo of type COUNTRY and its associated GeoWithRegions, if one exists. That would give the effect of the Geo with an additional field (i.e. what you've suggested) in a more general and extensible way.

Cheers

Paul Foxworthy

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056942#comment-13056942 ]

Scott Gray commented on OFBIZ-4270:
-----------------------------------

Hi Paul,

Fair call on the Assocs, obviously they can be used for more than just postal addresses.

I'm not opposed to having an entity used to describing valid postal address formats but I don't think GeoWithState (or GeoWithRegions) is a good name for it, obviously I'm already confused as to why it exists, it appears to have just been picked at random based on the problem at hand.  This seems like a weak starting point in an area (the data model) that doesn't lend itself well to constant refactorings and a "figure it out as we go" approach.  A solid data model is one of the most critical parts of OFBiz and making a mess of it is the fastest way to kill the project.  

I'd suggest you all take a step back, figure out what a final solution should look like and then propose it for feedback to the wider community.

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057032#comment-13057032 ]

Sascha Rodekamp commented on OFBIZ-4270:
----------------------------------------

Hey Scott,

thanks for reviewing.
First my fault with the 1s, defining the indicator field i only thought of 1s and 0s :-)

To clarify i added the "GeoWithState" Entity not for validating Postal addresses. The point is, for some countries we need this "depend state drop down" and for others not. In the assoc table is no clear identifier which could be used for this decision. I.E. when you choose GBR (which is divided into ENGL, NIRL, WALS, SCOT). The dependent drop down list should show all states and substates. But if you choose France it is not necessary display the states. For now the "GeoWithState" entity is only a helper entity to create the view which is used in the Java Code to filter the states and substates (for the countries where it is needed).
Another idea was to put this state list in a property file. But that isn's as fast as the entity solution.

I'm open for other ideas and further thoughts :)

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057175#comment-13057175 ]

Adrian Crum commented on OFBIZ-4270:
------------------------------------

I agree with Scott. Parts of the data model are becoming a mess, so we need to have a more inclusive/extensive discussion when we consider changing it. (A good example of a bad data model is the CountryCapital entity - which could be accomplished with GeoAssoc.)

We already have the ability to associate Geos with other Geos by using the GeoAssoc entity. What seems to be missing is some kind of the flag the UI can use to construct pick lists. So, what about having a GeoAssocType like PICKLIST_MEMBER to define associations the UI needs to construct pick lists?

Btw, it might be worthwhile to include fromDate/thruDate in GeoAssoc - to accommodate changes in Geo associations over time. Geographic boundaries change regularly.

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057225#comment-13057225 ]

Sascha Rodekamp commented on OFBIZ-4270:
----------------------------------------

Hey Adrian,

sounds good, but a new assoc type means that we have to store the assocs (which are needed by the UI) twice, once for the country state mapping (as it is now) and once for the UI. But i don't think that this blow the database, there aren't to many records, aren't there?!

 

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057301#comment-13057301 ]

Adrian Crum commented on OFBIZ-4270:
------------------------------------

Sascha,

Having duplicate relationships with different types is possible. Example: In the US, a city is a member of a county, but a city could also be the county seat (county capitol). So, there would be two relationships from the county to the city - but with different types (county member and county seat). The same thing is true with a US state and a city: a city is a member of a state, but a city could also be a state capitol. So, there would be two relationships from the state to the city - but with different types (state member and state capitol).

In The Data Model Resource Book, what is being modeled are geographic boundaries. The book describes how a member Geo doesn't have to be physically located inside its parent Geo - it can be an abstract boundary like a sales or service territory. In those cases the relationship is more like a role than a physical relationship.

So, we can use the association type to define Geo roles (as above). Or we could have a Geo role relationship entity - to model things like colonies and territories that are outside a geographic boundary but are still related in some way.

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057359#comment-13057359 ]

Sascha Rodekamp commented on OFBIZ-4270:
----------------------------------------

That's sounds like a plan Adrian. Thank you for the clarification, i'll follow this way.

> State dropdown only finds states and does not include county information
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4270
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4270
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Sam Hamilton
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4270-DependentDropdown.patch, OFBIZ-4270-DependentDropdown.patch
>
>
> If you are on this page https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/newcustomer select USA from the country drop down and it will display all the USA states, similarly it works just fine for Spain but if you try once again with either United Kingdom or France it will show "No States/Provinces exist".
> Both UK and France have Counties saved in the datamodel but the form does not lookup in the correct location as they are not defined as State.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira