[jira] [Created] (OFBIZ-4278) ModelScreen does not rollback transaction when ScreenRenderException occurs

[Nicolas Malin (Jira)]

ModelScreen does not rollback transaction when ScreenRenderException occurs
---------------------------------------------------------------------------

                 Key: OFBIZ-4278
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4278
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Philippe Mouawad


Hello,
Is there any reason why ModelScreen#renderScreenString() does not call TransactionUtil#rollback when ScreenRenderException occurs.
It does so when Exception or RuntimeException occur.
Furthermore, what's the point in duplicating code for Exception and RuntimeException ?

As I am not sure if there is a reason , I ask, if you confirm it is useless I will provide a patch.
Regards
Philippe

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032976#comment-13032976 ]

Scott Gray commented on OFBIZ-4278:
-----------------------------------

I don't see a reason why it doesn't and the commit makes no mention of it: http://svn.apache.org/viewvc?view=revision&revision=561025

And yeah I agree the duplicated code doesn't seem to serve any purpose.

> ModelScreen does not rollback transaction when ScreenRenderException occurs
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-4278
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4278
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Philippe Mouawad
>
> Hello,
> Is there any reason why ModelScreen#renderScreenString() does not call TransactionUtil#rollback when ScreenRenderException occurs.
> It does so when Exception or RuntimeException occur.
> Furthermore, what's the point in duplicating code for Exception and RuntimeException ?
> As I am not sure if there is a reason , I ask, if you confirm it is useless I will provide a patch.
> Regards
> Philippe

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Philippe Mouawad updated OFBIZ-4278:
------------------------------------

    Attachment: patch-OFBIZ-4278.patch

The patch that fixes the issue.
Philippe Mouawad
http://www.ubik-ingenierie.com

> ModelScreen does not rollback transaction when ScreenRenderException occurs
> ---------------------------------------------------------------------------
>
>                 Key: OFBIZ-4278
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4278
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Philippe Mouawad
>         Attachments: patch-OFBIZ-4278.patch
>
>
> Hello,
> Is there any reason why ModelScreen#renderScreenString() does not call TransactionUtil#rollback when ScreenRenderException occurs.
> It does so when Exception or RuntimeException occur.
> Furthermore, what's the point in duplicating code for Exception and RuntimeException ?
> As I am not sure if there is a reason , I ask, if you confirm it is useless I will provide a patch.
> Regards
> Philippe

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira