OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-431) Editting Order goes recursive with promotions...

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-431) Editting Order goes recursive with promotions...

Editting Order goes recursive with promotions...
------------------------------------------------

Key: OFBIZ-431
URL: http://issues.apache.org/jira/browse/OFBIZ-431
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Environment: N/A - clean default
Reporter: Ray Barlow
Priority: Critical

With the standard demo data raise an order for admin with 1 GZ-1000 and 1 GZ-7000, 3 promotional products will be added to the order which is fine.

Find and view the newly created order in the order application. Click on the edit link and then try to increase the order quantity of the GZ-1000 from 1 to 2, the system will thrash away for a while and then fail with a transaction error, timed out.

Once the dust has settled you can see that the party has also been sent 100 +/-5 email notification changes, which is were I'm getting the feeling that recursion is the problem!

Trying to cancel a line item can also cause the same effect, in general editting orders with promotions seems to cause lots of problems at the moment.

PS: I'd advise this only gets tested on local development machines as the impact is quite an intense load on the server and can result in DoS style problems. That said I did execute this once on the "demo.dejc.com" server (sorry David) just to check it wasn't anything I'd changed, the admin account now has a lot of order change notifications (at least until the next reload of the site!).

PPS: This can also be triggered via the customer facing site, when cancelling a line item from the order history page, bit of an exposure for live sites to DoS from malicious users.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-431) Editting Order goes recursive with promotions...

[ http://issues.apache.org/jira/browse/OFBIZ-431?page=comments#action_12448843 ]

Jacques Le Roux commented on OFBIZ-431:
---------------------------------------

Ray,

Your PPS forces us to look at that quickly I guess...

> Editting Order goes recursive with promotions...
> ------------------------------------------------
>
> Key: OFBIZ-431
> URL: http://issues.apache.org/jira/browse/OFBIZ-431
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A - clean default
> Reporter: Ray Barlow
> Priority: Critical
>
> With the standard demo data raise an order for admin with 1 GZ-1000 and 1 GZ-7000, 3 promotional products will be added to the order which is fine.
> Find and view the newly created order in the order application. Click on the edit link and then try to increase the order quantity of the GZ-1000 from 1 to 2, the system will thrash away for a while and then fail with a transaction error, timed out.
> Once the dust has settled you can see that the party has also been sent 100 +/-5 email notification changes, which is were I'm getting the feeling that recursion is the problem!
> Trying to cancel a line item can also cause the same effect, in general editting orders with promotions seems to cause lots of problems at the moment.
> PS: I'd advise this only gets tested on local development machines as the impact is quite an intense load on the server and can result in DoS style problems. That said I did execute this once on the "demo.dejc.com" server (sorry David) just to check it wasn't anything I'd changed, the admin account now has a lot of order change notifications (at least until the next reload of the site!).
> PPS: This can also be triggered via the customer facing site, when cancelling a line item from the order history page, bit of an exposure for live sites to DoS from malicious users.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-431) Editting Order goes recursive with promotions...

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-431?page=comments#action_12449112 ]

Scott Gray commented on OFBIZ-431:
----------------------------------

I've found the problem but I'm not sure of the best way to fix it.
The infinite loop occurs when the cancelOrderItem service is called on an order containing promo order items. There is a seca on the service which calls recreateOrderAdjustments, which in turn iterates through all the promo items and calls cancelOrderItem on them, and on we go into the loop.

I don't know enough about the order stuff to start playing but hopefully this will point whoever does fix it in the right direction.

Regards
Scott

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-431) Editting Order goes recursive with promotions...

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-431?page=comments#action_12450474 ]

Scott Gray commented on OFBIZ-431:
----------------------------------

Ok, I think I've got this fixed I'll upload a patch tonight (12 hours from now) when I get home from work.

I fixed the recursion by creating an additional service for cancelOrderItem that avoids the seca's normally associated with it. I have used the new service inside recreateOrderAdjustments (this fixes the recursion), and also inside saveUpdatedCartToOrder (another place causing multiple emails and other problems).

I also added recreateOrderAdjustments as a seca on updateOrderItems.

I don't think I've fixed all of the problems but it should allow us to downgrade (or close) this issue

Regards
Scott

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-431) Editting Order goes recursive with promotions...

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-431?page=all ]

Jacopo Cappellato reassigned OFBIZ-431:
---------------------------------------

Assignee: Jacopo Cappellato

> Editting Order goes recursive with promotions...
> ------------------------------------------------
>
> Key: OFBIZ-431
> URL: http://issues.apache.org/jira/browse/OFBIZ-431
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A - clean default
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Priority: Critical
>
> With the standard demo data raise an order for admin with 1 GZ-1000 and 1 GZ-7000, 3 promotional products will be added to the order which is fine.
> Find and view the newly created order in the order application. Click on the edit link and then try to increase the order quantity of the GZ-1000 from 1 to 2, the system will thrash away for a while and then fail with a transaction error, timed out.
> Once the dust has settled you can see that the party has also been sent 100 +/-5 email notification changes, which is were I'm getting the feeling that recursion is the problem!
> Trying to cancel a line item can also cause the same effect, in general editting orders with promotions seems to cause lots of problems at the moment.
> PS: I'd advise this only gets tested on local development machines as the impact is quite an intense load on the server and can result in DoS style problems. That said I did execute this once on the "demo.dejc.com" server (sorry David) just to check it wasn't anything I'd changed, the admin account now has a lot of order change notifications (at least until the next reload of the site!).
> PPS: This can also be triggered via the customer facing site, when cancelling a line item from the order history page, bit of an exposure for live sites to DoS from malicious users.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-431) Editting Order goes recursive with promotions...

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462190 ]

Scott Gray commented on OFBIZ-431:
----------------------------------

Hi Jacques

Sorry, I must have missed your comment above.
I gave up on fixing this as it was a little too complex for me, but if no one is going to look at this any time soon I will have another go. So please anyone, if you are planning on working on this let me know so that I don't start on it in vain.

Thanks
Scott

> Editting Order goes recursive with promotions...
> ------------------------------------------------
>
> Key: OFBIZ-431
> URL: https://issues.apache.org/jira/browse/OFBIZ-431
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A - clean default
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Priority: Critical
>
> With the standard demo data raise an order for admin with 1 GZ-1000 and 1 GZ-7000, 3 promotional products will be added to the order which is fine.
> Find and view the newly created order in the order application. Click on the edit link and then try to increase the order quantity of the GZ-1000 from 1 to 2, the system will thrash away for a while and then fail with a transaction error, timed out.
> Once the dust has settled you can see that the party has also been sent 100 +/-5 email notification changes, which is were I'm getting the feeling that recursion is the problem!
> Trying to cancel a line item can also cause the same effect, in general editting orders with promotions seems to cause lots of problems at the moment.
> PS: I'd advise this only gets tested on local development machines as the impact is quite an intense load on the server and can result in DoS style problems. That said I did execute this once on the "demo.dejc.com" server (sorry David) just to check it wasn't anything I'd changed, the admin account now has a lot of order change notifications (at least until the next reload of the site!).
> PPS: This can also be triggered via the customer facing site, when cancelling a line item from the order history page, bit of an exposure for live sites to DoS from malicious users.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-431) Editting Order goes recursive with promotions...

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462193 ]

Jacques Le Roux commented on OFBIZ-431:
---------------------------------------

Scott,

Your help will be very appreciated, sure !