[jira] [Created] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
Locked
[jira] [Created] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
 
|
When creating a customer from the shopping cart the selected country has to be the default one (with patch)
----------------------------------------------------------------------------------------------------------- Key: OFBIZ-4324 URL: https://issues.apache.org/jira/browse/OFBIZ-4324 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Stéphane DUCAS Priority: Minor When creating a new customer from the shopping cart of the ordermgr application, the country field is initialized to Afghanistan. It make sense that the country field should be the default country defined in general.properties. Here is the patch: Index: framework/common/webcommon/includes/countries.ftl =================================================================== --- framework/common/webcommon/includes/countries.ftl (revision 1137569) +++ framework/common/webcommon/includes/countries.ftl (working copy) @@ -18,6 +18,6 @@ --> <#assign countries = Static["org.ofbiz.common.CommonWorkers"].getCountryList(delegator)> <#list countries as country> - <option value='${country.geoId}'>${country.get("geoName",locale)?default(country.geoId)}</option> + <option value='${country.geoId}' ${(country.geoId==defaultCountryGeoId)?string("selected=\"selected\"","")}>${country.get("geoName",locale)?default(country.geoId)}</option> </#list> Index: applications/order/widget/ordermgr/OrderEntryOrderScreens.xml =================================================================== --- applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (revision 1137569) +++ applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (working copy) @@ -109,6 +109,7 @@ <set field="stepTitleId" value="OrderOrderEntryShipToSettings"/> <set field="stepLabelId" value="FacilityShipping"/> <script location="component://order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy"/> + <property-to-field field="defaultCountryGeoId" resource="general" property="country.geo.id.default" default="USA"/> </actions> <widgets> <decorator-screen name="CommonOrderCheckoutDecorator"> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053860#comment-13053860 ] Erwan de FERRIERES commented on OFBIZ-4324: ------------------------------------------- Hi Stephane, you should attach your patch as a file to the issue and accept the license. If it's just a description, then it couldn't be included. Thanks, > When creating a customer from the shopping cart the selected country has to be the default one (with patch) > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4324 > URL: https://issues.apache.org/jira/browse/OFBIZ-4324 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Stéphane DUCAS > Priority: Minor > > When creating a new customer from the shopping cart of the ordermgr application, the country field is initialized to Afghanistan. It make sense that the country field should be the default country defined in general.properties. > Here is the patch: > Index: framework/common/webcommon/includes/countries.ftl > =================================================================== > --- framework/common/webcommon/includes/countries.ftl (revision 1137569) > +++ framework/common/webcommon/includes/countries.ftl (working copy) > @@ -18,6 +18,6 @@ > --> > <#assign countries = Static["org.ofbiz.common.CommonWorkers"].getCountryList(delegator)> > <#list countries as country> > - <option value='${country.geoId}'>${country.get("geoName",locale)?default(country.geoId)}</option> > + <option value='${country.geoId}' ${(country.geoId==defaultCountryGeoId)?string("selected=\"selected\"","")}>${country.get("geoName",locale)?default(country.geoId)}</option> > </#list> > > Index: applications/order/widget/ordermgr/OrderEntryOrderScreens.xml > =================================================================== > --- applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (revision 1137569) > +++ applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (working copy) > @@ -109,6 +109,7 @@ > <set field="stepTitleId" value="OrderOrderEntryShipToSettings"/> > <set field="stepLabelId" value="FacilityShipping"/> > <script location="component://order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy"/> > + <property-to-field field="defaultCountryGeoId" resource="general" property="country.geo.id.default" default="USA"/> > </actions> > <widgets> > <decorator-screen name="CommonOrderCheckoutDecorator"> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stéphane DUCAS updated OFBIZ-4324: ---------------------------------- Attachment: SelectionPaysParDefaut (2).patch > When creating a customer from the shopping cart the selected country has to be the default one (with patch) > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4324 > URL: https://issues.apache.org/jira/browse/OFBIZ-4324 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Stéphane DUCAS > Priority: Minor > Attachments: SelectionPaysParDefaut (2).patch > > > When creating a new customer from the shopping cart of the ordermgr application, the country field is initialized to Afghanistan. It make sense that the country field should be the default country defined in general.properties. > Here is the patch: > Index: framework/common/webcommon/includes/countries.ftl > =================================================================== > --- framework/common/webcommon/includes/countries.ftl (revision 1137569) > +++ framework/common/webcommon/includes/countries.ftl (working copy) > @@ -18,6 +18,6 @@ > --> > <#assign countries = Static["org.ofbiz.common.CommonWorkers"].getCountryList(delegator)> > <#list countries as country> > - <option value='${country.geoId}'>${country.get("geoName",locale)?default(country.geoId)}</option> > + <option value='${country.geoId}' ${(country.geoId==defaultCountryGeoId)?string("selected=\"selected\"","")}>${country.get("geoName",locale)?default(country.geoId)}</option> > </#list> > > Index: applications/order/widget/ordermgr/OrderEntryOrderScreens.xml > =================================================================== > --- applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (revision 1137569) > +++ applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (working copy) > @@ -109,6 +109,7 @@ > <set field="stepTitleId" value="OrderOrderEntryShipToSettings"/> > <set field="stepLabelId" value="FacilityShipping"/> > <script location="component://order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy"/> > + <property-to-field field="defaultCountryGeoId" resource="general" property="country.geo.id.default" default="USA"/> > </actions> > <widgets> > <decorator-screen name="CommonOrderCheckoutDecorator"> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053868#comment-13053868 ] Stéphane DUCAS commented on OFBIZ-4324: --------------------------------------- Hello Erwan, Patch attached and license accepted. > When creating a customer from the shopping cart the selected country has to be the default one (with patch) > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4324 > URL: https://issues.apache.org/jira/browse/OFBIZ-4324 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Stéphane DUCAS > Priority: Minor > Attachments: SelectionPaysParDefaut (2).patch > > > When creating a new customer from the shopping cart of the ordermgr application, the country field is initialized to Afghanistan. It make sense that the country field should be the default country defined in general.properties. > Here is the patch: > Index: framework/common/webcommon/includes/countries.ftl > =================================================================== > --- framework/common/webcommon/includes/countries.ftl (revision 1137569) > +++ framework/common/webcommon/includes/countries.ftl (working copy) > @@ -18,6 +18,6 @@ > --> > <#assign countries = Static["org.ofbiz.common.CommonWorkers"].getCountryList(delegator)> > <#list countries as country> > - <option value='${country.geoId}'>${country.get("geoName",locale)?default(country.geoId)}</option> > + <option value='${country.geoId}' ${(country.geoId==defaultCountryGeoId)?string("selected=\"selected\"","")}>${country.get("geoName",locale)?default(country.geoId)}</option> > </#list> > > Index: applications/order/widget/ordermgr/OrderEntryOrderScreens.xml > =================================================================== > --- applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (revision 1137569) > +++ applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (working copy) > @@ -109,6 +109,7 @@ > <set field="stepTitleId" value="OrderOrderEntryShipToSettings"/> > <set field="stepLabelId" value="FacilityShipping"/> > <script location="component://order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy"/> > + <property-to-field field="defaultCountryGeoId" resource="general" property="country.geo.id.default" default="USA"/> > </actions> > <widgets> > <decorator-screen name="CommonOrderCheckoutDecorator"> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Assigned] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES reassigned OFBIZ-4324: ----------------------------------------- Assignee: Erwan de FERRIERES > When creating a customer from the shopping cart the selected country has to be the default one (with patch) > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4324 > URL: https://issues.apache.org/jira/browse/OFBIZ-4324 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Stéphane DUCAS > Assignee: Erwan de FERRIERES > Priority: Minor > Attachments: SelectionPaysParDefaut (2).patch > > > When creating a new customer from the shopping cart of the ordermgr application, the country field is initialized to Afghanistan. It make sense that the country field should be the default country defined in general.properties. > Here is the patch: > Index: framework/common/webcommon/includes/countries.ftl > =================================================================== > --- framework/common/webcommon/includes/countries.ftl (revision 1137569) > +++ framework/common/webcommon/includes/countries.ftl (working copy) > @@ -18,6 +18,6 @@ > --> > <#assign countries = Static["org.ofbiz.common.CommonWorkers"].getCountryList(delegator)> > <#list countries as country> > - <option value='${country.geoId}'>${country.get("geoName",locale)?default(country.geoId)}</option> > + <option value='${country.geoId}' ${(country.geoId==defaultCountryGeoId)?string("selected=\"selected\"","")}>${country.get("geoName",locale)?default(country.geoId)}</option> > </#list> > > Index: applications/order/widget/ordermgr/OrderEntryOrderScreens.xml > =================================================================== > --- applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (revision 1137569) > +++ applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (working copy) > @@ -109,6 +109,7 @@ > <set field="stepTitleId" value="OrderOrderEntryShipToSettings"/> > <set field="stepLabelId" value="FacilityShipping"/> > <script location="component://order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy"/> > + <property-to-field field="defaultCountryGeoId" resource="general" property="country.geo.id.default" default="USA"/> > </actions> > <widgets> > <decorator-screen name="CommonOrderCheckoutDecorator"> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stéphane DUCAS updated OFBIZ-4324: ---------------------------------- Attachment: Patch_country > When creating a customer from the shopping cart the selected country has to be the default one (with patch) > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4324 > URL: https://issues.apache.org/jira/browse/OFBIZ-4324 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Stéphane DUCAS > Assignee: Erwan de FERRIERES > Priority: Minor > Attachments: Patch_country, SelectionPaysParDefaut (2).patch > > > When creating a new customer from the shopping cart of the ordermgr application, the country field is initialized to Afghanistan. It make sense that the country field should be the default country defined in general.properties. > Here is the patch: > Index: framework/common/webcommon/includes/countries.ftl > =================================================================== > --- framework/common/webcommon/includes/countries.ftl (revision 1137569) > +++ framework/common/webcommon/includes/countries.ftl (working copy) > @@ -18,6 +18,6 @@ > --> > <#assign countries = Static["org.ofbiz.common.CommonWorkers"].getCountryList(delegator)> > <#list countries as country> > - <option value='${country.geoId}'>${country.get("geoName",locale)?default(country.geoId)}</option> > + <option value='${country.geoId}' ${(country.geoId==defaultCountryGeoId)?string("selected=\"selected\"","")}>${country.get("geoName",locale)?default(country.geoId)}</option> > </#list> > > Index: applications/order/widget/ordermgr/OrderEntryOrderScreens.xml > =================================================================== > --- applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (revision 1137569) > +++ applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (working copy) > @@ -109,6 +109,7 @@ > <set field="stepTitleId" value="OrderOrderEntryShipToSettings"/> > <set field="stepLabelId" value="FacilityShipping"/> > <script location="component://order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy"/> > + <property-to-field field="defaultCountryGeoId" resource="general" property="country.geo.id.default" default="USA"/> > </actions> > <widgets> > <decorator-screen name="CommonOrderCheckoutDecorator"> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054339#comment-13054339 ] Stéphane DUCAS commented on OFBIZ-4324: --------------------------------------- I found a bug cause by the Patch when creating the order... the patch : Patch_country is the correct version.. > When creating a customer from the shopping cart the selected country has to be the default one (with patch) > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4324 > URL: https://issues.apache.org/jira/browse/OFBIZ-4324 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Stéphane DUCAS > Assignee: Erwan de FERRIERES > Priority: Minor > Attachments: Patch_country, SelectionPaysParDefaut (2).patch > > > When creating a new customer from the shopping cart of the ordermgr application, the country field is initialized to Afghanistan. It make sense that the country field should be the default country defined in general.properties. > Here is the patch: > Index: framework/common/webcommon/includes/countries.ftl > =================================================================== > --- framework/common/webcommon/includes/countries.ftl (revision 1137569) > +++ framework/common/webcommon/includes/countries.ftl (working copy) > @@ -18,6 +18,6 @@ > --> > <#assign countries = Static["org.ofbiz.common.CommonWorkers"].getCountryList(delegator)> > <#list countries as country> > - <option value='${country.geoId}'>${country.get("geoName",locale)?default(country.geoId)}</option> > + <option value='${country.geoId}' ${(country.geoId==defaultCountryGeoId)?string("selected=\"selected\"","")}>${country.get("geoName",locale)?default(country.geoId)}</option> > </#list> > > Index: applications/order/widget/ordermgr/OrderEntryOrderScreens.xml > =================================================================== > --- applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (revision 1137569) > +++ applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (working copy) > @@ -109,6 +109,7 @@ > <set field="stepTitleId" value="OrderOrderEntryShipToSettings"/> > <set field="stepLabelId" value="FacilityShipping"/> > <script location="component://order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy"/> > + <property-to-field field="defaultCountryGeoId" resource="general" property="country.geo.id.default" default="USA"/> > </actions> > <widgets> > <decorator-screen name="CommonOrderCheckoutDecorator"> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Closed] (OFBIZ-4324) When creating a customer from the shopping cart the selected country has to be the default one (with patch)
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-4324. ------------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Done in trunk at r1139291 Thanks Stephane > When creating a customer from the shopping cart the selected country has to be the default one (with patch) > ----------------------------------------------------------------------------------------------------------- > > Key: OFBIZ-4324 > URL: https://issues.apache.org/jira/browse/OFBIZ-4324 > Project: OFBiz > Issue Type: Improvement > Components: order > Affects Versions: SVN trunk > Reporter: Stéphane DUCAS > Assignee: Erwan de FERRIERES > Priority: Minor > Fix For: SVN trunk > > Attachments: Patch_country, SelectionPaysParDefaut (2).patch > > > When creating a new customer from the shopping cart of the ordermgr application, the country field is initialized to Afghanistan. It make sense that the country field should be the default country defined in general.properties. > Here is the patch: > Index: framework/common/webcommon/includes/countries.ftl > =================================================================== > --- framework/common/webcommon/includes/countries.ftl (revision 1137569) > +++ framework/common/webcommon/includes/countries.ftl (working copy) > @@ -18,6 +18,6 @@ > --> > <#assign countries = Static["org.ofbiz.common.CommonWorkers"].getCountryList(delegator)> > <#list countries as country> > - <option value='${country.geoId}'>${country.get("geoName",locale)?default(country.geoId)}</option> > + <option value='${country.geoId}' ${(country.geoId==defaultCountryGeoId)?string("selected=\"selected\"","")}>${country.get("geoName",locale)?default(country.geoId)}</option> > </#list> > > Index: applications/order/widget/ordermgr/OrderEntryOrderScreens.xml > =================================================================== > --- applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (revision 1137569) > +++ applications/order/widget/ordermgr/OrderEntryOrderScreens.xml (working copy) > @@ -109,6 +109,7 @@ > <set field="stepTitleId" value="OrderOrderEntryShipToSettings"/> > <set field="stepLabelId" value="FacilityShipping"/> > <script location="component://order/webapp/ordermgr/WEB-INF/actions/entry/ShipSettings.groovy"/> > + <property-to-field field="defaultCountryGeoId" resource="general" property="country.geo.id.default" default="USA"/> > </actions> > <widgets> > <decorator-screen name="CommonOrderCheckoutDecorator"> -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |