Ajax callings in CheckoutProcess.js are not handling server-side errors correctly
--------------------------------------------------------------------------------- Key: OFBIZ-4342 URL: https://issues.apache.org/jira/browse/OFBIZ-4342 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Jonatan Soto All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonatan Soto updated OFBIZ-4342: -------------------------------- Attachment: patch.txt Patch that corrects the anomalous behavior. > Ajax callings in CheckoutProcess.js are not handling server-side errors correctly > --------------------------------------------------------------------------------- > > Key: OFBIZ-4342 > URL: https://issues.apache.org/jira/browse/OFBIZ-4342 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jonatan Soto > Labels: ajax, checkout > Attachments: patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4342: -------------------------------------- Assignee: Sascha Rodekamp > Ajax callings in CheckoutProcess.js are not handling server-side errors correctly > --------------------------------------------------------------------------------- > > Key: OFBIZ-4342 > URL: https://issues.apache.org/jira/browse/OFBIZ-4342 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jonatan Soto > Assignee: Sascha Rodekamp > Labels: ajax, checkout > Attachments: patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092695#comment-13092695 ] Sascha Rodekamp commented on OFBIZ-4342: ---------------------------------------- Hi Jonatan, that looks good to me, i will review your patch in detail. Thanks for your affort! > Ajax callings in CheckoutProcess.js are not handling server-side errors correctly > --------------------------------------------------------------------------------- > > Key: OFBIZ-4342 > URL: https://issues.apache.org/jira/browse/OFBIZ-4342 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jonatan Soto > Assignee: Sascha Rodekamp > Labels: ajax, checkout > Attachments: patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094396#comment-13094396 ] Sascha Rodekamp commented on OFBIZ-4342: ---------------------------------------- Hi Jonatan, i tested your patch and must say it breaks the OnePageCheckOut, when I try to go to step two nothing happens. Could you please investigate? Another small thing, when you create a patch please try to replace all tabs with spaces. Thanks for your help Sascha > Ajax callings in CheckoutProcess.js are not handling server-side errors correctly > --------------------------------------------------------------------------------- > > Key: OFBIZ-4342 > URL: https://issues.apache.org/jira/browse/OFBIZ-4342 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jonatan Soto > Assignee: Sascha Rodekamp > Labels: ajax, checkout > Attachments: patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094399#comment-13094399 ] Jonatan Soto commented on OFBIZ-4342: ------------------------------------- Hi Sascha, Many thanks for test it. The truth is that I tested only in my custom ecommerce application where I have altered considerably the original behaviour and it works fine. But I keep the OOTB ecommerce app intact and I often apply vendor drops just to have the lastest changes. When I applied the changes to the original ecommerce app, I also looked if there was any change in the Ofbiz SVN and then I inserted all the new code only for the Ajax calls just to handle server error messages. I will investigate further with a clean ofbiz installation and provide a new patch properly tested and formatted. Best regards > Ajax callings in CheckoutProcess.js are not handling server-side errors correctly > --------------------------------------------------------------------------------- > > Key: OFBIZ-4342 > URL: https://issues.apache.org/jira/browse/OFBIZ-4342 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jonatan Soto > Assignee: Sascha Rodekamp > Labels: ajax, checkout > Attachments: patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104346#comment-13104346 ] Sascha Rodekamp commented on OFBIZ-4342: ---------------------------------------- Hey Jonatan any news for this issue? > Ajax callings in CheckoutProcess.js are not handling server-side errors correctly > --------------------------------------------------------------------------------- > > Key: OFBIZ-4342 > URL: https://issues.apache.org/jira/browse/OFBIZ-4342 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jonatan Soto > Assignee: Sascha Rodekamp > Labels: ajax, checkout > Attachments: patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114546#comment-13114546 ] Jacques Le Roux commented on OFBIZ-4342: ---------------------------------------- Bump... > Ajax callings in CheckoutProcess.js are not handling server-side errors correctly > --------------------------------------------------------------------------------- > > Key: OFBIZ-4342 > URL: https://issues.apache.org/jira/browse/OFBIZ-4342 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jonatan Soto > Assignee: Sascha Rodekamp > Labels: ajax, checkout > Attachments: patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4342. ---------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Thanks Jonatan your patch is in Trunk @Rev1179340 I merged your patch manually. > Ajax callings in CheckoutProcess.js are not handling server-side errors correctly > --------------------------------------------------------------------------------- > > Key: OFBIZ-4342 > URL: https://issues.apache.org/jira/browse/OFBIZ-4342 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Jonatan Soto > Assignee: Sascha Rodekamp > Labels: ajax, checkout > Fix For: SVN trunk > > Attachments: patch.txt > > Original Estimate: 2h > Remaining Estimate: 2h > > All methods that do ajax calls in CheckoutProcess.js are not dealing with the server-side errors. They should be treated in the success callback using an existing method called getServerError(data). This method looks for the _ERROR_MESSAGE* keys of the JSON object returned by the server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |