[jira] [Created] (OFBIZ-4343) Promotion of inputParamEnumId as PPIP_ORST_YEAR is not working

[Nicolas Malin (Jira)]

Promotion of inputParamEnumId as PPIP_ORST_YEAR is not working
--------------------------------------------------------------

                 Key: OFBIZ-4343
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4343
             Project: OFBiz
          Issue Type: Bug
          Components: order
            Reporter: Rishi Solanki
             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk


When user tries to apply the specified promotion then following problem occurs;
1) Promotion is not applying for the customer, that means customer do not get the discount even if any promotion of such kind exists for the user.
1.1) To fix the above will need to add group-by clause to 2 more fields orderTypeId and statusId of view entity OrderHeaderAndRoleSummary as these fields do not have any values to check the condition, as group-by clause do not allow to show them if values are different.
2) After fixing the issue explained in #1, if user pass the other_value as 12 (month) and condVlaue as $ 1000.00, then after $ 1000 if user order history is of $ 900. Then it will pass the check and then user is allow to get discount on any number on the last order.
3) That means even if the limit is 1000 user is able to purchase in discount of 900 + 300 >> 1200 amount with complete discount. So before checking for the total amount on order history now system will check for "order history + cart sub total".


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rishi Solanki updated OFBIZ-4343:
---------------------------------

    Attachment: Promotion_for_year_total.patch

Here is the attached patch for the same.

> Promotion of inputParamEnumId as PPIP_ORST_YEAR is not working
> --------------------------------------------------------------
>
>                 Key: OFBIZ-4343
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4343
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Rishi Solanki
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: Promotion_for_year_total.patch
>
>
> When user tries to apply the specified promotion then following problem occurs;
> 1) Promotion is not applying for the customer, that means customer do not get the discount even if any promotion of such kind exists for the user.
> 1.1) To fix the above will need to add group-by clause to 2 more fields orderTypeId and statusId of view entity OrderHeaderAndRoleSummary as these fields do not have any values to check the condition, as group-by clause do not allow to show them if values are different.
> 2) After fixing the issue explained in #1, if user pass the other_value as 12 (month) and condVlaue as $ 1000.00, then after $ 1000 if user order history is of $ 900. Then it will pass the check and then user is allow to get discount on any number on the last order.
> 3) That means even if the limit is 1000 user is able to purchase in discount of 900 + 300 >> 1200 amount with complete discount. So before checking for the total amount on order history now system will check for "order history + cart sub total".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-4343:
------------------------------------------

    Assignee: Ashish Vijaywargiya

> Promotion of inputParamEnumId as PPIP_ORST_YEAR is not working
> --------------------------------------------------------------
>
>                 Key: OFBIZ-4343
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4343
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Rishi Solanki
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: Promotion_for_year_total.patch
>
>
> When user tries to apply the specified promotion then following problem occurs;
> 1) Promotion is not applying for the customer, that means customer do not get the discount even if any promotion of such kind exists for the user.
> 1.1) To fix the above will need to add group-by clause to 2 more fields orderTypeId and statusId of view entity OrderHeaderAndRoleSummary as these fields do not have any values to check the condition, as group-by clause do not allow to show them if values are different.
> 2) After fixing the issue explained in #1, if user pass the other_value as 12 (month) and condVlaue as $ 1000.00, then after $ 1000 if user order history is of $ 900. Then it will pass the check and then user is allow to get discount on any number on the last order.
> 3) That means even if the limit is 1000 user is able to purchase in discount of 900 + 300 >> 1200 amount with complete discount. So before checking for the total amount on order history now system will check for "order history + cart sub total".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069469#comment-13069469 ]

Brajesh Patel commented on OFBIZ-4343:
--------------------------------------

Thanks Ashish for pushing these changes in the SVN.

> Promotion of inputParamEnumId as PPIP_ORST_YEAR is not working
> --------------------------------------------------------------
>
>                 Key: OFBIZ-4343
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4343
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Rishi Solanki
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: Promotion_for_year_total.patch
>
>
> When user tries to apply the specified promotion then following problem occurs;
> 1) Promotion is not applying for the customer, that means customer do not get the discount even if any promotion of such kind exists for the user.
> 1.1) To fix the above will need to add group-by clause to 2 more fields orderTypeId and statusId of view entity OrderHeaderAndRoleSummary as these fields do not have any values to check the condition, as group-by clause do not allow to show them if values are different.
> 2) After fixing the issue explained in #1, if user pass the other_value as 12 (month) and condVlaue as $ 1000.00, then after $ 1000 if user order history is of $ 900. Then it will pass the check and then user is allow to get discount on any number on the last order.
> 3) That means even if the limit is 1000 user is able to purchase in discount of 900 + 300 >> 1200 amount with complete discount. So before checking for the total amount on order history now system will check for "order history + cart sub total".

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-4343.
------------------------------------

   

> Promotion of inputParamEnumId as PPIP_ORST_YEAR is not working
> --------------------------------------------------------------
>
>                 Key: OFBIZ-4343
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4343
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>            Reporter: Rishi Solanki
>            Assignee: Ashish Vijaywargiya
>             Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: Promotion_for_year_total.patch
>
>
> When user tries to apply the specified promotion then following problem occurs;
> 1) Promotion is not applying for the customer, that means customer do not get the discount even if any promotion of such kind exists for the user.
> 1.1) To fix the above will need to add group-by clause to 2 more fields orderTypeId and statusId of view entity OrderHeaderAndRoleSummary as these fields do not have any values to check the condition, as group-by clause do not allow to show them if values are different.
> 2) After fixing the issue explained in #1, if user pass the other_value as 12 (month) and condVlaue as $ 1000.00, then after $ 1000 if user order history is of $ 900. Then it will pass the check and then user is allow to get discount on any number on the last order.
> 3) That means even if the limit is 1000 user is able to purchase in discount of 900 + 300 >> 1200 amount with complete discount. So before checking for the total amount on order history now system will check for "order history + cart sub total".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira