[jira] [Created] (OFBIZ-4368) incorrect url of root webapp in menu

[Nicolas Malin (Jira)]

incorrect url of root webapp in menu
------------------------------------

                 Key: OFBIZ-4368
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4368
             Project: OFBiz
          Issue Type: Bug
          Components: themes
    Affects Versions: SVN trunk
            Reporter: Leon
            Priority: Minor
             Fix For: Release Branch 11.04, SVN trunk


If I enable the "app-bar-display" for root webapp which is mounted to "/", the url of root webapp in menu is "https://control/main" and not the correct "https://localhost:8443/".

That's because, e.g. in themes/tomahawk/includes/appbarOpen.ftl, it uses sentence <#if thisApp != "/"> to judge whether the app is root or not, while the variable thisApp is java String and it'll be encoded as iso code "&#47;", so the "if" sentence mentioned above will always return false.

In the patch it use StringUtil.wrapString to wrap variable theApp to avoid encode.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leon updated OFBIZ-4368:
------------------------

    Attachment: rootWebAppMenuUrl.patch

> incorrect url of root webapp in menu
> ------------------------------------
>
>                 Key: OFBIZ-4368
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4368
>             Project: OFBiz
>          Issue Type: Bug
>          Components: themes
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk
>
>         Attachments: rootWebAppMenuUrl.patch
>
>
> If I enable the "app-bar-display" for root webapp which is mounted to "/", the url of root webapp in menu is "https://control/main" and not the correct "https://localhost:8443/".
> That's because, e.g. in themes/tomahawk/includes/appbarOpen.ftl, it uses sentence <#if thisApp != "/"> to judge whether the app is root or not, while the variable thisApp is java String and it'll be encoded as iso code "&#47;", so the "if" sentence mentioned above will always return false.
> In the patch it use StringUtil.wrapString to wrap variable theApp to avoid encode.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4368.
----------------------------------

    Resolution: Fixed
      Assignee: Jacques Le Roux

Thanks Leon,

Your patch is in
trunk at r 1158124
r11.04 at r1158125

Please, just remember when using Eclipse internal command to not use finish but rather select project to avoid the 2 1st lines in the patch, see [How to Send in Your Contributions (or how to create and apply patches)|https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)]. Else the patch will only apply in Eclipse if the project name is the same

> incorrect url of root webapp in menu
> ------------------------------------
>
>                 Key: OFBIZ-4368
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4368
>             Project: OFBiz
>          Issue Type: Bug
>          Components: themes
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk
>
>         Attachments: rootWebAppMenuUrl.patch
>
>
> If I enable the "app-bar-display" for root webapp which is mounted to "/", the url of root webapp in menu is "https://control/main" and not the correct "https://localhost:8443/".
> That's because, e.g. in themes/tomahawk/includes/appbarOpen.ftl, it uses sentence <#if thisApp != "/"> to judge whether the app is root or not, while the variable thisApp is java String and it'll be encoded as iso code "&#47;", so the "if" sentence mentioned above will always return false.
> In the patch it use StringUtil.wrapString to wrap variable theApp to avoid encode.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira