[jira] [Created] (OFBIZ-4370) Support Notes on Quotes

[Nicolas Malin (Jira)]

Support Notes on Quotes
-----------------------

                 Key: OFBIZ-4370
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
             Project: OFBiz
          Issue Type: New Feature
          Components: order
    Affects Versions: SVN trunk
         Environment: REV 1152668
            Reporter: Anne Jessel
            Priority: Minor


Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anne Jessel updated OFBIZ-4370:
-------------------------------

    Attachment: OFBIZ-4370_QuoteNotes.patch

Patch is in git format. Hope this is okay. If not, let me know and I'll redo it.

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086889#comment-13086889 ]

Adrian Crum commented on OFBIZ-4370:
------------------------------------

Anne,

The patch is a good start, but it needs some work:

1. It looks like some of the UI labels were copied from another file. It would be better to reuse the existing UI labels instead of creating duplicates.
2. Try to use screen widgets instead of Freemarker templates.
3. Try to use entity-auto services instead of Java.

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086904#comment-13086904 ]

Anne Jessel commented on OFBIZ-4370:
------------------------------------

Thanks for the feedback, Adrian.

I would normally have used screen widgets instead of freemarker, but in this case much of the code was copied from Orders and "Order" replaced with "Quote". I'll update as you suggest.

Would it be worthwhile me updating some of the existing Orders code as well while I'm at it? I'm thinking in particular of replacing webapp/ordermgr/order/newnote.ftl with a screen widget.  

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086907#comment-13086907 ]

Adrian Crum commented on OFBIZ-4370:
------------------------------------

Anne,

Converting other Freemarker templates to widgets would be great improvement to the project! Please put them in another Jira issue though.

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087220#comment-13087220 ]

Jacques Le Roux commented on OFBIZ-4370:
----------------------------------------

+1, thanks Anne! (and Adrian for advice)

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anne Jessel updated OFBIZ-4370:
-------------------------------

    Attachment: OFBIZ-4370_QuoteNotes.patch

Updated patch. It no longer copies style used with notes for orders. Main changes:

- no freemarker
- new service createQuoteNote is now minilang
- less new labels

My limited understanding of entity-auto services suggests it can't be used for createQuoteNote, which creates two entities.

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-4370:
----------------------------------

    Assignee: Adrian Crum

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088258#comment-13088258 ]

Adrian Crum commented on OFBIZ-4370:
------------------------------------

Anne,

I am unable to apply your patch in git format. Could you supply a patch in svn format please?

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anne Jessel updated OFBIZ-4370:
-------------------------------

    Attachment: OFBIZ-4370_QuoteNotes.patch

Updated patch, svn format.

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-4370.
------------------------------

    Resolution: Fixed

Patch committed, rev 1160402. Thanks Anne!

> Support Notes on Quotes
> -----------------------
>
>                 Key: OFBIZ-4370
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4370
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: REV 1152668
>            Reporter: Anne Jessel
>            Assignee: Adrian Crum
>            Priority: Minor
>         Attachments: OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch, OFBIZ-4370_QuoteNotes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Attaching a patch which allows the user to add notes to Quotes. It is based on the similar feature already implemented for notes on Orders and Parties.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira