OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4390) Ecommerce Error Page Does Not Work

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

11 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4390) Ecommerce Error Page Does Not Work

Ecommerce Error Page Does Not Work
----------------------------------

Key: OFBIZ-4390
URL: https://issues.apache.org/jira/browse/OFBIZ-4390
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Reporter: Sam Hamilton
Priority: Minor
Attachments: OFBIZ-4390-error.txt

If you are using the ecommerce app and you force it to generate a 404 error page it defaults to the tomcat error page rather than using what I think it should be using - /error/error.jsp?

You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/error/
The expected error page code is here https://github.com/apache/ofbiz/blob/trunk/specialpurpose/ecommerce/webapp/ecommerce/error/error.jsp

As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors
<error-page>
<error-code>404</error-code>
<location>/error/error.jsp</location>
</error-page>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4390) Ecommerce Error Page Does Not Work

> Ecommerce Error Page Does Not Work
> ----------------------------------
>
> Key: OFBIZ-4390
> URL: https://issues.apache.org/jira/browse/OFBIZ-4390
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Sam Hamilton
> Priority: Minor
> Attachments: OFBIZ-4390-error.txt
>
>
> If you are using the ecommerce app and you force it to generate a 404 error page it defaults to the tomcat error page rather than using what I think it should be using - /error/error.jsp?
> You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/error/
> The expected error page code is here https://github.com/apache/ofbiz/blob/trunk/specialpurpose/ecommerce/webapp/ecommerce/error/error.jsp
> As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors
> <error-page>
> <error-code>404</error-code>
> <location>/error/error.jsp</location>
> </error-page>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095767#comment-13095767 ]

BJ Freeman commented on OFBIZ-4390:
-----------------------------------

this only happens with /error
try http://demo-trunk.ofbiz.apache.org/ecommerce/happy and you get a redirect to /control/main

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095769#comment-13095769 ]

BJ Freeman commented on OFBIZ-4390:
-----------------------------------

this is do to the fact that allowed paths
<filter-class>org.ofbiz.webapp.control.ContextFilter</filter-class>
<init-param>
<param-name>disableContextSecurity</param-name>
<param-value>N</param-value>
</init-param>
<init-param>
<param-name>allowedPaths</param-name>
<param-value>/error:/control:/products:/select:/index.html:/index.jsp:/default.html:/default.jsp:/images</param-value>
</init-param>
<init-param>
<param-name>errorCode</param-name>
<param-value>403</param-value>
</init-param>
<init-param>
<param-name>redirectPath</param-name>
<param-value>/control/main</param-value>
</init-param>
</filter>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097725#comment-13097725 ]

Sam Hamilton commented on OFBIZ-4390:
-------------------------------------

Thanks BJ - it all makes sense now.

What I have done in the patch is edited the web.xml file to remove the automatic redirection because search engines really like to get a 404 error when there is no file at that location and also to allow custom error pages to be included in the ecommerce site so that you can track 404 errors in the analytics package of your choosing - e.g. http://www.google.com/support/analytics/bin/answer.py?answer=86927 if you use Google Analytics.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

> Ecommerce Error Page Does Not Work
> ----------------------------------
>
> Key: OFBIZ-4390
> URL: https://issues.apache.org/jira/browse/OFBIZ-4390
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Sam Hamilton
> Priority: Minor
> Attachments: OFBIZ-4390-error.txt, OFBIZ-4390.patch
>
>
> If you are using the ecommerce app and you force it to generate a 404 error page it defaults to the tomcat error page rather than using what I think it should be using - /error/error.jsp?
> You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/error/
> The expected error page code is here https://github.com/apache/ofbiz/blob/trunk/specialpurpose/ecommerce/webapp/ecommerce/error/error.jsp
> As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors
> <error-page>
> <error-code>404</error-code>
> <location>/error/error.jsp</location>
> </error-page>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Hamilton updated OFBIZ-4390:
--------------------------------

Description:
If you are using the ecommerce app and you force it to generate a 404 error page it redirects back to /control/main.
You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/please-give-me-an-error/
This default behaviour will confuse search engines as they expect to get a 404 error if a pages does not exist on a website.

As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors due to the redirect to /control/main is in place.
<error-page>
<error-code>404</error-code>
<location>/error/error.jsp</location>
</error-page>

was:
If you are using the ecommerce app and you force it to generate a 404 error page it defaults to the tomcat error page rather than using what I think it should be using - /error/error.jsp?

You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/error/
The expected error page code is here https://github.com/apache/ofbiz/blob/trunk/specialpurpose/ecommerce/webapp/ecommerce/error/error.jsp

As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors
<error-page>
<error-code>404</error-code>
<location>/error/error.jsp</location>
</error-page>

> Ecommerce Error Page Does Not Work
> ----------------------------------
>
> Key: OFBIZ-4390
> URL: https://issues.apache.org/jira/browse/OFBIZ-4390
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Sam Hamilton
> Priority: Minor
> Attachments: OFBIZ-4390-error.txt, OFBIZ-4390.patch
>
>
> If you are using the ecommerce app and you force it to generate a 404 error page it redirects back to /control/main.
> You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/please-give-me-an-error/
> This default behaviour will confuse search engines as they expect to get a 404 error if a pages does not exist on a website.
> As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors due to the redirect to /control/main is in place.
> <error-page>
> <error-code>404</error-code>
> <location>/error/error.jsp</location>
> </error-page>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161956#comment-13161956 ]

mz4wheeler commented on OFBIZ-4390:
-----------------------------------

Can this be back ported to 11.04 as well?

> Ecommerce Error Page Does Not Work
> ----------------------------------
>
> Key: OFBIZ-4390
> URL: https://issues.apache.org/jira/browse/OFBIZ-4390
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Sam Hamilton
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4390-error.txt, OFBIZ-4390.patch
>
>
> If you are using the ecommerce app and you force it to generate a 404 error page it redirects back to /control/main.
> You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/please-give-me-an-error/
> This default behaviour will confuse search engines as they expect to get a 404 error if a pages does not exist on a website.
> As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors due to the redirect to /control/main is in place.
> <error-page>
> <error-code>404</error-code>
> <location>/error/error.jsp</location>
> </error-page>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4390.
----------------------------------

Backportef to R11.04 at r1209911

> Ecommerce Error Page Does Not Work
> ----------------------------------
>
> Key: OFBIZ-4390
> URL: https://issues.apache.org/jira/browse/OFBIZ-4390
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Sam Hamilton
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4390-error.txt, OFBIZ-4390.patch
>
>
> If you are using the ecommerce app and you force it to generate a 404 error page it redirects back to /control/main.
> You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/please-give-me-an-error/
> This default behaviour will confuse search engines as they expect to get a 404 error if a pages does not exist on a website.
> As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors due to the redirect to /control/main is in place.
> <error-page>
> <error-code>404</error-code>
> <location>/error/error.jsp</location>
> </error-page>

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162213#comment-13162213 ]

mz4wheeler commented on OFBIZ-4390:
-----------------------------------

Thanks Jacques. Here is what I found. It doesn't always work, even for trunk:

http://demo-trunk.ofbiz.apache.org/ecommerce/product/ (works)
http://demo-trunk.ofbiz.apache.org/ecommerce/products/ (java.lang.NullPointerException)

SEO-friendly URL (with error)
http://demo-trunk.ofbiz.apache.org/ecommerce/dropship1-dropShip1-p-ERR (works)

However, if you access the products (or a Bot) using the NON-SEO friendly URL:

http://demo-trunk.ofbiz.apache.org/ecommerce/products/dropShip/dropShip1 (NON-SEO)

NOTE: This URL is MOST likely present in Google and other search engines.

http://demo-trunk.ofbiz.apache.org/ecommerce/products/dropShip/dropShip1-err

Doesn't work: Says catalog not found, but the logs show http status 200.

This is worse on 11.04, because it doesn't have the recent SEO-friendly changes recently made to trunk

This is still a problem for trunk, because search engines will most likely have the OLD URL scheme, and will still get http status 200.

> Ecommerce Error Page Does Not Work
> ----------------------------------
>
> Key: OFBIZ-4390
> URL: https://issues.apache.org/jira/browse/OFBIZ-4390
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Sam Hamilton
> Assignee: Hans Bakker
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4390-error.txt, OFBIZ-4390.patch
>
>
> If you are using the ecommerce app and you force it to generate a 404 error page it redirects back to /control/main.
> You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/please-give-me-an-error/
> This default behaviour will confuse search engines as they expect to get a 404 error if a pages does not exist on a website.
> As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors due to the redirect to /control/main is in place.
> <error-page>
> <error-code>404</error-code>
> <location>/error/error.jsp</location>
> </error-page>

Nicolas Malin (Jira)

[jira] [Reopened] (OFBIZ-4390) Ecommerce Error Page Does Not Work

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-4390:
------------------------------------

Assignee: Jacques Le Roux (was: Hans Bakker)

Still some issues here it seems...

> Ecommerce Error Page Does Not Work
> ----------------------------------
>
> Key: OFBIZ-4390
> URL: https://issues.apache.org/jira/browse/OFBIZ-4390
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Reporter: Sam Hamilton
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4390-error.txt, OFBIZ-4390.patch
>
>
> If you are using the ecommerce app and you force it to generate a 404 error page it redirects back to /control/main.
> You can test the 404 error out here - http://demo-trunk.ofbiz.apache.org/ecommerce/please-give-me-an-error/
> This default behaviour will confuse search engines as they expect to get a 404 error if a pages does not exist on a website.
> As pointed out by Bilgin on the mailing list adding the following code into web.xml should resolve the problem however it just generates more errors due to the redirect to /control/main is in place.
> <error-page>
> <error-code>404</error-code>
> <location>/error/error.jsp</location>
> </error-page>