[jira] [Created] (OFBIZ-4393) View entity condition-expr doesn't handle null
Locked
12
12
[jira] [Created] (OFBIZ-4393) View entity condition-expr doesn't handle null
 
|
View entity condition-expr doesn't handle null
---------------------------------------------- Key: OFBIZ-4393 URL: https://issues.apache.org/jira/browse/OFBIZ-4393 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Rev 1165137 Reporter: Anne Jessel condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4393: ------------------------------- Attachment: OFBIZ-4393-view-entity_condition-expr_null.patch This patch replaces relevant tests for null with UtilValidate.is(Not)Empty. IMPORTANT: if any code relies on a missing value attribute being converted to an empty string that is then used, then this patch will break that. I did look, and couldn't find any such code OOTB. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096982#comment-13096982 ] Hans Bakker commented on OFBIZ-4393: ------------------------------------ isn't the value 'null' or 'nullValue' do this? > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096984#comment-13096984 ] Anne Jessel commented on OFBIZ-4393: ------------------------------------ value="null" definitely doesn't work. It's what I tried first before looking at the code. Is that what should work? The current code compares value variable with null, but I can't see how value can ever be null, as it has the value returned by org.w3c.dom.Element.getAttribute, which doesn't return null. I can change patch so it looks for String "null" instead of using isEmpty. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096988#comment-13096988 ] Hans Bakker commented on OFBIZ-4393: ------------------------------------ i mentioned this, because this is working in minilanguage > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136879#comment-13136879 ] Leon commented on OFBIZ-4393: ----------------------------- It has been able to handle null before. According to original design (I guess), if ommit value and relFieldName attributes in condition-expr, then it will be looked as "null". Then, while the operator is "=" or "<>", the condition will be converted to "is null" and "is not null" respectively. See code pasted below: {code:java} } else if ( value == null && this.relFieldName == null && (this.operator == EntityOperator.EQUALS || this.operator == EntityOperator.NOT_EQUAL)) { return EntityCondition.makeCondition(lhs, this.operator, null); } else { {code} But donno from which revision, the input value of absent value and relFeidlName attributes were converted to empty string (""), not "null" itself, then, now, "view entity condition-expr doesn't handle null". > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137709#comment-13137709 ] Anne Jessel commented on OFBIZ-4393: ------------------------------------ The point is that the code quoted by Leon will never be executed, because 'value' will never be null. If value is absent in the xml, then it is read as an empty string. value is intialised using org.w3c.dom.Element.getAttribute() which never returns null, according to the documentation. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Assigned] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-4393: ---------------------------------- Assignee: Adrian Crum > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-4393: ------------------------------- Attachment: OFBIZ-4393-view-entity_condition-expr_null.patch Updated patch. I took a slightly different approach to solve the problem. This patch needs to be tested, then I will commit it. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137820#comment-13137820 ] Leon commented on OFBIZ-4393: ----------------------------- hi, Adrian, It's better to process "this.relFieldName" as so, since it's absent value is empty string not null either. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Issue Comment Edited] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137820#comment-13137820 ] Leon edited comment on OFBIZ-4393 at 10/28/11 10:27 AM: -------------------------------------------------------- hi, Adrian, It's better to process "this.relFieldName" as so, since it's absent value is empty string not null either. or you can ref OFBIZ-4523, I submited that case 2 days ago. was (Author: utcb): hi, Adrian, It's better to process "this.relFieldName" as so, since it's absent value is empty string not null either. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Assigned] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-4393: -------------------------------------- Assignee: Jacques Le Roux (was: Adrian Crum) > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Jacques Le Roux > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Assigned] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-4393: -------------------------------------- Assignee: Adrian Crum (was: Jacques Le Roux) Did not notice Adrian has already assigned to himself: I will simply review > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144945#comment-13144945 ] Jacques Le Roux commented on OFBIZ-4393: ---------------------------------------- Maybe we could rather follow Adrian's way on both _this.value_ and _this.relFieldName_ (ie put null if empty at start) and then revert r1195042. The idea behind is it's better to handle the issue at the root, in case some other cases pop up downstream. With a 1485 lines long file you never know... > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145185#comment-13145185 ] Anne Jessel commented on OFBIZ-4393: ------------------------------------ FWIW I prefer Adrian's way. My patch aimed for the minimum change needed to fix the identified and testable problem. I would have done it Adrian's way if I was confident there were no side effects. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145346#comment-13145346 ] Jacques Le Roux commented on OFBIZ-4393: ---------------------------------------- Anne, Since it's handled at root, I can't see any possible side effects. I will revert r1195042 and apply enhanced Adrian's patch > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145352#comment-13145352 ] Adrian Crum commented on OFBIZ-4393: ------------------------------------ It would be nice to have the patch tested to see if it solves the problem Anne encountered. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146659#comment-13146659 ] Anne Jessel commented on OFBIZ-4393: ------------------------------------ I would expect it to work, but will try it out to be sure. Won't be able to do so for a day or two, though. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147096#comment-13147096 ] Deepak Dixit commented on OFBIZ-4393: ------------------------------------- This is a bug, so this should be go in branches as well(10.04 and 11.04). I have tested it for release10.04 (did manual merge) and it works fine. > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4393) View entity condition-expr doesn't handle null
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anne Jessel updated OFBIZ-4393: ------------------------------- Attachment: OFBIZ-4393-view-entity_condition-expr_null.patch Updated patch based on Adrian's, that adds changes suggested by Leon based on OFBIZ-4523 > View entity condition-expr doesn't handle null > ---------------------------------------------- > > Key: OFBIZ-4393 > URL: https://issues.apache.org/jira/browse/OFBIZ-4393 > Project: OFBiz > Issue Type: Bug > Components: framework > Affects Versions: SVN trunk > Environment: Rev 1165137 > Reporter: Anne Jessel > Assignee: Adrian Crum > Attachments: OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch, OFBIZ-4393-view-entity_condition-expr_null.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > condition-expr tag in view-entity can't be used to compare a field with null. An absent value attribute is read as an empty string, and the code currently checks for value being null to know when to compare against null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |