[jira] [Created] (OFBIZ-4398) infinite recursive loop

[Nicolas Malin (Jira)]

infinite recursive loop
-----------------------

                 Key: OFBIZ-4398
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
             Project: OFBiz
          Issue Type: Bug
          Components: framework
            Reporter: Dimitri Unruh
         Attachments: ArtifactInfoBase.java.patch

The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-4398:
---------------------------------

    Attachment: ArtifactInfoBase.java.patch

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100421#comment-13100421 ]

Adrian Crum commented on OFBIZ-4398:
------------------------------------

Actually, the code could be simplified further to:

{code}
public boolean equals(Object obj) {
    return this == obj;
}
{code}

if there are no other tests for equality.

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-4398:
---------------------------------

    Attachment: ArtifactInfoBase.java.patch

Adrian,

yes, you are right. I provided a new patch

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-4398:
---------------------------------

    Attachment:     (was: ArtifactInfoBase.java.patch)

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-4398:
---------------------------------

    Attachment: ArtifactInfoBase.java.patch

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-4398:
---------------------------------

    Attachment:     (was: ArtifactInfoBase.java.patch)

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100615#comment-13100615 ]

Adrian Crum commented on OFBIZ-4398:
------------------------------------

Dimitri,

Thank you for the updated patch, but...

My previous comment mentioned "...if there are no other tests for equality." If you look at the implementation of Comparable.compareTo(T o) you will see a test for equality. The equals method should perform the same test.

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-4398:
---------------------------------

    Attachment: ArtifactInfoBase.java.patch

Adrian,

good point. I really missed the Comparable.compareTo(T o) method.
So hopefully the new patch will do it the right way :)

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch, ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dimitri Unruh updated OFBIZ-4398:
---------------------------------

    Attachment:     (was: ArtifactInfoBase.java.patch)

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum reassigned OFBIZ-4398:
----------------------------------

    Assignee: Adrian Crum

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>            Assignee: Adrian Crum
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian Crum closed OFBIZ-4398.
------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Fixed, rev 1167117. Thanks Dimitri!

> infinite recursive loop
> -----------------------
>
>                 Key: OFBIZ-4398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4398
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Dimitri Unruh
>            Assignee: Adrian Crum
>             Fix For: SVN trunk
>
>         Attachments: ArtifactInfoBase.java.patch
>
>
> The equals method in ArtifactInfoBase.java unconditionally invokes itself. This is an infinite recursive loop that will result in a stack overflow.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira