[jira] Created: (OFBIZ-443) purgeOldStoreAutoPromos removing wrong entity?

[Nicolas Malin (Jira)]

purgeOldStoreAutoPromos removing wrong entity?
----------------------------------------------

                 Key: OFBIZ-443
                 URL: http://issues.apache.org/jira/browse/OFBIZ-443
             Project: OFBiz (The Open for Business Project)
          Issue Type: Bug
          Components: product
            Reporter: Si Chen
            Priority: Minor


This one I could not figure out: the service purgeOldStoreAutoPromo says "purge Expired ProductStorePromoAppl Records..." but the actual code says:
                GenericValue productStorePromo = delegator.makeValue("ProductStorePromo", null);
                productStorePromo.setAllFields(productStorePromoAndAppl, true, null, null);
                productStorePromo.remove();

and there is no ProductStorePromo entity.  Is it just a typo?  Should it be ProductStorePromoAppl?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-443?page=comments#action_12453758 ]
           
Si Chen commented on OFBIZ-443:
-------------------------------

Hi everybody - should I just change it to ProductStorePromoAppl?  Any reasons why not?

> purgeOldStoreAutoPromos removing wrong entity?
> ----------------------------------------------
>
>                 Key: OFBIZ-443
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-443
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>            Priority: Minor
>
> This one I could not figure out: the service purgeOldStoreAutoPromo says "purge Expired ProductStorePromoAppl Records..." but the actual code says:
>                 GenericValue productStorePromo = delegator.makeValue("ProductStorePromo", null);
>                 productStorePromo.setAllFields(productStorePromoAndAppl, true, null, null);
>                 productStorePromo.remove();
> and there is no ProductStorePromo entity.  Is it just a typo?  Should it be ProductStorePromoAppl?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-443?page=all ]

Si Chen reassigned OFBIZ-443:
-----------------------------

    Assignee: Si Chen

> purgeOldStoreAutoPromos removing wrong entity?
> ----------------------------------------------
>
>                 Key: OFBIZ-443
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-443
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Assigned To: Si Chen
>            Priority: Minor
>
> This one I could not figure out: the service purgeOldStoreAutoPromo says "purge Expired ProductStorePromoAppl Records..." but the actual code says:
>                 GenericValue productStorePromo = delegator.makeValue("ProductStorePromo", null);
>                 productStorePromo.setAllFields(productStorePromoAndAppl, true, null, null);
>                 productStorePromo.remove();
> and there is no ProductStorePromo entity.  Is it just a typo?  Should it be ProductStorePromoAppl?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-443?page=comments#action_12453760 ]
           
David E. Jones commented on OFBIZ-443:
--------------------------------------

Sounds fine to me.

> purgeOldStoreAutoPromos removing wrong entity?
> ----------------------------------------------
>
>                 Key: OFBIZ-443
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-443
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Assigned To: Si Chen
>            Priority: Minor
>
> This one I could not figure out: the service purgeOldStoreAutoPromo says "purge Expired ProductStorePromoAppl Records..." but the actual code says:
>                 GenericValue productStorePromo = delegator.makeValue("ProductStorePromo", null);
>                 productStorePromo.setAllFields(productStorePromoAndAppl, true, null, null);
>                 productStorePromo.remove();
> and there is no ProductStorePromo entity.  Is it just a typo?  Should it be ProductStorePromoAppl?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Si Chen closed OFBIZ-443.
-------------------------

    Resolution: Fixed

> purgeOldStoreAutoPromos removing wrong entity?
> ----------------------------------------------
>
>                 Key: OFBIZ-443
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-443
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: product
>            Reporter: Si Chen
>         Assigned To: Si Chen
>            Priority: Minor
>
> This one I could not figure out: the service purgeOldStoreAutoPromo says "purge Expired ProductStorePromoAppl Records..." but the actual code says:
>                 GenericValue productStorePromo = delegator.makeValue("ProductStorePromo", null);
>                 productStorePromo.setAllFields(productStorePromoAndAppl, true, null, null);
>                 productStorePromo.remove();
> and there is no ProductStorePromo entity.  Is it just a typo?  Should it be ProductStorePromoAppl?

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira