[jira] [Created] (OFBIZ-4433) product.groovy improved

[Nicolas Malin (Jira)]

product.groovy improved
-----------------------

                 Key: OFBIZ-4433
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
             Project: OFBiz
          Issue Type: Improvement
            Reporter: Christian Fischer
         Attachments: Product.groovy.patch

Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Fischer updated OFBIZ-4433:
-------------------------------------

    Attachment: Product.groovy.patch

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107709#comment-13107709 ]

Adrian Crum commented on OFBIZ-4433:
------------------------------------

Why is this change needed? And why is the issue marked as Resolved?

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107714#comment-13107714 ]

Christian Fischer commented on OFBIZ-4433:
------------------------------------------

If you take the name frome the entity, you aren't able to take the localized names. This patch is useful, if you have different names for products in different languages.

To the Resolved-mark: I think, I interpreted it wrong. I thought,Resolved means, that its fixed and ready to be tested. Sorry for that, won't happen again.

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107716#comment-13107716 ]

Adrian Crum commented on OFBIZ-4433:
------------------------------------

You can localize entity fields by using the UI labels files. There are examples of this in code already.

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107722#comment-13107722 ]

Christian Fischer commented on OFBIZ-4433:
------------------------------------------

In this Patch we get a productName from Content. I dont think it is usefull to get individual ProductData from EntityLabels.

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107732#comment-13107732 ]

Jacques Le Roux commented on OFBIZ-4433:
----------------------------------------

Aboutthe Resolved status: if you provide a patch you should rather use "Patch provided" status

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-4433:
------------------------------------

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107732#comment-13107732 ]

Jacques Le Roux edited comment on OFBIZ-4433 at 9/19/11 10:28 AM:
------------------------------------------------------------------

Aboutthe Resolved status: if you provide a patch you should rather use "Patch provided" status

Edit I meaned "Patch available"

      was (Author: jacques.le.roux):
    Aboutthe Resolved status: if you provide a patch you should rather use "Patch provided" status
 

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114203#comment-13114203 ]

Jacques Le Roux commented on OFBIZ-4433:
----------------------------------------

Christian,

Please don't use tabs in your patches.

I think we should test if there is a value in contentWrapper.get("PRODUCT_NAME") before, like in

            if (contentWrapper.get("PRODUCT_NAME")) keywords.add(contentWrapper.get("PRODUCT_NAME"));
            else keywords.add(product.productName);

> product.groovy improved
> -----------------------
>
>                 Key: OFBIZ-4433
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4433
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Christian Fischer
>         Attachments: Product.groovy.patch
>
>
> Productname now comes from the content instead of the entity,

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira