[jira] Created: (OFBIZ-444) add a while-compare operation to minilang

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[jira] Created: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
add a while-compare operation to minilang
-----------------------------------------

                 Key: OFBIZ-444
                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Scott Gray
            Priority: Minor


Hi All

I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag

Regards
Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=all ]

Scott Gray updated OFBIZ-444:
-----------------------------

    Attachment: while-compare.patch

I've basically copied the if-compare code, wrapped it in a loop, removed the <else> tag code.  I've grouped it with the otherops grouping as I wasn't sure of the proper place for it, but that's easy to change if need be.

Regards
Scott

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>            Priority: Minor
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Closed: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=all ]

Jacques Le Roux closed OFBIZ-444.
---------------------------------

    Fix Version/s: SVN trunk
       Resolution: Fixed
         Assignee: Jacques Le Roux

Scott,

Your patch is in OFbiz rev 473334

I did some minor formatting and changed from OtherOperations to ControlOperations.
I tested replacing the loop in ShipmentReceiptServices.xml and it worked well.
I also updated http://www.ofbiz.org/dtds/simple-methods.xsd but I don't know if it's sufficient for XML Buddy (or whatever else XML parser) because it always complains about while-compare not being an op (I guess I'lm surely missing somehting here).

Remark for commiters : BTW I saw that there are always some deprecated env ops in http://www.ofbiz.org/dtds/simple-methods.xsd. Is that wanted or may I remove them ? Personnaly I believe that removing them will help untill we update the main minilang documentation...

Thanks

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448742 ]
           
Chris Howe commented on OFBIZ-444:
----------------------------------

I think eclipse shows errors because http://www.ofbiz.org/dtds/simple-methods.xsd is a valid location now.  The file on the apache server needs to be updated

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448793 ]
           
Jacques Le Roux commented on OFBIZ-444:
---------------------------------------

Thanks Chris,

You are right, it's the http://www.ofbiz.org/dtds/simple-methods.xsd that needs to be uptaded. I had already updated the site but forgot that it is on Apache server now (recent vacation surely ;o)

BTW commiters, there are 109 files in the same case, should I update all of them ?



> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448836 ]
           
Scott Gray commented on OFBIZ-444:
----------------------------------

Thanks Jacques, I appreciate your help

Regards
Scott

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448853 ]
           
David E. Jones commented on OFBIZ-444:
--------------------------------------

I just sent a message to the private ofbiz list about a larger issue related to this, so I'm adding relevant comments here.

I'm not sure I like this design... I'd rather see a more generic "while" operation that would be like the "if" operation. A while-compare is okay, but more like the if-compare and related operations which are limited in use and really mainly exist for legacy reasons. They have not been removed because even though something better is now available, they aren't really causing any problems (like the field-to-field, field-to-env, and related operations were, which is why it became a priority to remove them).

I don't have time to look at this more right now, so I'd appreciate some feedback on this. My proposal would be to remove this while-compare operation and add the more general while operation.

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448854 ]
           
David E. Jones commented on OFBIZ-444:
--------------------------------------

I forgot to mention in the last comment: another reason to address this ASAP is that once something gets into the simple-methods and is used, it is difficult and annoying to remove.

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448862 ]
           
Scott Gray commented on OFBIZ-444:
----------------------------------

Hi David

It's fine by me if the patch is reverted, I'll have a look at the <if> tag and work on a <while> tag over the weekend.  I did request comments on the mailing list and sometimes it is difficult to discern whether silence is acceptance or just plain silence, but no big deal as minilang is fun to work with anyway.

Regards
Scott

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448868 ]
           
David E. Jones commented on OFBIZ-444:
--------------------------------------

Scott,

I appreciate your understanding and continued interest in this. With the training this week, client work in the evenings (and a bit of Apache stuff here and there), and now some family stuff this weekend my time has been a little bit limited. I was hoping to review and work on this over the weekend but Jacques beat me to it (which in many cases would be good or great, but yes, I think this is one that could benefit from more discussion and review before something is added).

I like the idea of a more general while operation, so unless there are objections to it I'd say definitely go for it and I'll be happy to work with you on getting it reviewed and in.

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Assigned: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=all ]

David E. Jones reassigned OFBIZ-444:
------------------------------------

    Assignee: David E. Jones  (was: Jacques Le Roux)

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

Re: [jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Scott Gray
In reply to this post by Nicolas Malin (Jira)
Something that comes to mind from this is that it would be great if the
commiters were to create more jira issues themselves.  I'm guessing
there are loads of things they would like to see improved and it would
give newer contributors like myself a clearer direction on what we can
work on that will increase our experience and at the same time help move
the project forward.

Regards
Scott

David E. Jones (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448853 ]
>            
> David E. Jones commented on OFBIZ-444:
> --------------------------------------
>
> I just sent a message to the private ofbiz list about a larger issue related to this, so I'm adding relevant comments here.
>
> I'm not sure I like this design... I'd rather see a more generic "while" operation that would be like the "if" operation. A while-compare is okay, but more like the if-compare and related operations which are limited in use and really mainly exist for legacy reasons. They have not been removed because even though something better is now available, they aren't really causing any problems (like the field-to-field, field-to-env, and related operations were, which is why it became a priority to remove them).
>
> I don't have time to look at this more right now, so I'd appreciate some feedback on this. My proposal would be to remove this while-compare operation and add the more general while operation.
>
>  
>> add a while-compare operation to minilang
>> -----------------------------------------
>>
>>                 Key: OFBIZ-444
>>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>>             Project: OFBiz (The Open for Business Project)
>>          Issue Type: Improvement
>>          Components: framework
>>    Affects Versions: SVN trunk
>>            Reporter: Scott Gray
>>         Assigned To: Jacques Le Roux
>>            Priority: Minor
>>             Fix For: SVN trunk
>>
>>         Attachments: while-compare.patch
>>
>>
>> Hi All
>> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
>> Regards
>> Scott
>>    
>
>  

Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12448883 ]
           
Jacques Le Roux commented on OFBIZ-444:
---------------------------------------

David,

As I already explained on private list I will be happy to help too. Thanks for you help Scott.

Jacques

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Reopened: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=all ]

Jacopo Cappellato reopened OFBIZ-444:
-------------------------------------

             

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=all ]

Scott Gray updated OFBIZ-444:
-----------------------------

    Attachment: while.patch

Ok here's a new patch that contains the while loop, once again I've basically just copied if operation and made some small changes.  I also kept the groupings the same as the if operation, so they may need to be changed to whatever is suitable.

I've also removed the while-compare stuff in the patch

Regards
Scott

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12449106 ]
           
Jacques Le Roux commented on OFBIZ-444:
---------------------------------------

Scott,

Did you test it ? I'd appreciate an example of your test in ShipmentReceiptServices.xml for instance, in place of the loop op...

Thanks

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12449109 ]
           
David E. Jones commented on OFBIZ-444:
--------------------------------------

Thanks Scott, I'll take a look at it.

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: while-compare.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Updated: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
     [ http://issues.apache.org/jira/browse/OFBIZ-444?page=all ]

Scott Gray updated OFBIZ-444:
-----------------------------

    Attachment: test.patch

Hi Jacques, David

I did test the patch, but I just threw a simple event on the product app controller main uri.  I've attached the test patch if you want to try it out.  Sorry I don't have time to try it on ShipmentReceiptServices.xml as it's Sunday night here and I'm due for some sleep :-)

Thank you both for your help

Regards
Scott

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: test.patch, while-compare.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12449122 ]
           
Jacques Le Roux commented on OFBIZ-444:
---------------------------------------

Thanks a lot Scott,

I'm not sure the syntax will please David but yes it works well !

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: test.patch, while-compare.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
Reply | Threaded
Open this post in threaded view
|

[jira] Commented: (OFBIZ-444) add a while-compare operation to minilang

Nicolas Malin (Jira)
In reply to this post by Nicolas Malin (Jira)
    [ http://issues.apache.org/jira/browse/OFBIZ-444?page=comments#action_12449123 ]
           
Jacques Le Roux commented on OFBIZ-444:
---------------------------------------

A last point : when you want to delete a file don't suppress its lines but delete the whole file (as it's the case for WhileCompare.java here)

> add a while-compare operation to minilang
> -----------------------------------------
>
>                 Key: OFBIZ-444
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-444
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Scott Gray
>         Assigned To: David E. Jones
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: test.patch, while-compare.patch, while.patch
>
>
> Hi All
> I've added a while-compare operation to minilang which a mirrors java 'while' loop using the same condition definition as the if-compare tag
> Regards
> Scott

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
12