[jira] [Created] (OFBIZ-4441) UtilXml firstChildElement should use getNodeName instead of getLocalName

[Nicolas Malin (Jira)]

UtilXml firstChildElement should use getNodeName instead of getLocalName
------------------------------------------------------------------------

                 Key: OFBIZ-4441
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
             Project: OFBiz
          Issue Type: Bug
          Components: framework
            Reporter: Kiran Gawde
            Priority: Minor


Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Gawde updated OFBIZ-4441:
-------------------------------

    Attachment: OFBIZ-4441-UtilXml.patch

Renamed getLocalName to getNodeName in two places.

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112444#comment-13112444 ]

Sascha Rodekamp commented on OFBIZ-4441:
----------------------------------------

Hi Kiran,
i also don't understand why this two places uses getLocalName(). Just to clarify, getLocalName returns null when the Element is created while the schema namespace
processing is turned off.

So i think using getNodeName should work more reliable in this place.

I found a few other places where getLocalName could be replaced with getNodeName could you confirm?

Any opinions?

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp updated OFBIZ-4441:
-----------------------------------

    Attachment: OFBIZ-4441_XmlElementGetNodeName.patch

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113122#comment-13113122 ]

Kiran Gawde commented on OFBIZ-4441:
------------------------------------

Hello Igor,

Since you discovered this issue, any comments?

Regards,
Kiran Gawde

Senior Software Architect
Object Edge Inc
[phone] x108

"There are two kind of people: Those who do the work and those who take
the credit. Try to be in the first group because there is less competition
there."
"Never give up on what you really want to do. The person with big dreams
is more powerful than one with all the facts".

----- Forwarded by Kiran V Gawde/Object Edge on 09/22/2011 07:56 PM -----

From:   "Sascha Rodekamp (JIRA)" <[hidden email]>
To:     [hidden email]
Date:   09/22/2011 02:43 AM
Subject:        [jira] [Commented] (OFBIZ-4441) UtilXml firstChildElement
should use getNodeName instead of getLocalName




    [
https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112444#comment-13112444 
]

Sascha Rodekamp commented on OFBIZ-4441:
----------------------------------------

Hi Kiran,
i also don't understand why this two places uses getLocalName(). Just to
clarify, getLocalName returns null when the Element is created while the
schema namespace
processing is turned off.

So i think using getNodeName should work more reliable in this place.

I found a few other places where getLocalName could be replaced with
getNodeName could you confirm?

Any opinions?

OFBIZ-4441_XmlElementGetNodeName.patch
places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113302#comment-13113302 ]

[hidden email] commented on OFBIZ-4441:
--------------------------------------------

Makes sense to me. Hard to believe such a simple scenario has not happen to anyone though.

-----Kiran V Gawde/Object Edge wrote: -----To: Igor Abramovich/Object Edge
From: Kiran V Gawde/Object Edge
Date: 09/22/2011 11:01PM
Cc: "Sascha Rodekamp (JIRA)" <[hidden email]>
Subject: Fw: [jira] [Commented] (OFBIZ-4441) UtilXml firstChildElement should use getNodeName instead of getLocalName

Hello Igor,

Since you discovered this issue, any comments?


Regards,
Kiran Gawde

Senior Software Architect
Object Edge Inc
[phone] x108

"There are two kind of people: Those who do the work and those who take the credit. Try to be in the first group because there is less competition there."
"Never give up on what you really want to do. The person with big dreams is more powerful than one with all the facts".
----- Forwarded by Kiran V Gawde/Object Edge on 09/22/2011 07:56 PM -----

From: "Sascha Rodekamp (JIRA)" <[hidden email]>
To: [hidden email]
Date: 09/22/2011 02:43 AM
Subject: [jira] [Commented] (OFBIZ-4441) UtilXml firstChildElement should use getNodeName instead of getLocalName




   [ [1]https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112444#comment-13112444 ]

Sascha Rodekamp commented on OFBIZ-4441:
----------------------------------------

Hi Kiran,
i also don't understand why this two places uses getLocalName(). Just to clarify, getLocalName returns null when the Element is created while the schema namespace
processing is turned off.

So i think using getNodeName should work more reliable in this place.

I found a few other places where getLocalName could be replaced with getNodeName could you confirm?

Any opinions?


--
This message is automatically generated by JIRA.
For more information on JIRA, see: [3]http://www.atlassian.com/software/jira

       
This email message (including any attachments) is for the sole use of the
intended recipient and may contain confidential and privileged information.
Any unauthorized review, use, disclosure or distribution is prohibited. If
you are not the intended recipient, please contact the sender by reply email
and destroy all copies of the original message. Thank you

----------------------------------------------------------------------------------------
[1] https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112444#comment-13112444
[2] https://issues.apache.org/jira/browse/OFBIZ-4441
[3] http://www.atlassian.com/software/jira

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113941#comment-13113941 ]

Jacques Le Roux commented on OFBIZ-4441:
----------------------------------------

Please guys dont repeat useless information already present in previous tickets. I'd even appreciate if you could clean those above, thanks

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113122#comment-13113122 ]

Kiran Gawde edited comment on OFBIZ-4441 at 9/26/11 4:38 PM:
-------------------------------------------------------------

Hello Igor,

Since you discovered this issue, any comments?

Regards,
Kiran Gawde

      was (Author: kiran_gawde):
    Hello Igor,

Since you discovered this issue, any comments?

Regards,
Kiran Gawde

Senior Software Architect
Object Edge Inc
[phone] x108

"There are two kind of people: Those who do the work and those who take
the credit. Try to be in the first group because there is less competition
there."
"Never give up on what you really want to do. The person with big dreams
is more powerful than one with all the facts".

----- Forwarded by Kiran V Gawde/Object Edge on 09/22/2011 07:56 PM -----

From:   "Sascha Rodekamp (JIRA)" <[hidden email]>
To:     [hidden email]
Date:   09/22/2011 02:43 AM
Subject:        [jira] [Commented] (OFBIZ-4441) UtilXml firstChildElement
should use getNodeName instead of getLocalName




    [
https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112444#comment-13112444 
]

Sascha Rodekamp commented on OFBIZ-4441:
----------------------------------------

Hi Kiran,
i also don't understand why this two places uses getLocalName(). Just to
clarify, getLocalName returns null when the Element is created while the
schema namespace
processing is turned off.

So i think using getNodeName should work more reliable in this place.

I found a few other places where getLocalName could be replaced with
getNodeName could you confirm?

Any opinions?

OFBIZ-4441_XmlElementGetNodeName.patch
places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

 

 

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124404#comment-13124404 ]

Kiran Gawde commented on OFBIZ-4441:
------------------------------------

Hello Sascha

Since you already have patch available for this, can you please apply it
Trunk & 11.04. One less issue to track.

Thanks,
Kiran

               

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ashish Vijaywargiya reassigned OFBIZ-4441:
------------------------------------------

    Assignee: Ashish Vijaywargiya
   

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4441.
----------------------------------

   

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reopened OFBIZ-4441:
------------------------------------

   

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455776#comment-13455776 ]

Jacques Le Roux commented on OFBIZ-4441:
----------------------------------------

I reopened because there is (at least) a conflict of interest here when using SOAP. It's due to [the 2nd change in UtilXml.java done with r1183314|http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilXml.java?r1=1183314&r2=1183313&pathrev=1183314]
               

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456353#comment-13456353 ]

Jacques Le Roux commented on OFBIZ-4441:
----------------------------------------

I suggest to replace

node.getNodeName()
by
node.getLocalName() != null ? node.getLocalName() : node.getNodeName()

where getNodeName() replaced getLocalName() in above commits.

We will then have the best of both worlds. When there is a schema getLocalName() will just work fine, if there is not, then getNodeName() will be a fallback.

Just curious, before committing I'd like to know how this was spotted and if using getLocalName() in the 1st place had some bad side-effects?
               

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Assignee: Ashish Vijaywargiya
>            Priority: Minor
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4441.
----------------------------------

       Resolution: Fixed
    Fix Version/s: Release Branch 12.04
                   Release 11.04.01
                   SVN trunk
         Assignee: Jacques Le Roux  (was: Ashish Vijaywargiya)

Fixed in
Trunk r1387878
R12.04 r1387880
R11.04 r1387879

               

> UtilXml firstChildElement should use getNodeName instead of getLocalName
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-4441
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4441
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Kiran Gawde
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: SVN trunk, Release 11.04.01, Release Branch 12.04
>
>         Attachments: OFBIZ-4441-UtilXml.patch, OFBIZ-4441_XmlElementGetNodeName.patch
>
>
> Two places UtilXml uses getNodeName instead of getLocalName. Rest of the places it uses getNodeName

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira