[jira] [Created] (OFBIZ-4446) OnePageCheckout creates new billing/shipping phone number even if user selects the default values

[Nicolas Malin (Jira)]

OnePageCheckout creates new billing/shipping phone number even if user selects the default values
-------------------------------------------------------------------------------------------------

                 Key: OFBIZ-4446
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
             Project: OFBiz
          Issue Type: Bug
            Reporter: Kiran Gawde
            Priority: Minor


Steps:
1. Make sure the logged in user has billing/shipping phone number in the profile.
2. Add item to cart, and select 'onepagecheckout'
3. submit the order
4. Login to admin ui
5. Check the party profile.

Issue:
1. You will notice two new contacts for shipping/billing phone number.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114016#comment-13114016 ]

Kiran Gawde commented on OFBIZ-4446:
------------------------------------

This happens due to the error in CheckoutService.xml. It is missing following lines:

<set field="createUpdatePartyTelecomNumberCtx.contactMechId" from-field="parameters.shipToPhoneContactMechId" />

<set field="createUpdatePartyTelecomNumberCtx.contactMechId" from-field="parameters.billToPhoneContactMechId" />

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Kiran Gawde
>            Priority: Minor
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114019#comment-13114019 ]

Kiran Gawde commented on OFBIZ-4446:
------------------------------------

Also not sure, but I feel checkoutProcess.js has two incorrect lines:
jQuery('#shipToPhoneContactMechId').val(json.phoneContactMechId);

jQuery('#billToPhoneContactMechId').val(json.phoneContactMechId);

As the json fields return from the services (CheckoutServices.xml) are shipToPhoneContactMechId and billToPhoneContactMechId respectively.

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Kiran Gawde
>            Priority: Minor
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114021#comment-13114021 ]

Kiran Gawde commented on OFBIZ-4446:
------------------------------------

One more related error: The field names in the form are phoneContactMechId. These should be renamed to shipToPhoneContactMechId and billToPhoneContactMechId.

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>            Reporter: Kiran Gawde
>            Priority: Minor
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-4446:
-----------------------------------

          Component/s: specialpurpose/ecommerce
    Affects Version/s: SVN trunk

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Kiran Gawde
>            Priority: Minor
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Gawde updated OFBIZ-4446:
-------------------------------

    Affects Version/s: Release 10.04

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Priority: Minor
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Gawde updated OFBIZ-4446:
-------------------------------

    Attachment: OFBIZ-4446-CheckoutServicesXml.patch
                OFBIZ-4446-checkoutProcessJs.patch
                OFBIZ-4446&4447-OnePageCheckout.patch

Contains fix for 4447 as well.

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Gawde updated OFBIZ-4446:
-------------------------------

    Attachment: OFBIZ-4446&4447-OnePageCheckout.patch

Recreated patch after downloading fix for 4436

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kiran Gawde updated OFBIZ-4446:
-------------------------------

    Attachment:     (was: OFBIZ-4446&4447-OnePageCheckout.patch)

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp reassigned OFBIZ-4446:
--------------------------------------

    Assignee: Sascha Rodekamp
   

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115266#comment-13115266 ]

Sascha Rodekamp commented on OFBIZ-4446:
----------------------------------------

Hey Kiran, thanks for your work, if this patch contains 4447 could we link the to issues, it's easier to folow up ;-)


               

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115266#comment-13115266 ]

Sascha Rodekamp edited comment on OFBIZ-4446 at 9/27/11 6:51 AM:
-----------------------------------------------------------------

Hey Kiran, thanks for your work, if this patch contains OFBIZ-4447 could we link the to issues, it's easier to folow up ;-)


               
      was (Author: sascha):
    Hey Kiran, thanks for your work, if this patch contains 4447 could we link the to issues, it's easier to folow up ;-)


                 

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115321#comment-13115321 ]

Kiran Gawde commented on OFBIZ-4446:
------------------------------------

You are welcome. Sure. Please do the necessary. Thanks.

Regards,
Kiran Gawde

Senior Software Architect
Object Edge Inc
[phone] x108

"There are two kind of people: Those who do the work and those who take
the credit. Try to be in the first group because there is less competition
there."
"Never give up on what you really want to do. The person with big dreams
is more powerful than one with all the facts".


               

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117117#comment-13117117 ]

Sascha Rodekamp commented on OFBIZ-4446:
----------------------------------------

Hi Kiran i could reproduce the error, but the patch seems not to solve it.

Anyway while clicking throw the OPCO Process i was not able to submit an order:

{code}
Did not complete the order, the following occurred:ERROR : Could not create order (write error :Error while inserting: ... (Cannot add or update a child row: a foreign key constraint fails (`ofbiz/order_contact_mech`, CONSTRAINT `ORDER_CMECH_CM` FOREIGN KEY (`CONTACT_MECH_ID`) REFERENCES `contact_mech` (`CONTACT_MECH_ID`)))))
{code}

Could this Exception be related to your problem (tested with the current trunk version).


               

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146090#comment-13146090 ]

Kiran Gawde commented on OFBIZ-4446:
------------------------------------

Hello Sascha,

Sorry for late response. I have deserted 10.04 release for 11.04. I have
this working on 11.04 with my fix. I can remove the 10.04 release from the
defect and you can try this out in 11.04 or trunk.

Regards,
Kiran

               

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150987#comment-13150987 ]

Kiran Gawde commented on OFBIZ-4446:
------------------------------------

Hello Sascha,

I reproduce the error you see on the trunk without my fix (https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/manageAddress). This seems to happen only when you are adding new address for admin. If you register new user, this error doesn't happen. Can you please confirm my finding?

Thanks,
Kiran
               

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151374#comment-13151374 ]

Kiran Gawde commented on OFBIZ-4446:
------------------------------------

Seems like the error I reproduced was slightly different. It was fixed after adding customer rule to the party.

BTW, I verified that this issue is fixed with my solution.
Cheers,
Kiran
               

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151887#comment-13151887 ]

Sascha Rodekamp commented on OFBIZ-4446:
----------------------------------------

Hi Kiran, sorry for the late response, i don't forget you :-)

I will review your new patch ASAP. Thanks for your continuous work on this.
               

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp closed OFBIZ-4446.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 11.04

Hi Kiran,

thanks for the patch, it works now :)

You Patch is in Trunk @Rev 1203129
And 11.04 @Rev 1203128
               

> OnePageCheckout creates new billing/shipping phone number even if user selects the default values
> -------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk
>
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch, OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Kiran-2]

Thanks Sascha!

Regards,
Kiran Gawde

Senior Software Architect
Object Edge Inc
[phone] x108

"There are two kind of people: Those who do the work and those who take
the credit. Try to be in the first group because there is less competition
there."
"Never give up on what you really want to do. The person with big dreams
is more powerful than one with all the facts".




From:   "Sascha Rodekamp (Closed) (JIRA)" <[hidden email]>
To:     [hidden email]
Date:   11/17/2011 01:54 AM
Subject:        [jira] [Closed] (OFBIZ-4446) OnePageCheckout creates new
billing/shipping phone number even if user selects the default values




     [
https://issues.apache.org/jira/browse/OFBIZ-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
]

Sascha Rodekamp closed OFBIZ-4446.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 11.04

Hi Kiran,

thanks for the patch, it works now :)

You Patch is in Trunk @Rev 1203129
And 11.04 @Rev 1203128
 
> OnePageCheckout creates new billing/shipping phone number even if user
selects the default values
>
-------------------------------------------------------------------------------------------------

>
>                 Key: OFBIZ-4446
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4446
>             Project: OFBiz
>          Issue Type: Bug
>          Components: specialpurpose/ecommerce
>    Affects Versions: Release 10.04, SVN trunk
>            Reporter: Kiran Gawde
>            Assignee: Sascha Rodekamp
>            Priority: Minor
>             Fix For: Release Branch 11.04, SVN trunk
>
>         Attachments: OFBIZ-4446&4447-OnePageCheckout.patch,

OFBIZ-4446-CheckoutServicesXml.patch, OFBIZ-4446-checkoutProcessJs.patch
>
>
> Steps:
> 1. Make sure the logged in user has billing/shipping phone number in the
profile.
> 2. Add item to cart, and select 'onepagecheckout'
> 3. submit the order
> 4. Login to admin ui
> 5. Check the party profile.
> Issue:
> 1. You will notice two new contacts for shipping/billing phone number.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira