OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

30 messages Options

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget

[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449263 ]

Jacques Le Roux commented on OFBIZ-450:
---------------------------------------

"don't remove its lines but delete it from your working copy" and of course include this information in your patch. Mmm, I wonder now if I'm not missing something here ?

Finally I found a page which explains that very well : http://wiki.apache.org/db-derby/AddedOrDeletedFilesInDiff (may be we can refer to it in http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities?focusedCommentId=671#comment-671 ?)

OK so that is my duty and not yours Marco, I apologize.

Yes still learning ... :/

> Migrate Entity Maintenance from JSPs/region to Screen widget
> ------------------------------------------------------------
>
> Key: OFBIZ-450
> URL: http://issues.apache.org/jira/browse/OFBIZ-450
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Marco Risaliti
> Assigned To: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: entity_maint3.patch
>
>
> This patch contains the migration from JSPs/region to Screen widget.
> I have re-applied also the changes that has been done into the issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance Screen) recently committed.
> After this patch the entity maintenance has still two minor issues that they was also present into the previously version written in JSPs/region :
> 1- sometimes the html tables overflow the screen.
> 2- in case of entity that has an group by clause specified the FindGeneric page will show an error.
> That's all what I have done.
> Please give me some feedback on this issue so if everythings is ok I can continue to migrate the next part of the Webtools application (Entity Reference).
> Can also the committer tell me if the patch has a correct formatting and absence of tabs and correct relative paths.
> Thanks in advance
> Marco

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449834 ]

Jacques Le Roux commented on OFBIZ-450:
---------------------------------------

I noticed 2 little problems with this patch :
. In Firefox the 2 1st columns are too narrow
. The indication about the number of item displayed is always 50, even if there are less item shown.

I tried to correct myself, but I'm sure Marco will be much more productive

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449956 ]

Jacques Le Roux commented on OFBIZ-450:
---------------------------------------

In Firefox columns are not always too naroow. It's true for InvoiceItem but not for InvoiceItemType for instance

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12450201 ]

Marco Risaliti commented on OFBIZ-450:
--------------------------------------

Hi Jacques,

I think that this is not a specific problem of Firefox and this issue was already present in the JSP/region version.
In any case the same issue is common in all the backend applications, like in the account application into the Response from Gateway the screen is overflowed.
I have tried to do a simple change into tabstyle.css into the DIV. contentarea style adding the following line:
overflow:auto;

DIV.contentarea {
background-color: #FFFFFF;
border: solid black 1px;
margin-top: 10px;
padding: 10px;
overflow:auto;
}

Doing this changes both of the screen (accounting response from gateway and find generic screen) seems to be better but before you can commit this simple changes I would like that someone else can test it like me to be sure that this is the correct way to solve this issue.

Thanks
Marco

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12450270 ]

Jacques Le Roux commented on OFBIZ-450:
---------------------------------------

Hi Marco,

Sorry but it's worst, at least in Firefox 1.5 on Windows. So I reverted, BTW I know now the reason of the problem. It depends of width of the result.

On Firefox 1.5 if the screen is larger enough no problem, else the colums are narrowed hence the problem for the 2 buttons that are not resized. Columns are narrowed till something that seems to be a minimum for the width. And then this stops and a scroll bar appears at botton.

On Opera 9.02 and IE9 its' ok : no colum resizing, a scroll bar appears at bottom if needed.

You are right the problem already existed in JSP. I think we may forget it as 2 of the mains browser work correctly, this is not blocking and finding a solution to this problem may be complicated and destabilizing. What do you think ?

Chandresh Turakhia

Installing Ofbix

In reply to this post by Nicolas Malin (Jira)

Dear all .

Sorry to ask dumb question but

How do I download Ofbiz ? I could not find release archive.

"Download the OFBiz release archive and unzip it in the directory of your
choice. This should create one sub-directory: ofbiz. This will be the
OFBIZ_HOME location"

Does it come with single installer. I could not find one on site.

Chand

----- Original Message -----
From: "Jacques Le Roux (JIRA)" <[hidden email]>
To: <[hidden email]>
Sent: Wednesday, November 15, 2006 1:44 AM
Subject: [jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from
JSPs/region to Screen widget

> [
> http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449956 ]
>
> Jacques Le Roux commented on OFBIZ-450:
> ---------------------------------------
>
> In Firefox columns are not always too naroow. It's true for InvoiceItem
> but not for InvoiceItemType for instance
>
>> Migrate Entity Maintenance from JSPs/region to Screen widget
>> ------------------------------------------------------------
>>
>> Key: OFBIZ-450
>> URL: http://issues.apache.org/jira/browse/OFBIZ-450
>> Project: OFBiz (The Open for Business Project)
>> Issue Type: Improvement
>> Components: framework
>> Affects Versions: SVN trunk
>> Reporter: Marco Risaliti
>> Assigned To: Jacques Le Roux
>> Priority: Minor
>> Fix For: SVN trunk
>>
>> Attachments: entity_maint3.patch
>>
>>
>> This patch contains the migration from JSPs/region to Screen widget.
>> I have re-applied also the changes that has been done into the issue
>> OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance
>> Screen) recently committed.
>> After this patch the entity maintenance has still two minor issues that
>> they was also present into the previously version written in JSPs/region
>> :
>> 1- sometimes the html tables overflow the screen.
>> 2- in case of entity that has an group by clause specified the
>> FindGeneric page will show an error.
>> That's all what I have done.
>> Please give me some feedback on this issue so if everythings is ok I can
>> continue to migrate the next part of the Webtools application (Entity
>> Reference).
>> Can also the committer tell me if the patch has a correct formatting and
>> absence of tabs and correct relative paths.
>> Thanks in advance
>> Marco
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
>

Jacopo Cappellato

Re: Installing Ofbix

Hi,

the best version is the svn trunk; however, if you want something easier
to setup for evaluation purposes, you can download the binary TSR
available from this page:

http://docs.ofbiz.org/display/OFBADMIN/Apache+OFBiz+Incubating+4.0.0+Test+Snapshot+Release

Jacopo

Chandresh Turakhia wrote:

> Dear all .
>
>
> Sorry to ask dumb question but
>
> How do I download Ofbiz ? I could not find release archive.
>
> "Download the OFBiz release archive and unzip it in the directory of
> your choice. This should create one sub-directory: ofbiz. This will be
> the OFBIZ_HOME location"
>
> Does it come with single installer. I could not find one on site.
>
> Chand
>
> ----- Original Message ----- From: "Jacques Le Roux (JIRA)"
> <[hidden email]>
> To: <[hidden email]>
> Sent: Wednesday, November 15, 2006 1:44 AM
> Subject: [jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from
> JSPs/region to Screen widget
>
>
>> [
>> http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12449956
>> ]
>>
>> Jacques Le Roux commented on OFBIZ-450:
>> ---------------------------------------
>>
>> In Firefox columns are not always too naroow. It's true for
>> InvoiceItem but not for InvoiceItemType for instance
>>
>>> Migrate Entity Maintenance from JSPs/region to Screen widget
>>> ------------------------------------------------------------
>>>
>>> Key: OFBIZ-450
>>> URL: http://issues.apache.org/jira/browse/OFBIZ-450
>>> Project: OFBiz (The Open for Business Project)
>>> Issue Type: Improvement
>>> Components: framework
>>> Affects Versions: SVN trunk
>>> Reporter: Marco Risaliti
>>> Assigned To: Jacques Le Roux
>>> Priority: Minor
>>> Fix For: SVN trunk
>>>
>>> Attachments: entity_maint3.patch
>>>
>>>
>>> This patch contains the migration from JSPs/region to Screen widget.
>>> I have re-applied also the changes that has been done into the issue
>>> OFBIZ-421 (Add new link Relation(Reln) on the Entity Data Maintenance
>>> Screen) recently committed.
>>> After this patch the entity maintenance has still two minor issues
>>> that they was also present into the previously version written in
>>> JSPs/region :
>>> 1- sometimes the html tables overflow the screen.
>>> 2- in case of entity that has an group by clause specified the
>>> FindGeneric page will show an error.
>>> That's all what I have done.
>>> Please give me some feedback on this issue so if everythings is ok I
>>> can continue to migrate the next part of the Webtools application
>>> (Entity Reference).
>>> Can also the committer tell me if the patch has a correct formatting
>>> and absence of tabs and correct relative paths.
>>> Thanks in advance
>>> Marco
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> If you think it was sent incorrectly contact one of the
>> administrators: http://issues.apache.org/jira/secure/Administrators.jspa
>> -
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>>
>

David E Jones-2

Re: Installing Ofbix

Either that or the weekly builds that Si Chen does (there is a link
to them on the ofbiz home page).

Of course, for something really cool, try building from SVN... ;)

We do hope to get a stable release out fairly soon, intended to be
done around the time of the graduation of OFBiz from the Apache
Incubator. This will probably be around the end of the year, but it's
always hard to say.

-David

On Nov 15, 2006, at 11:45 PM, Jacopo Cappellato wrote:

> Hi,
>
> the best version is the svn trunk; however, if you want something
> easier to setup for evaluation purposes, you can download the
> binary TSR available from this page:
>
> http://docs.ofbiz.org/display/OFBADMIN/Apache+OFBiz+Incubating+4.0.0
> +Test+Snapshot+Release
>
> Jacopo
>
>
> Chandresh Turakhia wrote:
>> Dear all .
>> Sorry to ask dumb question but
>> How do I download Ofbiz ? I could not find release archive.
>> "Download the OFBiz release archive and unzip it in the directory
>> of your choice. This should create one sub-directory: ofbiz. This
>> will be the OFBIZ_HOME location"
>> Does it come with single installer. I could not find one on site.
>> Chand
>> ----- Original Message ----- From: "Jacques Le Roux (JIRA)"
>> <[hidden email]>
>> To: <[hidden email]>
>> Sent: Wednesday, November 15, 2006 1:44 AM
>> Subject: [jira] Commented: (OFBIZ-450) Migrate Entity Maintenance
>> from JSPs/region to Screen widget
>>> [ http://issues.apache.org/jira/browse/OFBIZ-450?
>>> page=comments#action_12449956 ]
>>>
>>> Jacques Le Roux commented on OFBIZ-450:
>>> ---------------------------------------
>>>
>>> In Firefox columns are not always too naroow. It's true for
>>> InvoiceItem but not for InvoiceItemType for instance
>>>
>>>> Migrate Entity Maintenance from JSPs/region to Screen widget
>>>> ------------------------------------------------------------
>>>>
>>>> Key: OFBIZ-450
>>>> URL: http://issues.apache.org/jira/browse/OFBIZ-450
>>>> Project: OFBiz (The Open for Business Project)
>>>> Issue Type: Improvement
>>>> Components: framework
>>>> Affects Versions: SVN trunk
>>>> Reporter: Marco Risaliti
>>>> Assigned To: Jacques Le Roux
>>>> Priority: Minor
>>>> Fix For: SVN trunk
>>>>
>>>> Attachments: entity_maint3.patch
>>>>
>>>>
>>>> This patch contains the migration from JSPs/region to Screen
>>>> widget.
>>>> I have re-applied also the changes that has been done into the
>>>> issue OFBIZ-421 (Add new link Relation(Reln) on the Entity Data
>>>> Maintenance Screen) recently committed.
>>>> After this patch the entity maintenance has still two minor
>>>> issues that they was also present into the previously version
>>>> written in JSPs/region :
>>>> 1- sometimes the html tables overflow the screen.
>>>> 2- in case of entity that has an group by clause specified the
>>>> FindGeneric page will show an error.
>>>> That's all what I have done.
>>>> Please give me some feedback on this issue so if everythings is
>>>> ok I can continue to migrate the next part of the Webtools
>>>> application (Entity Reference).
>>>> Can also the committer tell me if the patch has a correct
>>>> formatting and absence of tabs and correct relative paths.
>>>> Thanks in advance
>>>> Marco
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> If you think it was sent incorrectly contact one of the
>>> administrators: http://issues.apache.org/jira/secure/
>>> Administrators.jspa
>>> -
>>> For more information on JIRA, see: http://www.atlassian.com/
>>> software/jira
>>>
>>>
>>>
>>>
>

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12450519 ]

Marco Risaliti commented on OFBIZ-450:
--------------------------------------

Hi Jacques,

I think for the moment we can leave like it is now it's not a blocking error and when I will have time a disposal I will look at those layout issues of the css.

Thanks
Marco

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-450) Migrate Entity Maintenance from JSPs/region to Screen widget

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-450?page=comments#action_12450655 ]

David E. Jones commented on OFBIZ-450:
--------------------------------------

I agree with Marco. It sounds like this is a problem that was there before, and not one that breaks the functionality. So no, it wouldn't require rolling back the change or really make a rollback a good idea.