OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-462) when return is cancelled, return items should be cancelled

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-462) when return is cancelled, return items should be cancelled

when return is cancelled, return items should be cancelled
----------------------------------------------------------

Key: OFBIZ-462
URL: http://issues.apache.org/jira/browse/OFBIZ-462
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: order
Reporter: Si Chen

When a return header is set to cancelled, a new service to set all return items' status to cancelled should be called. Otherwise, the return header is cancelled but the return items are still requested, leading to possible errors.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-462) when return is cancelled, return items should be cancelled

[ http://issues.apache.org/jira/browse/OFBIZ-462?page=all ]

Si Chen reassigned OFBIZ-462:
-----------------------------

Assignee: Si Chen

> when return is cancelled, return items should be cancelled
> ----------------------------------------------------------
>
> Key: OFBIZ-462
> URL: http://issues.apache.org/jira/browse/OFBIZ-462
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Si Chen
> Assigned To: Si Chen
>
> When a return header is set to cancelled, a new service to set all return items' status to cancelled should be called. Otherwise, the return header is cancelled but the return items are still requested, leading to possible errors.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-462) when return is cancelled, return items should be cancelled

In reply to this post by Nicolas Malin (Jira)

> when return is cancelled, return items should be cancelled
> ----------------------------------------------------------
>
> Key: OFBIZ-462
> URL: http://issues.apache.org/jira/browse/OFBIZ-462
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Si Chen
> Assigned To: Si Chen
> Attachments: Ofbiz_ReturnItems_Nov_16.patch
>
>
> When a return header is set to cancelled, a new service to set all return items' status to cancelled should be called. Otherwise, the return header is cancelled but the return items are still requested, leading to possible errors.

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-462) when return is cancelled, return items should be cancelled

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-462?page=comments#action_12450467 ]

Si Chen commented on OFBIZ-462:
-------------------------------

Ashish,

You should use the updateReturnItem status in your new service instead of storing the ReturnItem directly with the delegator. In general, you should call services instead of directly updating the entities. Otherwise, other rules based on SECAs may not work.

Si

> when return is cancelled, return items should be cancelled
> ----------------------------------------------------------
>
> Key: OFBIZ-462
> URL: http://issues.apache.org/jira/browse/OFBIZ-462
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Si Chen
> Assigned To: Si Chen
> Attachments: Ofbiz_ReturnItems_Nov_16.patch
>
>
> When a return header is set to cancelled, a new service to set all return items' status to cancelled should be called. Otherwise, the return header is cancelled but the return items are still requested, leading to possible errors.

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-462) when return is cancelled, return items should be cancelled

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-462?page=all ]

Ashish Vijaywargiya updated OFBIZ-462:
--------------------------------------

Attachment: Ofbiz_ReturnItem2_Nov_17.patch

Si,

Today when I started my work I was going to call the <updateReturnItem> but missed the tag <implements service="returnItemInterface"/> so I was thinking that if it is not taking the returnId as the input parameter then how can it be called.That's why I directly saved the values.

Sorry for this stupid mistake.I will take care of it from the next time.
Anyway here is the updated patch for this.
Thanks for your comment.

Regards
Ashish Vijaywargiya

> when return is cancelled, return items should be cancelled
> ----------------------------------------------------------
>
> Key: OFBIZ-462
> URL: http://issues.apache.org/jira/browse/OFBIZ-462
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Si Chen
> Assigned To: Si Chen
> Attachments: Ofbiz_ReturnItem2_Nov_17.patch, Ofbiz_ReturnItems_Nov_16.patch
>
>
> When a return header is set to cancelled, a new service to set all return items' status to cancelled should be called. Otherwise, the return header is cancelled but the return items are still requested, leading to possible errors.

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-462) when return is cancelled, return items should be cancelled

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-462?page=all ]

Si Chen closed OFBIZ-462.
-------------------------

Resolution: Fixed

Thanks, Ashish -- This is good except for one thing: the seca should be synch not asynch. Asynch sends it to run in a pool and is usually good for things you want to run in a separate thread and with time delays (and over and over again if it failed.) This should basically be run as synch so it happens immediately, and if you can't update the return items for some reason, the whole operation should be failed and rolled back.

> when return is cancelled, return items should be cancelled
> ----------------------------------------------------------
>
> Key: OFBIZ-462
> URL: http://issues.apache.org/jira/browse/OFBIZ-462
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Reporter: Si Chen
> Assigned To: Si Chen
> Attachments: Ofbiz_ReturnItem2_Nov_17.patch, Ofbiz_ReturnItems_Nov_16.patch
>
>
> When a return header is set to cancelled, a new service to set all return items' status to cancelled should be called. Otherwise, the return header is cancelled but the return items are still requested, leading to possible errors.