redundant LookupContactList in product app
------------------------------------------ Key: OFBIZ-4574 URL: https://issues.apache.org/jira/browse/OFBIZ-4574 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Release Branch 11.04, SVN trunk Reporter: Kiran Gawde Priority: Trivial Following lines from product\controller.xml are redundant. They are present in partymgr. <request-map uri="LookupContactList"><security https="true" auth="true"/><response name="success" type="view" value="LookupContactList"/></request-map> <view-map name="LookupContactList" type="screen" page="component://party/widget/partymgr/PartyContactListScreens.xml#ListLookupContactList"/> -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[ https://issues.apache.org/jira/browse/OFBIZ-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kiran Gawde updated OFBIZ-4574: ------------------------------- Attachment: OFBIZ-4574-ControllerXml.patch removed redundant code. > redundant LookupContactList in product app > ------------------------------------------ > > Key: OFBIZ-4574 > URL: https://issues.apache.org/jira/browse/OFBIZ-4574 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: Release Branch 11.04, SVN trunk > Reporter: Kiran Gawde > Priority: Trivial > Attachments: OFBIZ-4574-ControllerXml.patch > > > Following lines from product\controller.xml are redundant. They are present in partymgr. > <request-map uri="LookupContactList"><security https="true" auth="true"/><response name="success" type="view" value="LookupContactList"/></request-map> > <view-map name="LookupContactList" type="screen" page="component://party/widget/partymgr/PartyContactListScreens.xml#ListLookupContactList"/> -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156905#comment-13156905 ] Jacques Le Roux commented on OFBIZ-4574: ---------------------------------------- Indeed, I don't see any use at all of LookupContactList in product component (only in Marketing and Product). If someone disagree with this patch please speak beforeI apply it... On the other hand, since there are not the same in Marketing and Product it could be seen as ambiguous, and then if someone needs it in catalog it will have to make the choice, maybe the reason it's there? > redundant LookupContactList in product app > ------------------------------------------ > > Key: OFBIZ-4574 > URL: https://issues.apache.org/jira/browse/OFBIZ-4574 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: Release Branch 11.04, SVN trunk > Reporter: Kiran Gawde > Priority: Trivial > Attachments: OFBIZ-4574-ControllerXml.patch > > > Following lines from product\controller.xml are redundant. They are present in partymgr. > <request-map uri="LookupContactList"><security https="true" auth="true"/><response name="success" type="view" value="LookupContactList"/></request-map> > <view-map name="LookupContactList" type="screen" page="component://party/widget/partymgr/PartyContactListScreens.xml#ListLookupContactList"/> -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4574. ---------------------------------- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Kiran, Your patch is in trunk at r1206693. Not backported as it's not a bug > redundant LookupContactList in product app > ------------------------------------------ > > Key: OFBIZ-4574 > URL: https://issues.apache.org/jira/browse/OFBIZ-4574 > Project: OFBiz > Issue Type: Bug > Components: product > Affects Versions: Release Branch 11.04, SVN trunk > Reporter: Kiran Gawde > Assignee: Jacques Le Roux > Priority: Trivial > Fix For: SVN trunk > > Attachments: OFBIZ-4574-ControllerXml.patch > > > Following lines from product\controller.xml are redundant. They are present in partymgr. > <request-map uri="LookupContactList"><security https="true" auth="true"/><response name="success" type="view" value="LookupContactList"/></request-map> > <view-map name="LookupContactList" type="screen" page="component://party/widget/partymgr/PartyContactListScreens.xml#ListLookupContactList"/> -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
Free forum by Nabble | Edit this page |