[jira] Created: (OFBIZ-459) Support refunds to non-credit card

[Nicolas Malin (Jira)]

Support refunds to non-credit card
-----------------------------------

                 Key: OFBIZ-459
                 URL: http://issues.apache.org/jira/browse/OFBIZ-459
             Project: OFBiz (The Open for Business Project)
          Issue Type: Improvement
            Reporter: Si Chen




--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-459?page=comments#action_12449745 ]
           
Si Chen commented on OFBIZ-459:
-------------------------------

Currently, if you try to create a return for an order that was paid by check, cash, etc. and you want to refund the customer, you will get this big ugly message:

org.ofbiz.webapp.event.EventHandlerException: Service invocation error (Problems with the transaction: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Service Error [processRefundReturn]: Unable to refund order #WS10040; there are no available payment preferences.; See logs for more detail)

This is in fact not too difficult to fix.  Instead of returning this error, just create a new Payment of the type CUSTOMER_REFUND to the ReturnHeader.returnFromPartyId from the ReturnHeader.returnFacilityId.ownerPartyId for the amount of the refund in the state NOT_SENT.  Then apply that Payment to the Return Invoice created from the Return.  Later somebody can go in and manually set the payment method type, payment method type, etc.

> Support refunds to non-credit card
> ----------------------------------
>
>                 Key: OFBIZ-459
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-459
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Si Chen
>


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-459?page=comments#action_12451022 ]
           
Iain Fogg commented on OFBIZ-459:
---------------------------------

Si,

I don't understand the work-around. How can you create the Return Invoice if when you try to "Accept Return" you get the big ugly error message?

Confused, Iain

> Support refunds to non-credit card
> ----------------------------------
>
>                 Key: OFBIZ-459
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-459
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Si Chen
>


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-459?page=comments#action_12451042 ]
           
Si Chen commented on OFBIZ-459:
-------------------------------

It's not a workaround.  I think it's actually the right way to fix it.  If you have an offline payment in your store that you want to refund, the procedure is to issue a check.  

The reason you can't create return invoice and get that big ugly error message is because the code currently can't figure out a payment method to refund, so then the whole thing gets rolled back.  Instead of the error message, we should just create a Payment.

> Support refunds to non-credit card
> ----------------------------------
>
>                 Key: OFBIZ-459
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-459
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Si Chen
>


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ http://issues.apache.org/jira/browse/OFBIZ-459?page=comments#action_12451085 ]
           
Iain Fogg commented on OFBIZ-459:
---------------------------------

Apologies for the confusion, but I thought you meant that I should manually be creating this payment and then assigning it to the return invoice, which is of course impossible since I can't create the return invoice. You're saying that the code should create the payment, and then apply to the invoice right?

It's not quite right to say that when you refund and offline payment you issue a check. For example, if the customer used a CC that was authorised offline, then I would also authorise the refund offline too. In that case, instead of crediting CASH IN REGISTER (for a cash refund) or GENERAL CHECKING ACCOUNT for checks, the IN TRANSIT FROM CC PROCESSORS account should be credited. Does that make sense, or is that what you mean by "Later somebody can go in and manually set the payment method type, payment method type, etc."

> Support refunds to non-credit card
> ----------------------------------
>
>                 Key: OFBIZ-459
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-459
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Si Chen
>


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ http://issues.apache.org/jira/browse/OFBIZ-459?page=all ]

Si Chen reassigned OFBIZ-459:
-----------------------------

    Assignee: Si Chen

> Support refunds to non-credit card
> ----------------------------------
>
>                 Key: OFBIZ-459
>                 URL: http://issues.apache.org/jira/browse/OFBIZ-459
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>            Reporter: Si Chen
>         Assigned To: Si Chen
>

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira