OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.
-------------------------------------------------------------------------------------

Key: OFBIZ-4629
URL: https://issues.apache.org/jira/browse/OFBIZ-4629
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: Release 10.04, SVN trunk
Reporter: Ankit Jain
Priority: Minor

Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

> The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-4629
> URL: https://issues.apache.org/jira/browse/OFBIZ-4629
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Attachments: OFBIZ-4629.patch
>
>
> Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174442#comment-13174442 ]

Jacques Le Roux commented on OFBIZ-4629:
----------------------------------------

Hi Ankit,

It seems to me that this is already done in methods PackingSessionLine.issueItemToShipment, and VerifyPickSessionRow.issueItemToShipment, which makes sense to me, thought I did only a 5 mins review, so I could be wrong, could you please check?

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-4629:
------------------------------

Attachment: Updated-Ofbiz-4629.patch

Thanks Jacques, for reviewing it.

Yes I found the method VerifyPickSessionRow.issueItemToShipment which is doing the same thing.

But I found a bug too and also the reason for it, actually when you verify an order by passing "PicklistBinId" then it updates the status of picklistitems, but if we verify an order by passing a orderId then the status of the picklistitem never changes to Complete.

The reason is that when we pass orderId the "picklistBinId" is not get set in the verifyPickSession so its not available at the time "issueItemToShipment" is called so its not changing the status to complete.

So I created a patch will will fix this issue.

> The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-4629
> URL: https://issues.apache.org/jira/browse/OFBIZ-4629
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Attachments: OFBIZ-4629.patch, Updated-Ofbiz-4629.patch
>
>
> Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175087#comment-13175087 ]

Jacques Le Roux commented on OFBIZ-4629:
----------------------------------------

Thanks Ankit,

I will be away until Wednesday, I will then review your patches again ;)

> The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-4629
> URL: https://issues.apache.org/jira/browse/OFBIZ-4629
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Attachments: OFBIZ-4629.patch, Updated-Ofbiz-4629.patch
>
>
> Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".

Nicolas Malin (Jira)

[jira] [Assigned] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4629:
--------------------------------------

Assignee: Jacques Le Roux

> The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-4629
> URL: https://issues.apache.org/jira/browse/OFBIZ-4629
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Attachments: OFBIZ-4629.patch, Updated-Ofbiz-4629.patch
>
>
> Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4629.
----------------------------------

Resolution: Fixed
Fix Version/s: SVN trunk
Release Branch 11.04
Release Branch 10.04
Release Branch 09.04

Thanks Ankit,

Your patches are in
trunk r1231444+1231445
R11.04 r1231447+r1231450
R10.04 r1231448+r1231451
R09.04 r1231449 (the VerifyPickSession.java had too much conflicts)

> The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-4629
> URL: https://issues.apache.org/jira/browse/OFBIZ-4629
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4629.patch, Updated-Ofbiz-4629.patch
>
>
> Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186472#comment-13186472 ]

Jacques Le Roux commented on OFBIZ-4629:
----------------------------------------

After a discussion with Ankit this morning, revert the 1st patch of https://issues.apache.org/jira/browse/OFBIZ-4629 "The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED."

We agreed the change in VerifyPickSession.complete method was useless since it exists also in PackingSessionLine.issueItemToShipment and VerifyPickSessionRow.issueItemToShipment methods

Reverted in revisions
trunk 1231649
R11.04 1231651
R10.04 1231650

> The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-4629
> URL: https://issues.apache.org/jira/browse/OFBIZ-4629
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4629.patch, Updated-Ofbiz-4629.patch
>
>
> Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4629) The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187035#comment-13187035 ]

Ankit Jain commented on OFBIZ-4629:
-----------------------------------

Thanks Jacques. :)

> The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-4629
> URL: https://issues.apache.org/jira/browse/OFBIZ-4629
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release 10.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4629.patch, Updated-Ofbiz-4629.patch
>
>
> Whenever a order is verified picked the status of Picklistitem never changes to "PICKITEM_COMPLETED", even if the order is completed the status always remain as "PICKITEM_PENDING". I think when a PiclistItem is verified the status should change to "PICKITEM_COMPLETED".