OFBiz › OFBiz - Dev

[jira] Created: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

17 messages Options

Nicolas Malin (Jira)

[jira] Created: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

PDF view of order crashes depending on customer data such as notes and address lines.
-------------------------------------------------------------------------------------

Key: OFBIZ-466
URL: http://issues.apache.org/jira/browse/OFBIZ-466
Project: OFBiz (The Open for Business Project)
Issue Type: Bug
Components: order
Affects Versions: SVN trunk
Environment: N/A
Reporter: Ray Barlow
Attachments: order_pdf.patch

This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=all ]

Ray Barlow updated OFBIZ-466:
-----------------------------

Attachment: order_pdf.patch

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Attachments: order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12450112 ]

Si Chen commented on OFBIZ-466:
-------------------------------

Can you try putting:

<#escape x as x?xml>

instead of all theses ?xml tags and see if it works?

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12450135 ]

Ray Barlow commented on OFBIZ-466:
----------------------------------

From what I can see that is already in place: framework/common/webcommon/includes/reportTemplate.fo.ftl

Unfortunately it's not working in this example of the order view pdf. Just tested it again on https://demo.dejc.com:8443/ordermgr/control/orderview?orderId=WS10001 and that is now failing to render the pdf because of the comment in the notes field containing &.

Make the note private and the pdf renders as the note is not shown. Personally I like the "<#escape x as x?xml>" idea but it's not working so I'd suggest all the ?xml tags are an improvement over the current crash of the pdf generation for the time being.

Nicolas Malin (Jira)

[jira] Assigned: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=all ]

Jacopo Cappellato reassigned OFBIZ-466:
---------------------------------------

Assignee: Jacopo Cappellato

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12450160 ]

Jacopo Cappellato commented on OFBIZ-466:
-----------------------------------------

Ray is right,

the <#escape x as x?xml> in the reportTemplate.fo.ftl file has no effect (I don't know why); however, if you add the <#escape x as x?xml> tag to each of the order's template it works fine; and iit is a better and quicker option than the one of adding the ?xml tags to all the fields.

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12450259 ]

David E. Jones commented on OFBIZ-466:
--------------------------------------

This probably isn't working in the template because of some funny context thing, either because of FreeMarker or because of how we're using it. Rendering sub-screens through the screen widget would definitely have this effect as changes made to the FreeMarker context are only in the context for that template, ie they don't get back to the screen widget (because of the way FreeMarker handles a local context and object wrapping stuff and such).

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12450261 ]

Chris Howe commented on OFBIZ-466:
----------------------------------

Because the errors when generating pdfs through freemarker are a bit more cryptic than when the output is html, I would suggest using <#attempt> / <#recover> http://freemarker.sourceforge.net/docs/ref_directive_attempt.html
liberally throughout freemarker pdf templates? This way the sections of code that aren't generating problems will still output to your pdf.

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Updated: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=all ]

Ray Barlow updated OFBIZ-466:
-----------------------------

Attachment: fo_ftl_escape.patch

This is a replacement patch that inserts the escape tag into all fo.ftl files so we can stop this problem for all reports. I also removed the few uses of ?xml against fields and left a few if_exists in the order pdf report for null handling of address fields.

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12451681 ]

Jacopo Cappellato commented on OFBIZ-466:
-----------------------------------------

I think that we should commit Ray's last patch (fo_ftl_escape.patch).
This should become a best practice for all the fo.ftl files.
Can I commit it?

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12451723 ]

Si Chen commented on OFBIZ-466:
-------------------------------

sounds good to me...

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=all ]

Jacopo Cappellato closed OFBIZ-466.
-----------------------------------

Resolution: Fixed

Ray, all,

I've committed Ray's last patch (thanks Ray!) with rev 478784 and the following comment:

"From now on, it should be considered a good practice to wrap each fo.ftl template inside the tags:
<#escape x as x?xml>
...
</#escape>
"

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12453431 ]

Ray Barlow commented on OFBIZ-466:
----------------------------------

Jacopo,

It looks like the commit has dropped lots of the ending tags:
http://svn.apache.org/viewvc/incubator/ofbiz/trunk/applications/order/webapp/ordermgr/reports/OrderPurchaseReportPayment.fo.ftl?r1=422746&r2=478784

Not sure why as they are in the "fo_ftl_escape.patch" patch file?! I've just created a new patch that shows the outstanding differences in my local copy that were part of the "fo_ftl_escape.patch" patch.

Ray

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Reopened: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=all ]

Jacopo Cappellato reopened OFBIZ-466:
-------------------------------------

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Resolved: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=all ]

Jacopo Cappellato resolved OFBIZ-466.
-------------------------------------

Resolution: Fixed

Ray, many thanks for your review and patch.
It should hopefully fixed in rev. 479323
I guess it was caused by a problem with the patch tool of my IDE (Netbeans 5.5).

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Commented: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=comments#action_12453886 ]

Ray Barlow commented on OFBIZ-466:
----------------------------------

Thanks Jacopo all looks good now.

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"

Nicolas Malin (Jira)

[jira] Closed: (OFBIZ-466) PDF view of order crashes depending on customer data such as notes and address lines.

In reply to this post by Nicolas Malin (Jira)

[ http://issues.apache.org/jira/browse/OFBIZ-466?page=all ]

Jacopo Cappellato closed OFBIZ-466.
-----------------------------------

> PDF view of order crashes depending on customer data such as notes and address lines.
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-466
> URL: http://issues.apache.org/jira/browse/OFBIZ-466
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: N/A
> Reporter: Ray Barlow
> Assigned To: Jacopo Cappellato
> Attachments: fo_ftl_escape.patch, order_pdf.patch
>
>
> This patch adds a few more ?xml attributes to the pdf views for orders to stop crashes when trying to view an order that has xml unfriendly characters i.e. view the pdf of an order with a customer facing note saying "Merry Christmas & Happy New Year"