[jira] [Created] (OFBIZ-4660) OrderListState need to be Serializable for clustering

[Nicolas Malin (Jira)]

OrderListState need to be Serializable for clustering
-----------------------------------------------------

                 Key: OFBIZ-4660
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4660
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: SVN trunk
         Environment: Ubuntu
            Reporter: Chatree Srichart
            Priority: Critical


OrderListState is to be set to session, so it needs to be Serializable for clustering.

I got this error:

---- cause ---------------------------------------------------------------------
Exception: java.lang.IllegalArgumentException
Message: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
---- stack trace ---------------------------------------------------------------
java.lang.IllegalArgumentException: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
org.apache.catalina.session.StandardSession.setAttribute(StandardSession.java:1456)
org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:658)
org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:642)
org.apache.catalina.session.StandardSessionFacade.setAttribute(StandardSessionFacade.java:156)
org.ofbiz.order.order.OrderListState.getInstance(OrderListState.java:137)
sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
java.lang.reflect.Method.invoke(Method.java:597)
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:88)
org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrapNoCoerce.invoke(StaticMetaMethodSite.java:148)
org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.call(StaticMetaMethodSite.java:88)
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:124)
OrderList.run(OrderList.groovy:29)


Regards,
Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chatree Srichart updated OFBIZ-4660:
------------------------------------

    Attachment: order_list_state.patch

I hope the patch, order_list_state.patch attached file, will solve this problem.
               

> OrderListState need to be Serializable for clustering
> -----------------------------------------------------
>
>                 Key: OFBIZ-4660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4660
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu
>            Reporter: Chatree Srichart
>            Priority: Critical
>              Labels: clustering, order_list_state
>         Attachments: order_list_state.patch
>
>
> OrderListState is to be set to session, so it needs to be Serializable for clustering.
> I got this error:
> ---- cause ---------------------------------------------------------------------
> Exception: java.lang.IllegalArgumentException
> Message: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> ---- stack trace ---------------------------------------------------------------
> java.lang.IllegalArgumentException: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> org.apache.catalina.session.StandardSession.setAttribute(StandardSession.java:1456)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:658)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:642)
> org.apache.catalina.session.StandardSessionFacade.setAttribute(StandardSessionFacade.java:156)
> org.ofbiz.order.order.OrderListState.getInstance(OrderListState.java:137)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> java.lang.reflect.Method.invoke(Method.java:597)
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:88)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrapNoCoerce.invoke(StaticMetaMethodSite.java:148)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.call(StaticMetaMethodSite.java:88)
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:124)
> OrderList.run(OrderList.groovy:29)
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190689#comment-13190689 ]

Jacques Le Roux commented on OFBIZ-4660:
----------------------------------------

Hi Chatree,

I'd not use
+    private static final long serialVersionUID = 1L;
but
+    @SuppressWarnings("serial")
rather

This is what we decided some times ago http://markmail.org/message/x7r34bss3fwy2bn3
               

> OrderListState need to be Serializable for clustering
> -----------------------------------------------------
>
>                 Key: OFBIZ-4660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4660
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu
>            Reporter: Chatree Srichart
>            Priority: Critical
>              Labels: clustering, order_list_state
>         Attachments: order_list_state.patch
>
>
> OrderListState is to be set to session, so it needs to be Serializable for clustering.
> I got this error:
> ---- cause ---------------------------------------------------------------------
> Exception: java.lang.IllegalArgumentException
> Message: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> ---- stack trace ---------------------------------------------------------------
> java.lang.IllegalArgumentException: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> org.apache.catalina.session.StandardSession.setAttribute(StandardSession.java:1456)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:658)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:642)
> org.apache.catalina.session.StandardSessionFacade.setAttribute(StandardSessionFacade.java:156)
> org.ofbiz.order.order.OrderListState.getInstance(OrderListState.java:137)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> java.lang.reflect.Method.invoke(Method.java:597)
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:88)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrapNoCoerce.invoke(StaticMetaMethodSite.java:148)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.call(StaticMetaMethodSite.java:88)
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:124)
> OrderList.run(OrderList.groovy:29)
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chatree Srichart updated OFBIZ-4660:
------------------------------------

    Attachment: order_list_state.patch

Thanks Jacques Le Roux. I created a new patch for that.

Regards,
Chatree Srichart
               

> OrderListState need to be Serializable for clustering
> -----------------------------------------------------
>
>                 Key: OFBIZ-4660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4660
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu
>            Reporter: Chatree Srichart
>            Priority: Critical
>              Labels: clustering, order_list_state
>         Attachments: order_list_state.patch, order_list_state.patch
>
>
> OrderListState is to be set to session, so it needs to be Serializable for clustering.
> I got this error:
> ---- cause ---------------------------------------------------------------------
> Exception: java.lang.IllegalArgumentException
> Message: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> ---- stack trace ---------------------------------------------------------------
> java.lang.IllegalArgumentException: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> org.apache.catalina.session.StandardSession.setAttribute(StandardSession.java:1456)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:658)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:642)
> org.apache.catalina.session.StandardSessionFacade.setAttribute(StandardSessionFacade.java:156)
> org.ofbiz.order.order.OrderListState.getInstance(OrderListState.java:137)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> java.lang.reflect.Method.invoke(Method.java:597)
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:88)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrapNoCoerce.invoke(StaticMetaMethodSite.java:148)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.call(StaticMetaMethodSite.java:88)
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:124)
> OrderList.run(OrderList.groovy:29)
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4660:
--------------------------------------

    Assignee: Jacques Le Roux
   

> OrderListState need to be Serializable for clustering
> -----------------------------------------------------
>
>                 Key: OFBIZ-4660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4660
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu
>            Reporter: Chatree Srichart
>            Assignee: Jacques Le Roux
>            Priority: Critical
>              Labels: clustering, order_list_state
>         Attachments: order_list_state.patch, order_list_state.patch
>
>
> OrderListState is to be set to session, so it needs to be Serializable for clustering.
> I got this error:
> ---- cause ---------------------------------------------------------------------
> Exception: java.lang.IllegalArgumentException
> Message: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> ---- stack trace ---------------------------------------------------------------
> java.lang.IllegalArgumentException: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> org.apache.catalina.session.StandardSession.setAttribute(StandardSession.java:1456)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:658)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:642)
> org.apache.catalina.session.StandardSessionFacade.setAttribute(StandardSessionFacade.java:156)
> org.ofbiz.order.order.OrderListState.getInstance(OrderListState.java:137)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> java.lang.reflect.Method.invoke(Method.java:597)
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:88)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrapNoCoerce.invoke(StaticMetaMethodSite.java:148)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.call(StaticMetaMethodSite.java:88)
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:124)
> OrderList.run(OrderList.groovy:29)
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4660.
----------------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk
                   Release Branch 11.04
                   Release Branch 10.04
                   Release Branch 09.04

Thanks Chatree,

Your patch is in
trunk r1294090
R11.04 r1294092
R10.04 r1294093
R09.04 r1294095 (done by hand)


I don't see any problem committing this patch. But beware the design of OrderListState is faulty regarding notably browsers tabs, see bottom of OFBIZ-644
               

> OrderListState need to be Serializable for clustering
> -----------------------------------------------------
>
>                 Key: OFBIZ-4660
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4660
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Ubuntu
>            Reporter: Chatree Srichart
>            Assignee: Jacques Le Roux
>            Priority: Critical
>              Labels: clustering, order_list_state
>             Fix For: Release Branch 09.04, Release Branch 10.04, Release Branch 11.04, SVN trunk
>
>         Attachments: order_list_state.patch, order_list_state.patch
>
>
> OrderListState is to be set to session, so it needs to be Serializable for clustering.
> I got this error:
> ---- cause ---------------------------------------------------------------------
> Exception: java.lang.IllegalArgumentException
> Message: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> ---- stack trace ---------------------------------------------------------------
> java.lang.IllegalArgumentException: setAttribute: Non-serializable attribute __ORDER_LIST_STATUS__
> org.apache.catalina.session.StandardSession.setAttribute(StandardSession.java:1456)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:658)
> org.apache.catalina.ha.session.DeltaSession.setAttribute(DeltaSession.java:642)
> org.apache.catalina.session.StandardSessionFacade.setAttribute(StandardSessionFacade.java:156)
> org.ofbiz.order.order.OrderListState.getInstance(OrderListState.java:137)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> java.lang.reflect.Method.invoke(Method.java:597)
> org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:88)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite$StaticMetaMethodSiteNoUnwrapNoCoerce.invoke(StaticMetaMethodSite.java:148)
> org.codehaus.groovy.runtime.callsite.StaticMetaMethodSite.call(StaticMetaMethodSite.java:88)
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:124)
> OrderList.run(OrderList.groovy:29)
> Regards,
> Chatree Srichart

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira