OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

7 messages Options

Nicolas Malin (Jira)

[jira] [Created] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
------------------------------------------------------------------------------------------------------

Key: OFBIZ-4690
URL: https://issues.apache.org/jira/browse/OFBIZ-4690
Project: OFBiz
Issue Type: Improvement
Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
Reporter: Ankit Jain
Priority: Minor
Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk

If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ankit Jain updated OFBIZ-4690:
------------------------------

Attachment: OFBIZ-4690.patch

The attached patch will fix this issue.

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
> Reporter: Ankit Jain
> Priority: Minor
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Assigned] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-4690:
--------------------------------------

Assignee: Jacques Le Roux

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207775#comment-13207775 ]

Jacques Le Roux commented on OFBIZ-4690:
----------------------------------------

Hi Ankit,

I was wondering because OOTB the only place where a picklist is cancelled is in checkPicklistBinItemStatuses and it's done the reversed way you proposed (ie only cancel the picklist if all picklist items are cancelled). So, at least OOTB, this new ECA should never be fired. Do you think about some other processes you crossed?

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208290#comment-13208290 ]

Ankit Jain commented on OFBIZ-4690:
-----------------------------------

Hi Jacques,

Thanks to look into it.

If we cancel a picklist from Manage Picklist screen then this ECA will fire and cancel all the PicklistItem.

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 10.04, Release Branch 11.04, SVN trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-4690.
----------------------------------

Resolution: Fixed
Fix Version/s: (was: Release Branch 11.04)
(was: Release Branch 10.04)

Thanks Ankit,

As this is an improvement, I did not backport in releases.

Your patch is in trunk at revision: 1290890

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4690) If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211326#comment-13211326 ]

Ankit Jain commented on OFBIZ-4690:
-----------------------------------

Thanks Jacques. :)

> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.
> ------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4690
> URL: https://issues.apache.org/jira/browse/OFBIZ-4690
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Release 10.04, Release Branch 11.04, SVN trunk
> Reporter: Ankit Jain
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4690.patch
>
>
> If Picklist is Cancelled than all the PicklistItem related to that PicklistId should also get Cancel.