[jira] [Created] (OFBIZ-4694) return value of String.replace(CharSequence, CharSequence) ignored in org.ofbiz.widget.form.[Macro/Html]FormRenderer.appendExternalLoginKey(String)

[Nicolas Malin (Jira)]

return value of String.replace(CharSequence, CharSequence) ignored in org.ofbiz.widget.form.[Macro/Html]FormRenderer.appendExternalLoginKey(String)
---------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: OFBIZ-4694
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4694
             Project: OFBiz
          Issue Type: Bug
          Components: framework
    Affects Versions: SVN trunk
            Reporter: Michael Brohl
             Fix For: SVN trunk


Same error in both Classes MacroFormRenderer and HtmlFormRenderer.
Will provide a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Brohl updated OFBIZ-4694:
---------------------------------

    Attachment: OFBIZ-4694_return_value_of_String_replace.patch
   

> return value of String.replace(CharSequence, CharSequence) ignored in org.ofbiz.widget.form.[Macro/Html]FormRenderer.appendExternalLoginKey(String)
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4694
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4694
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Brohl
>              Labels: patch
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4694_return_value_of_String_replace.patch
>
>
> Same error in both Classes MacroFormRenderer and HtmlFormRenderer.
> Will provide a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp reassigned OFBIZ-4694:
--------------------------------------

    Assignee: Sascha Rodekamp
   

> return value of String.replace(CharSequence, CharSequence) ignored in org.ofbiz.widget.form.[Macro/Html]FormRenderer.appendExternalLoginKey(String)
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4694
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4694
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Brohl
>            Assignee: Sascha Rodekamp
>              Labels: patch
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4694_return_value_of_String_replace.patch
>
>
> Same error in both Classes MacroFormRenderer and HtmlFormRenderer.
> Will provide a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sascha Rodekamp closed OFBIZ-4694.
----------------------------------

    Resolution: Fixed

Thanks Michael, committed your slightly modified (removed blanks) patch in

Trunk @Rev 1244401
10_04 @Rev 1244402
11_04 @Rev 1244403

Have a good day
Sascha


               

> return value of String.replace(CharSequence, CharSequence) ignored in org.ofbiz.widget.form.[Macro/Html]FormRenderer.appendExternalLoginKey(String)
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4694
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4694
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Michael Brohl
>            Assignee: Sascha Rodekamp
>              Labels: patch
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4694_return_value_of_String_replace.patch
>
>
> Same error in both Classes MacroFormRenderer and HtmlFormRenderer.
> Will provide a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira