[jira] [Created] (OFBIZ-4699) Error in getProductInventoryAvailable with french formated number

[Nicolas Malin (Jira)]

Error in getProductInventoryAvailable with french formated number
-----------------------------------------------------------------

                 Key: OFBIZ-4699
                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
             Project: OFBiz
          Issue Type: Bug
          Components: product
    Affects Versions: SVN trunk
            Reporter: Gaudin Pierre
         Attachments: InventoryServices.xml.patch

The calculation of the available quantities by location does not take into account the local formatting of the numbers.

How to see the problem:
- Be in French local
- Create for the same product several inventory items with ATP and QOH > 999.
- Go to the product inventory view
- The values are not correct for locations

The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gaudin Pierre updated OFBIZ-4699:
---------------------------------

    Attachment: InventoryServices.xml.patch
   

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209370#comment-13209370 ]

Adrian Crum commented on OFBIZ-4699:
------------------------------------

The attached patch is a regression - it replaces a UEL expression with the defunct <calculate> element. It would be better to do the String-to-BigDecimal conversions before using the UEL expression.

               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209370#comment-13209370 ]

Adrian Crum edited comment on OFBIZ-4699 at 2/16/12 2:07 PM:
-------------------------------------------------------------

The attached patch is a regression - it replaces a UEL expression with the obsolete <calculate> element. It would be better to do the String-to-BigDecimal conversions before using the UEL expression.

               
      was (Author: [hidden email]):
    The attached patch is a regression - it replaces a UEL expression with the defunct <calculate> element. It would be better to do the String-to-BigDecimal conversions before using the UEL expression.

                 

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209380#comment-13209380 ]

Gaudin Pierre commented on OFBIZ-4699:
--------------------------------------

Thank you Adrian for the review of this patch.

Can you explain why it is better to include UEL rather than to use standard tag of the minilanguage?


               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209420#comment-13209420 ]

Adrian Crum commented on OFBIZ-4699:
------------------------------------

The reason should be obvious from your patch - two UEL expressions can replace 12 lines of <calculate> code.

               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209767#comment-13209767 ]

Gaudin Pierre commented on OFBIZ-4699:
--------------------------------------

This is a criticism of the minilanguage but not of the patch.

Can I hope that this patch will be integrate?
               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209825#comment-13209825 ]

Adrian Crum commented on OFBIZ-4699:
------------------------------------

The criticism of the patch was in my first comment - it is a regression. No, it will not be applied because it takes the project backwards.

               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209854#comment-13209854 ]

Gaudin Pierre commented on OFBIZ-4699:
--------------------------------------

Sorry but i can't read any explanation in your previous message why <calculate> is obsolete.

Surely i'm wrong but why ???
               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209859#comment-13209859 ]

Adrian Crum commented on OFBIZ-4699:
------------------------------------

It is obsolete because it has been replaced with UEL expressions. Convert the two parameter Strings to BigDecimals before the expression and you're good to go. But don't bring back obsolete code.


               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210136#comment-13210136 ]

Jacques Le Roux commented on OFBIZ-4699:
----------------------------------------

This may help https://cwiki.apache.org/confluence/display/OFBTECH/Unified+Expression+Language+%28JSR-245%29+in+OFBiz
               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210142#comment-13210142 ]

Nicolas Malin commented on OFBIZ-4699:
--------------------------------------

I check the patch and I think that there is a misunderstanding.

 parameters.quantityOnHandTotal is a BigDecimal and inventoryItem.quantityOnHandTotal is also a BigDecimal. The problem that solve pierre is to call directly operation with BigDecimal instead of use a flexible string that convert BigDecimal to String and String to BigDecimal for return value.

For me, pierre solve with a good solution.

On other point, I am little surprised by replace calculate by uel. Simple method is a high level language, use mainly by the functional, uel need to know conversion problem. It's a regression for me to use uel inseated of mini-lang, uel is pretty good but not on functional context (this is my opinion ;) )

On mini-lang xsd or wiki I don't found information on obsoleted calculate code, where I can found most information on the reason ?

Nicolas
               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213493#comment-13213493 ]

Gaudin Pierre commented on OFBIZ-4699:
--------------------------------------

Thanks for all  your comments

Adrian, what do you think about Nicolas's comments ? I think he's right

Pierre
               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213508#comment-13213508 ]

Adrian Crum commented on OFBIZ-4699:
------------------------------------

I think both of you should read the commit log message from revision 741423.

               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216464#comment-13216464 ]

Olivier Heintz commented on OFBIZ-4699:
---------------------------------------

Adrian,

Just to be sure to understand :
UEL calculation is done with BigDecimal methods when field type are BigDecimal ?
               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[Nicolas Malin (Jira)]

    [ https://issues.apache.org/jira/browse/OFBIZ-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216507#comment-13216507 ]

Adrian Crum commented on OFBIZ-4699:
------------------------------------

http://jsp.java.net/spec/jsp-2_1-fr-spec-el.pdf

Section 1.18.3.

               

> Error in getProductInventoryAvailable with french formated number
> -----------------------------------------------------------------
>
>                 Key: OFBIZ-4699
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4699
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: SVN trunk
>            Reporter: Gaudin Pierre
>         Attachments: InventoryServices.xml.patch
>
>
> The calculation of the available quantities by location does not take into account the local formatting of the numbers.
> How to see the problem:
> - Be in French local
> - Create for the same product several inventory items with ATP and QOH > 999.
> - Go to the product inventory view
> - The values are not correct for locations
> The patch corrects this problem by using the standard methods of the minilanguage

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira