[jira] [Created] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
Locked
12
12
[jira] [Created] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
 
|
Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
------------------------------------------------------------------------------------------------ Key: OFBIZ-4715 URL: https://issues.apache.org/jira/browse/OFBIZ-4715 Project: OFBiz Issue Type: Bug Components: party, specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Markus M. May Priority: Minor Fix For: SVN trunk The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214495#comment-13214495 ] Pierre Smits commented on OFBIZ-4715: ------------------------------------- The location and composition of the postal code is dependent on national definition. For instance, some countries have the country code before the postal code before the name of the city. Others have country code and postal code on a new line below the name of the city. See http://en.wikipedia.org/wiki/Postal_code In stead of removal, I suggest to look a bit deeper in all the variations and devise a solution that facilitates all. Regards, Pierre Smits > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus M. May updated OFBIZ-4715: --------------------------------- Attachment: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch Determine the country with the locale, remove stateProvinceGeoId if country is not equal US in Contact.ftl > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214522#comment-13214522 ] Markus M. May commented on OFBIZ-4715: -------------------------------------- These are a lot of different ways on how to do this. How should this be implemented in a "common" way. I am thinking about a configuration via an XML-Locale file. This is on the other hand a misuse of locales, since I would retrieve the locale via the country code and not from the user locale. What do you think? > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214540#comment-13214540 ] Jose F. Fernandez commented on OFBIZ-4715: ------------------------------------------ I think that the address template must be personalized by locales, but not by user locale or country, because is a user from Spain (for example, me) send an invoice to a USA costumer, the address must be formatted according to the USA locale. So it must be by the address locale. I'm thinking right? > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214541#comment-13214541 ] Jacopo Cappellato commented on OFBIZ-4715: ------------------------------------------ Maybe a better way is to create a simple dynamic mechanism to lookup, based on the postalAddress.countryGeoId, if there is a country specific ftl; if not use the default one. Steps to implement this feature could be: * extract from Contact.ftl the existing code that formats the postal address into a separate PostalAddress.ftl (or similar) template; * in Contact.ftl, where the postal address needs to be rendered, get the postalAddress.countryGeoId and try to locate a template with file name: PostalAddress_${postalAddress.countryGeoId}.ftl (e.g. PostalAddress_USA.ftl or PostalAddress_FRA.ftl); if not found then default to PostalAddress.ftl * the same mechanism could be reused for invoices etc... * it would be nice (but maybe not too easy) to try to implement all the PostalAddress_*.ftl templates in a way that will let them to be reused in various screens, possibly using the <@htmlTemplate/> tags, with minimal to no formatting/styling; but it would be also nice to be able to reuse them for PDF rendering (form widgets?) Just my 2 cents > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214573#comment-13214573 ] Markus M. May commented on OFBIZ-4715: -------------------------------------- Jacopo: This solution is interesting. The only problem I do see is that we do need a new database entity (PostalAddressFTL) which references the CountryCode and also the ftl for this (e.g. PostalAddress_USA.ftl). Furthermore if an FTL does not exist for a countryCode we need a default ftl (PostalAddress.ftl). Then this data needs to get retrieved from the DB (which is quite easy), and the seed data needs to get extended for each FTL. Sounds like a lot of effort and also a lot of things, which could be forgotten or could go wrong. WDYT? > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214654#comment-13214654 ] Anil K Patel commented on OFBIZ-4715: ------------------------------------- Ofbiz is designed to be customized. Templates used for rendering data are some of the objects in Ofbiz that gets customized the most. Keeping these two things in mind, its better to not try to make templates do to much. Instead if they are simple, users (in this case developers implementing ofbiz) will be able to understand the code much easy and might customize them to fit their project needs. My two cents :) > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214669#comment-13214669 ] Jacopo Cappellato commented on OFBIZ-4715: ------------------------------------------ Markus, I was not suggesting to add new entities but simply to adopt the naming convention I explained above: nothing more or less than this; all the country variant templates could stay in the same folder and the system could easily try to locate them in the filesystem without the need to lookup custom entities. And adding a custom template would be a matter of copying it in that folder with the proper naming convention. I hope it clarifies what I was suggesting. > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214779#comment-13214779 ] Joe Eckard commented on OFBIZ-4715: ----------------------------------- I agree with the general idea (see [this dev list message from 2008|http://mail-archives.apache.org/mod_mbox/ofbiz-dev/200811.mbox/%3cE1B0D743-B98E-4D7E-A843-A9DDDCD5B1E4@...%3e]), but something else to consider is that you will most like want different templates for HTML & XSL:FO. > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Issue Comment Edited] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214779#comment-13214779 ] Joe Eckard edited comment on OFBIZ-4715 at 2/23/12 2:50 PM: ------------------------------------------------------------ I agree with the general idea (see [this dev list message from 2008|http://mail-archives.apache.org/mod_mbox/ofbiz-dev/200811.mbox/%3cE1B0D743-B98E-4D7E-A843-A9DDDCD5B1E4@...%3e]), but something else to consider is that you will most like want different templates for HTML display, HTML form input & XSL:FO. was (Author: eckardjf): I agree with the general idea (see [this dev list message from 2008|http://mail-archives.apache.org/mod_mbox/ofbiz-dev/200811.mbox/%3cE1B0D743-B98E-4D7E-A843-A9DDDCD5B1E4@...%3e]), but something else to consider is that you will most like want different templates for HTML & XSL:FO. > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214786#comment-13214786 ] Jacopo Cappellato commented on OFBIZ-4715: ------------------------------------------ Yeah, I agree... we may simply use the same lookup mechanism for XSL-FO but search for files with the fo.ftl suffix. > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214884#comment-13214884 ] Markus M. May commented on OFBIZ-4715: -------------------------------------- I am currently a little lost in this task. Guess I will push it back a little ;-( > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Issue Comment Edited] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214884#comment-13214884 ] Markus M. May edited comment on OFBIZ-4715 at 2/23/12 5:55 PM: --------------------------------------------------------------- I am currently a little lost in this task. My current setup is as follows: 1) A groovy component to determine the countryCode and with this determines the ftl-name and if it is available, if not, it will return the usual PostalAddress.ftl 2) new PostalAddressScreen, which calls the above mentioned groovy component and calls the html-template PostalAddress* from the groovy script from the context 3) Adopt the Contact.ftl to call the new screen with the postalAddress in the context, so that I do have access to this in the screen <#assign postalAddress = contactMechMap.postalAddress> ${setRequestAttribute("postalAddress", postalAddress)} ${screens.render("component://party/widget/partymgr/PostalAddressScreens.xml#postalAddress")} 4) new PostalAddress.ftl, which can have several instances (PostalAddress_DE.ftl, PostalAddress_USA.ftl, ...) Am I walking in the right direction? was (Author: [hidden email]): I am currently a little lost in this task. Guess I will push it back a little ;-( > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus M. May updated OFBIZ-4715: --------------------------------- Attachment: OFBIZ-4715-initial-commit.patch Initial commit, I still receive errors that the parameter PostalAddress is empty. Any help on this one? > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-initial-commit.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus M. May updated OFBIZ-4715: --------------------------------- Attachment: OFBIZ-4715-initial-commit.patch Upload with all git related stuff removed. > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Assigned] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-4715: ---------------------------------------- Assignee: Jacopo Cappellato > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Assignee: Jacopo Cappellato > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215565#comment-13215565 ] Jacopo Cappellato commented on OFBIZ-4715: ------------------------------------------ Hi Markus, I have completed and improved your initial patch and then committed it in revision 1293204. You should follow a similar approach to implement a similar mechanism for fo.ftl templates (for PDF files). > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Assignee: Jacopo Cappellato > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Updated] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus M. May updated OFBIZ-4715: --------------------------------- Attachment: OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch The attached patch should fix this issue. I have implemented a common groovy-script for both the quote as well as the company header. This should work for all other implementations as well, so probably we could even adopt the one in the already implemented one for the profile. We would just need to edit the folder, but the groovy script could be the same for all these screens ;-) > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Assignee: Jacopo Cappellato > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
|
|
In reply to this post by Nicolas Malin (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219236#comment-13219236 ] Jacopo Cappellato commented on OFBIZ-4715: ------------------------------------------ Hi Markus, I have some suggestions to further improve your patch (and this new feature in general): * the two screens companyPostalAddress and postalAddress can be unified into one generic screen with name "postalAddressPdf" or similar; the screen definitions should be moved to the party component * more generally, the new generic artifacts for fo-ftl that you have created should be defined in the party component in the same locations where I have committed the ones for fo formatting: in this way the party component will offer a small library of templates for the formatting of html/PDF postal addresses properly localized; then the order component (order PDF and quote PDF) will reuse them to render the documents; could you please also move to party component the GetPostalAddressTemplate.groovy script, the templates PostalAddress.fo.ftl and PostalAddress_USA.fo.ftl there? * the script that you have created with name GetPostalAddressTemplate.groovy is very similar to the one I have committed; could you please try to merge them into the same script? the script could accept as an additional parameter the template suffix (.ftl or .fo.ftl) and do the lookup accordingly * please also try to use, in the generic script/templates neutral names for variables: please use "postalAddress" rather than "usedPostalAddress" etc... Thanks > Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code > ------------------------------------------------------------------------------------------------ > > Key: OFBIZ-4715 > URL: https://issues.apache.org/jira/browse/OFBIZ-4715 > Project: OFBiz > Issue Type: Bug > Components: party, specialpurpose/ecommerce > Affects Versions: SVN trunk > Reporter: Markus M. May > Assignee: Jacopo Cappellato > Priority: Minor > Fix For: SVN trunk > > Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch > > > The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual. > I propose to avoid this by removing the Region Code if the country is different then US. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira |
«
Return to OFBiz - Dev
|
1 view|%1 views
| Free forum by Nabble | Edit this page |