OFBiz › OFBiz - Dev

[jira] [Created] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

27 messages Options

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219357#comment-13219357 ]

Markus M. May commented on OFBIZ-4715:
--------------------------------------

Hi Jacopo,

thanks for the Input.

I can try to use postalAddress instead of usedPostalAddress, I just wanted to avoid Naming Conflicts for the variables, so that we are able to use the same script for multiple Screens. I was thinking along the lines that the same script multiple could only be called multiple times, if the corresponding variable is not already used in the same Screen. Otherwise the variable in the Screen would probably overwrite an already existing variable and therefor would return a wrong result. Am I wrong with this assumption?
Other then that, I will dig into this and will try to solve this asap.

> Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
> ------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4715
> URL: https://issues.apache.org/jira/browse/OFBIZ-4715
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch
>
>
> The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual.
> I propose to avoid this by removing the Region Code if the country is different then US.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219934#comment-13219934 ]

Jacopo Cappellato commented on OFBIZ-4715:
------------------------------------------

Hi Markus,

if the variable name "postalAddress" will cause conflicts you can use a different name that still makes sense and it is generic.

And after thinking more about this, I would suggest also to change the names of the generic screens in the following way (or similar):
postalAddress ---> postalAddressHtmlFormatter
postalAddressPdf ---> postalAddressPdfFormatter

then the name of the input "postalAddress" variable (i.e. the GenericValue that contains the postal address) could be renamed:

postalAddress ---> postalAddressFormatter_postalAddress (or similar)

I hope it helps

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus M. May updated OFBIZ-4715:
---------------------------------

Attachment: OFBIZ-4715-central-partymgr-solution.patch

This patch provides a central solution for the address-formatting of HTML as well as PDFs in the partymgr application.

> Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
> ------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4715
> URL: https://issues.apache.org/jira/browse/OFBIZ-4715
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch
>
>
> The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual.
> I propose to avoid this by removing the Region Code if the country is different then US.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221951#comment-13221951 ]

Markus M. May commented on OFBIZ-4715:
--------------------------------------

No problem using the same variable all over ;-) The patch calls now postalAddressHtmlFormatter or postalAddressPdfFormatter in the PartyScreens.xml from Contact.ftl and companyHeader.fo.ftl and ordercontactinfo.ftl as well as quoteReportContactMechs.fo.ftl.

A ${setRequestAttribute("postalAddress", toPostalAddress)} is called before the screen is rendered, to set the postalAddress accordingly. The postalAddress.fo.ftl as well as postalAddress.ftl are aggregated into the applications/party/webapp/partymgr/party/contactmechtemplates/ folder.

Hope this helps ;-)

> Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
> ------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4715
> URL: https://issues.apache.org/jira/browse/OFBIZ-4715
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch
>
>
> The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual.
> I propose to avoid this by removing the Region Code if the country is different then US.

Nicolas Malin (Jira)

[jira] [Commented] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237870#comment-13237870 ]

Jacques Le Roux commented on OFBIZ-4715:
----------------------------------------

Markus,

Dont forget to mark the issues as "Patch provided" when attaching patch/es

Thanks

> Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
> ------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4715
> URL: https://issues.apache.org/jira/browse/OFBIZ-4715
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch
>
>
> The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual.
> I propose to avoid this by removing the Region Code if the country is different then US.

Nicolas Malin (Jira)

[jira] [Updated] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

In reply to this post by Nicolas Malin (Jira)

> Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
> ------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4715
> URL: https://issues.apache.org/jira/browse/OFBIZ-4715
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch
>
>
> The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual.
> I propose to avoid this by removing the Region Code if the country is different then US.

Nicolas Malin (Jira)

[jira] [Closed] (OFBIZ-4715) Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code

In reply to this post by Nicolas Malin (Jira)

[ https://issues.apache.org/jira/browse/OFBIZ-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacopo Cappellato closed OFBIZ-4715.
------------------------------------

> Invoice PDF and Contact Information show Region Code instead of Country Code before the Zip Code
> ------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4715
> URL: https://issues.apache.org/jira/browse/OFBIZ-4715
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Markus M. May
> Assignee: Jacopo Cappellato
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4715-add-locale-for-country-and-remove-countryGeo-if-not-us.patch, OFBIZ-4715-add-postal-address-formatting-to-fo-ftls.patch, OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-central-partymgr-solution.patch, OFBIZ-4715-initial-commit.patch, OFBIZ-4715-initial-commit.patch
>
>
> The Invoice PDF and the Contact Information in the Party application show the Region Code instead of the Country Code before the Zip Code. This will be fine for the US, here in Germany it is rather unusual.
> I propose to avoid this by removing the Region Code if the country is different then US.